From patchwork Mon Oct 9 12:15:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9992821 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5BBA760230 for ; Mon, 9 Oct 2017 12:17:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D8C628640 for ; Mon, 9 Oct 2017 12:17:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 425D9287AC; Mon, 9 Oct 2017 12:17:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 489EC28640 for ; Mon, 9 Oct 2017 12:17:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751896AbdJIMRL (ORCPT ); Mon, 9 Oct 2017 08:17:11 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:38466 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbdJIMRL (ORCPT ); Mon, 9 Oct 2017 08:17:11 -0400 Received: by mail-pf0-f193.google.com with SMTP id a7so27334507pfj.5; Mon, 09 Oct 2017 05:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=vwzg9YPk5nWvZeDTwMqMUsetimWTDL5qCRJkdtIISKQ=; b=X5xbTe0ffmHtWL9WNFz/DU1yiDh6gV0+JZqrfRF5wZCiYbspTk/RWtLRvLKEcCqfy7 mteDUlLAW8fiEO032pGD3jY9aW6RS2U1eQxj0gOr3pmOjKrbkN5JNTuotgPplIqSkDM3 dj1muRJ/kLeGikPkm3cp+z4fbDz5qd1rqxg8vUZOzK9PnxrSTJ/BAyKF72kuLNsXKVsC IekfSbpGg59JYNOx1KLPbgSUX5a1L9m57wAVqxjEBTIMbxa94hmcVioRnmbyYxEBp/XL 3bbnqTL+bKBHD+/c6sXRB2smsMtNCRU8wkL9dtEnYa1aPWpeySnLFj2Sb0e2cUgii69G Tkug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vwzg9YPk5nWvZeDTwMqMUsetimWTDL5qCRJkdtIISKQ=; b=l9p3qfQGOrtf1jLEIubw9c+IeEIjT85z7B839bCVFenp22u/MWchD4/SpEPPARaMbR 4il81Gw2Fv00f6TwS4E4f134JI3LSccDWHjP6tFJH3oX+45+ekMkHu1cdZ8p3eN42kCD Kv0lFTEoTesxpCPkaeNruq+kDn1Qmq9BjwVcZUMHGIPfnjbqk7kAzy8g4uf6G4WSTjFR OxEUNJU2Nh78KGda6tHPfsYKjJnLPzsih5Rfa5GCsKaoVVZW0R0lnrsmHEVE90iVC6J/ uDP7uAGU1FQy5t/WU+eLEfZ9r090yA1DMcsLST5D6vDUqSQa+yXmH/BgF4eyT3xQNWuO re6w== X-Gm-Message-State: AMCzsaXX+n3PHDqKi3hHbdWCw/nuHmYXi6oGCud/x2MILgIsr3X6fkdI D5kPvsj/v5UTEnqwaXgvCwD7Rw== X-Google-Smtp-Source: AOwi7QBwX1/dIDc5Vilxh7twdLRltHHwPfRHy9uZc2DvEMezZbsc39Hj0rf2Z27s9+NgqEiZhry8MQ== X-Received: by 10.98.150.149 with SMTP id s21mr3608915pfk.151.1507551430446; Mon, 09 Oct 2017 05:17:10 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m10sm13479240pgs.77.2017.10.09.05.17.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Oct 2017 05:17:09 -0700 (PDT) From: Arvind Yadav To: ysato@users.sourceforge.jp, dalias@libc.org Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] sh: clkfwk: use '"%s:", __func__' instead of function name. Date: Mon, 9 Oct 2017 17:45:45 +0530 Message-Id: <6394b165cf42e5f226db8f47589a7e0aff15fee2.1507551115.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The script "checkpatch.pl" pointed information out like the following. WARNING: Prefer using '"%s...", __func__' to using 'sh_clk_init_parent', this function's name, in a string. pr_err() strings should end with newlines. Add '\n' to fix this. Signed-off-by: Arvind Yadav --- drivers/sh/clk/cpg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/sh/clk/cpg.c b/drivers/sh/clk/cpg.c index 7442bc1..4b5b2f6 100644 --- a/drivers/sh/clk/cpg.c +++ b/drivers/sh/clk/cpg.c @@ -217,7 +217,7 @@ static int __init sh_clk_init_parent(struct clk *clk) return 0; if (!clk->src_width) { - pr_err("sh_clk_init_parent: cannot select parent clock\n"); + pr_err("%s: cannot select parent clock\n", __func__); return -EINVAL; } @@ -225,13 +225,13 @@ static int __init sh_clk_init_parent(struct clk *clk) val &= (1 << clk->src_width) - 1; if (val >= clk->parent_num) { - pr_err("sh_clk_init_parent: parent table size failed\n"); + pr_err("%s: parent table size failed\n", __func__); return -EINVAL; } clk_reparent(clk, clk->parent_table[val]); if (!clk->parent) { - pr_err("sh_clk_init_parent: unable to set parent"); + pr_err("%s: unable to set parent\n", __func__); return -EINVAL; }