From patchwork Wed Jun 19 13:16:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 2749131 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 90DA6C0AB1 for ; Wed, 19 Jun 2013 13:15:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 36D7D20364 for ; Wed, 19 Jun 2013 13:15:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C624C2035D for ; Wed, 19 Jun 2013 13:15:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756566Ab3FSNPq (ORCPT ); Wed, 19 Jun 2013 09:15:46 -0400 Received: from perceval.ideasonboard.com ([95.142.166.194]:35458 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756468Ab3FSNPp (ORCPT ); Wed, 19 Jun 2013 09:15:45 -0400 Received: from avalon.localnet (unknown [91.178.248.38]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B54EA35A4D; Wed, 19 Jun 2013 15:15:37 +0200 (CEST) From: Laurent Pinchart To: Magnus Damm Cc: SH-Linux , Arnd Bergmann , "Simon Horman [Horms]" , Olof Johansson , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2] ARM: shmobile: uImage load address rework Date: Wed, 19 Jun 2013 15:16:01 +0200 Message-ID: <76205076.EsFJngGrIh@avalon> User-Agent: KMail/4.10.2 (Linux/3.8.13-gentoo; KDE/4.10.2; x86_64; ; ) In-Reply-To: <3243557.sP7VV5jPVm@avalon> References: <20130610092857.19175.25629.sendpatchset@w520> <3243557.sP7VV5jPVm@avalon> MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Magnus, On Wednesday 12 June 2013 04:31:26 Laurent Pinchart wrote: > On Wednesday 12 June 2013 11:21:34 Magnus Damm wrote: > > On Wed, Jun 12, 2013 at 6:50 AM, Laurent Pinchart wrote: > > > On Monday 10 June 2013 18:28:57 Magnus Damm wrote: > > >> From: Magnus Damm > > >> > > >> This is V2 of the mach-shmobile uImage load address rework patch. > > >> > > >> Rework the mach-shmobile uImage load address calculation by storing > > >> the per-board load addresses in Makefile.boot. This removes the > > >> CONFIG_MEMORY_START dependency from Makefile.boot, and it also makes > > >> it possible to create safe kernel images that boot on multiple boards. > > >> > > >> This is one of several series of code that reworks code not to rely on > > >> CONFIG_MEMORY_START/SIZE which in turn is needed for > > >> ARCH_MULTIPLATFORM. > > >> > > >> Signed-off-by: Magnus Damm > > >> Reviewed-by: Laurent Pinchart > > >> Reviewed-by: Kuninori Morimoto > > > > > > I've noticed today that KZM9G doesn't boot v3.10-rc2 with > > > CONFIG_AUTO_ZRELADDR=y. While not caused by this patch, that's something > > > that will need to be fixed to support multi-arch kernels. I'm not too > > > familiar with early boot code, would you be able to have a look at this > > > ? > > > > I will have a look. I suspect that issue is not related to this patch, is > > it? > > No, it isn't, the issue is present in v3.10-rc2. I don't know if it has ever > worked. The following patch fixes the issue, caused by physical RAM being present at 0x41000000 on KZM9G. I'm not sure if it would be acceptable as a generic solution though. diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S index fe4d9c3..ea2f112 100644 --- a/arch/arm/boot/compressed/head.S +++ b/arch/arm/boot/compressed/head.S @@ -176,7 +176,7 @@ not_angel: #ifdef CONFIG_AUTO_ZRELADDR @ determine final kernel image address mov r4, pc - and r4, r4, #0xf8000000 + and r4, r4, #0xff000000 add r4, r4, #TEXT_OFFSET #else ldr r4, =zreladdr