From patchwork Wed Apr 1 21:54:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 6142471 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 895009F1BE for ; Wed, 1 Apr 2015 21:55:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A7337200F0 for ; Wed, 1 Apr 2015 21:55:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B655320306 for ; Wed, 1 Apr 2015 21:55:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752167AbbDAVzE (ORCPT ); Wed, 1 Apr 2015 17:55:04 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33886 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbbDAVzD (ORCPT ); Wed, 1 Apr 2015 17:55:03 -0400 Received: by pactp5 with SMTP id tp5so64023207pac.1 for ; Wed, 01 Apr 2015 14:55:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=a/CXWYJjTQaxGYao0EctD4QbuxaQDu5H7G1KOcMtA50=; b=SjfyfbNse9wQwExpmwnCJntywzR3wcVDMQlO4J7uwQabXJwfJh+6f1rNwzeJM8q7nr g1iS1o31Lsz0etmQSb5Zy0okwjiSf4bfZihMMFJ3fnAF8F7I078aQMz42BUFaY+Jh68s tpCIjsh50BQ4foIU8a8g7HyGdnpP0OcggK6Movs1nUk7LVjK7DCnfSXK0QxeB++Uw/pw 8OCWuTkeLpxRsNil/OMe+y8MaamRtV6Ij/VlUdyeRiZ/7C5MapZICXClzywkzVDRW5wI Temxg3svbjWXrtdHqEUG2aK9iM7dXm2omU4vopSvGrbHyCrQ7Gz/AuTslMIbPizaKzTy iMtQ== X-Gm-Message-State: ALoCoQmoeNcTLtL9gAoQb5pAoAkJDzwYSNJbDeroAMTpJaBFK9UpwweqCl4917LCRKdEvPbaFXEb X-Received: by 10.68.179.225 with SMTP id dj1mr21329993pbc.0.1427925302176; Wed, 01 Apr 2015 14:55:02 -0700 (PDT) Received: from localhost (c-67-160-101-93.hsd1.wa.comcast.net. [67.160.101.93]) by mx.google.com with ESMTPSA id br5sm2618517pbd.73.2015.04.01.14.55.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 01 Apr 2015 14:55:01 -0700 (PDT) From: Kevin Hilman To: Andrew Morton Cc: Marc Zyngier , Geert Uytterhoeven , Ard Biesheuvel , Will Deacon , Simon Horman , Tyler Baker , Nishanth Menon , Russell King - ARM Linux , Arnd Bergmann , "linux-sh\@vger.kernel.org" , Catalin Marinas , Magnus Damm , "grygorii.strashko\@linaro.org" , "linux-omap\@vger.kernel.org" , "linux-arm-kernel\@lists.infradead.org" , Linux Kernel Development , "linux-mm\@kvack.org" Subject: Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3 References: <20150324004537.GA24816@verge.net.au> <20150324161358.GA694@kahuna> <20150326003939.GA25368@verge.net.au> <20150326133631.GB2805@arm.com> <20150327002554.GA5527@verge.net.au> <20150327100612.GB1562@arm.com> <7hbnj99epe.fsf@deeprootsystems.com> <7h8uec95t2.fsf@deeprootsystems.com> <551BBEC5.7070801@arm.com> <20150401124007.20c440cc43a482f698f461b8@linux-foundation.org> Date: Wed, 01 Apr 2015 14:54:59 -0700 In-Reply-To: <20150401124007.20c440cc43a482f698f461b8@linux-foundation.org> (Andrew Morton's message of "Wed, 1 Apr 2015 12:40:07 -0700") Message-ID: <7hwq1v4iq4.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Andrew Morton writes: > On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier wrote: > >> > -static int unmap_and_move(new_page_t get_new_page, free_page_t put_new_page, >> > - unsigned long private, struct page *page, int force, >> > - enum migrate_mode mode) >> > +static noinline int unmap_and_move(new_page_t get_new_page, >> > + free_page_t put_new_page, >> > + unsigned long private, struct page *page, >> > + int force, enum migrate_mode mode) >> > { >> > int rc = 0; >> > int *result = NULL; >> > >> >> Ouch. That's really ugly. And on 32bit ARM, we end-up spilling half of >> the parameters on the stack, which is not going to help performance >> either (not that this would be useful on 32bit ARM anyway...). >> >> Any chance you could make this dependent on some compiler detection >> mechanism? > > With my arm compiler (gcc-4.4.4) the patch makes no difference - > unmap_and_move() isn't being inlined anyway. > > How does this look? > > Kevin, could you please retest? I might have fat-fingered something... Your patch on top of Geert's still compiles fine for me with gcc-4.7.3. However, I'm not sure how specific we can be on the versions. /me goes to test a few more compilers... OK... ICE: 4.7.1, 4.7.3, 4.8.3 OK: 4.6.3, 4.9.2, 4.9.3 The diff below[2] on top of yours compiles fine here and at least covers the compilers I *know* to trigger the ICE. Kevin [1] --- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/mm/migrate.c b/mm/migrate.c index 25fd7f6291de..6e15ae3248e0 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -901,10 +901,10 @@ out: } /* - * gcc-4.7.3 on arm gets an ICE when inlining unmap_and_move(). Work around + * gcc 4.7 and 4.8 on arm gets an ICE when inlining unmap_and_move(). Work around * it. */ -#if GCC_VERSION == 40703 && defined(CONFIG_ARM) +#if (GCC_VERSION >= 40700 && GCC_VERSION < 40900) && defined(CONFIG_ARM) #define ICE_noinline noinline #else #define ICE_noinline