diff mbox

[01/19] ARM: shmobile: r8a73a4: Add pin control device to device tree

Message ID 803d319cb2fb41e646669061b45701f3ea78e611.1374625203.git.horms+renesas@verge.net.au (mailing list archive)
State Accepted
Commit 803d319cb2fb41e646669061b45701f3ea78e611
Headers show

Commit Message

Simon Horman July 24, 2013, 12:32 a.m. UTC
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Add a pfc node to the r8a73a4 device tree.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
[g.liakhovetski+renesas@gmail.com use 2 nodes for address and size]
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a73a4.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Guennadi Liakhovetski July 24, 2013, 6:11 a.m. UTC | #1
Hi Simon

On Wed, 24 Jul 2013, Simon Horman wrote:

> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> 
> Add a pfc node to the r8a73a4 device tree.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> [g.liakhovetski+renesas@gmail.com use 2 nodes for address and size]

it's actually "cells," not "nodes."

Thanks
Guennadi

> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/boot/dts/r8a73a4.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a73a4.dtsi b/arch/arm/boot/dts/r8a73a4.dtsi
> index 4ff2019..b886afd 100644
> --- a/arch/arm/boot/dts/r8a73a4.dtsi
> +++ b/arch/arm/boot/dts/r8a73a4.dtsi
> @@ -85,4 +85,11 @@
>  		interrupt-parent = <&gic>;
>  		interrupts = <0 69 4>;
>  	};
> +
> +	pfc: pfc@e6050000 {
> +		compatible = "renesas,pfc-r8a73a4";
> +		reg = <0 0xe6050000 0 0x9000>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
>  };
> -- 
> 1.8.2.1
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman July 24, 2013, 7:23 a.m. UTC | #2
On Wed, Jul 24, 2013 at 08:11:33AM +0200, Guennadi Liakhovetski wrote:
> Hi Simon
> 
> On Wed, 24 Jul 2013, Simon Horman wrote:
> 
> > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > 
> > Add a pfc node to the r8a73a4 device tree.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > [g.liakhovetski+renesas@gmail.com use 2 nodes for address and size]
> 
> it's actually "cells," not "nodes."

Thanks. I'd like to leave the comment as is unless there
is a more compelling reason to re-base the pull-request.

> Thanks
> Guennadi
> 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm/boot/dts/r8a73a4.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/r8a73a4.dtsi b/arch/arm/boot/dts/r8a73a4.dtsi
> > index 4ff2019..b886afd 100644
> > --- a/arch/arm/boot/dts/r8a73a4.dtsi
> > +++ b/arch/arm/boot/dts/r8a73a4.dtsi
> > @@ -85,4 +85,11 @@
> >  		interrupt-parent = <&gic>;
> >  		interrupts = <0 69 4>;
> >  	};
> > +
> > +	pfc: pfc@e6050000 {
> > +		compatible = "renesas,pfc-r8a73a4";
> > +		reg = <0 0xe6050000 0 0x9000>;
> > +		gpio-controller;
> > +		#gpio-cells = <2>;
> > +	};
> >  };
> > -- 
> > 1.8.2.1
> > 
> 
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a73a4.dtsi b/arch/arm/boot/dts/r8a73a4.dtsi
index 4ff2019..b886afd 100644
--- a/arch/arm/boot/dts/r8a73a4.dtsi
+++ b/arch/arm/boot/dts/r8a73a4.dtsi
@@ -85,4 +85,11 @@ 
 		interrupt-parent = <&gic>;
 		interrupts = <0 69 4>;
 	};
+
+	pfc: pfc@e6050000 {
+		compatible = "renesas,pfc-r8a73a4";
+		reg = <0 0xe6050000 0 0x9000>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
 };