| Message ID | 82d5efdde44f9489c5a7d11d0a19750445116c95.1709326528.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | sh: Fix missing prototypes | expand |
Hi Geert, On Fri, 2024-03-01 at 22:02 +0100, Geert Uytterhoeven wrote: > arch/sh/drivers/dma/dma-api.c:164:5: warning: no previous prototype for 'dmac_search_free_channel' [-Wmissing-prototypes] > > dmac_search_free_channel() never had a user in upstream, remove it. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > dma_extend(), get_dma_info_by_name(), register_chan_caps(), and > request_dma_bycap() are also unused, but don't trigger warnings > --- I assume the other functions didn't trigger a warning because their symbols were exported. Correct me if I'm wrong. Adrian > arch/sh/drivers/dma/dma-api.c | 27 --------------------------- > 1 file changed, 27 deletions(-) > > diff --git a/arch/sh/drivers/dma/dma-api.c b/arch/sh/drivers/dma/dma-api.c > index 89cd4a3b4ccafbe2..f49097fa634c36d4 100644 > --- a/arch/sh/drivers/dma/dma-api.c > +++ b/arch/sh/drivers/dma/dma-api.c > @@ -161,33 +161,6 @@ int request_dma_bycap(const char **dmac, const char **caps, const char *dev_id) > } > EXPORT_SYMBOL(request_dma_bycap); > > -int dmac_search_free_channel(const char *dev_id) > -{ > - struct dma_channel *channel = { 0 }; > - struct dma_info *info = get_dma_info(0); > - int i; > - > - for (i = 0; i < info->nr_channels; i++) { > - channel = &info->channels[i]; > - if (unlikely(!channel)) > - return -ENODEV; > - > - if (atomic_read(&channel->busy) == 0) > - break; > - } > - > - if (info->ops->request) { > - int result = info->ops->request(channel); > - if (result) > - return result; > - > - atomic_set(&channel->busy, 1); > - return channel->chan; > - } > - > - return -ENOSYS; > -} > - > int request_dma(unsigned int chan, const char *dev_id) > { > struct dma_channel *channel = { 0 };
Hi Adrian, On Wed, May 1, 2024 at 11:09 AM John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote: > On Fri, 2024-03-01 at 22:02 +0100, Geert Uytterhoeven wrote: > > arch/sh/drivers/dma/dma-api.c:164:5: warning: no previous prototype for 'dmac_search_free_channel' [-Wmissing-prototypes] > > > > dmac_search_free_channel() never had a user in upstream, remove it. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > dma_extend(), get_dma_info_by_name(), register_chan_caps(), and > > request_dma_bycap() are also unused, but don't trigger warnings > > --- > > I assume the other functions didn't trigger a warning because their symbols > were exported. Correct me if I'm wrong. No, because they have a forward declaration in arch/sh/include/asm/dma.h. Gr{oetje,eeting}s, Geert
diff --git a/arch/sh/drivers/dma/dma-api.c b/arch/sh/drivers/dma/dma-api.c index 89cd4a3b4ccafbe2..f49097fa634c36d4 100644 --- a/arch/sh/drivers/dma/dma-api.c +++ b/arch/sh/drivers/dma/dma-api.c @@ -161,33 +161,6 @@ int request_dma_bycap(const char **dmac, const char **caps, const char *dev_id) } EXPORT_SYMBOL(request_dma_bycap); -int dmac_search_free_channel(const char *dev_id) -{ - struct dma_channel *channel = { 0 }; - struct dma_info *info = get_dma_info(0); - int i; - - for (i = 0; i < info->nr_channels; i++) { - channel = &info->channels[i]; - if (unlikely(!channel)) - return -ENODEV; - - if (atomic_read(&channel->busy) == 0) - break; - } - - if (info->ops->request) { - int result = info->ops->request(channel); - if (result) - return result; - - atomic_set(&channel->busy, 1); - return channel->chan; - } - - return -ENOSYS; -} - int request_dma(unsigned int chan, const char *dev_id) { struct dma_channel *channel = { 0 };
arch/sh/drivers/dma/dma-api.c:164:5: warning: no previous prototype for 'dmac_search_free_channel' [-Wmissing-prototypes] dmac_search_free_channel() never had a user in upstream, remove it. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- dma_extend(), get_dma_info_by_name(), register_chan_caps(), and request_dma_bycap() are also unused, but don't trigger warnings --- arch/sh/drivers/dma/dma-api.c | 27 --------------------------- 1 file changed, 27 deletions(-)