diff mbox

[02/16,v5,RFC] arm64: renesas: Add new Renesas R-Car Gen3 SoC Kconfig

Message ID 87614reqrb.wl%kuninori.morimoto.gx@renesas.com (mailing list archive)
State RFC
Delegated to: Simon Horman
Headers show

Commit Message

Kuninori Morimoto Aug. 7, 2015, 3:15 a.m. UTC
From: Gaku Inami <gaku.inami.xw@bp.renesas.com>

Initial version of device tree for Renesas R-Car Gen3 SoC Kconfig

Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v4 -> v5

 - based on latest ARM branch (Kconfig.platforms)

 arch/arm64/Kconfig.platforms | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Geert Uytterhoeven Aug. 10, 2015, 8:54 a.m. UTC | #1
On Fri, Aug 7, 2015 at 5:15 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Gaku Inami <gaku.inami.xw@bp.renesas.com>
>
> Initial version of device tree for Renesas R-Car Gen3 SoC Kconfig
>
> Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v4 -> v5
>
>  - based on latest ARM branch (Kconfig.platforms)
>
>  arch/arm64/Kconfig.platforms | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index e2deb18..ee99121 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -55,11 +55,20 @@ config ARCH_ROCKCHIP
>           This enables support for the ARMv8 based Rockchip chipsets,
>           like the RK3368.
>
> +config ARCH_RCAR_GEN3
> +       bool "Renesas R-Car Gen3 SoC Platform"
> +       select ARCH_SHMOBILE
> +       help
> +         This enables support for Renesas SoC.
> +

Please insert ARCH_RCAR_GEN3 before ARCH_ROCKCHIP to keep
sort order. However...

>  config ARCH_SEATTLE
>         bool "AMD Seattle SoC Family"
>         help
>           This enables support for AMD Seattle SOC Family
>
> +config ARCH_SHMOBILE
> +       bool
> +

shouldn't we have ARCH_SHMOBILE first, and make ARCH_RCAR_GEN3
depend on it, cfr. what Tegra is doing (and everyone has been doing on 32-bit
arm)?

It's debatable though, and thus to be discussed with the arm-soc maintainers,
as Exynos is doing it the other way, too.

>  config ARCH_TEGRA
>         bool "NVIDIA Tegra SoC Family"
>         select ARCH_HAS_RESET_CONTROLLER

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kuninori Morimoto Aug. 20, 2015, 6:27 a.m. UTC | #2
Hi Geert

> > +config ARCH_RCAR_GEN3
> > +       bool "Renesas R-Car Gen3 SoC Platform"
> > +       select ARCH_SHMOBILE
> > +       help
> > +         This enables support for Renesas SoC.
> > +
> 
> Please insert ARCH_RCAR_GEN3 before ARCH_ROCKCHIP to keep
> sort order. However...

OK, thanks

> >  config ARCH_SEATTLE
> >         bool "AMD Seattle SoC Family"
> >         help
> >           This enables support for AMD Seattle SOC Family
> >
> > +config ARCH_SHMOBILE
> > +       bool
> > +
> 
> shouldn't we have ARCH_SHMOBILE first, and make ARCH_RCAR_GEN3
> depend on it, cfr. what Tegra is doing (and everyone has been doing on 32-bit
> arm)?

I'm not sure, but if we used alphabetical order, ARCH_SHMOBILE can be here
I will keep this in v6
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Aug. 20, 2015, 6:01 p.m. UTC | #3
On Thu, Aug 20, 2015 at 06:27:42AM +0000, Kuninori Morimoto wrote:
> 
> Hi Geert
> 
> > > +config ARCH_RCAR_GEN3
> > > +       bool "Renesas R-Car Gen3 SoC Platform"
> > > +       select ARCH_SHMOBILE
> > > +       help
> > > +         This enables support for Renesas SoC.
> > > +
> > 
> > Please insert ARCH_RCAR_GEN3 before ARCH_ROCKCHIP to keep
> > sort order. However...
> 
> OK, thanks
> 
> > >  config ARCH_SEATTLE
> > >         bool "AMD Seattle SoC Family"
> > >         help
> > >           This enables support for AMD Seattle SOC Family
> > >
> > > +config ARCH_SHMOBILE
> > > +       bool
> > > +
> > 
> > shouldn't we have ARCH_SHMOBILE first, and make ARCH_RCAR_GEN3
> > depend on it, cfr. what Tegra is doing (and everyone has been doing on 32-bit
> > arm)?
> 
> I'm not sure, but if we used alphabetical order, ARCH_SHMOBILE can be here
> I will keep this in v6

Geerts suggestion sounds reasonable to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kuninori Morimoto Aug. 21, 2015, 12:20 a.m. UTC | #4
Hi Simon, Geert

> > > shouldn't we have ARCH_SHMOBILE first, and make ARCH_RCAR_GEN3
> > > depend on it, cfr. what Tegra is doing (and everyone has been doing on 32-bit
> > > arm)?
> > 
> > I'm not sure, but if we used alphabetical order, ARCH_SHMOBILE can be here
> > I will keep this in v6
> 
> Geerts suggestion sounds reasonable to me.

Sorry, I was misunderstood about this.
If we keep alphabetical order for ARCH_SHMOBILE and ARCH_RCAR_GEN3,
and uses "depends on", the menuconfig will be

	[*] Renesas R-Car Gen3 SoC Platform
	[ ] xxx
	[ ] xxx
	[*] Renesas SoC Family
	[ ] xxx

but we want to have this ?

	[ ] xxx
	[*] Renesas SoC Family
	[*]   Renesas R-Car Gen3 SoC Platform
	[ ] xxx
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index e2deb18..ee99121 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -55,11 +55,20 @@  config ARCH_ROCKCHIP
 	  This enables support for the ARMv8 based Rockchip chipsets,
 	  like the RK3368.
 
+config ARCH_RCAR_GEN3
+	bool "Renesas R-Car Gen3 SoC Platform"
+	select ARCH_SHMOBILE
+	help
+	  This enables support for Renesas SoC.
+
 config ARCH_SEATTLE
 	bool "AMD Seattle SoC Family"
 	help
 	  This enables support for AMD Seattle SOC Family
 
+config ARCH_SHMOBILE
+	bool
+
 config ARCH_TEGRA
 	bool "NVIDIA Tegra SoC Family"
 	select ARCH_HAS_RESET_CONTROLLER