diff mbox

ARM: shmobile: armadillo800eva: fixup HDMI sound flags setting

Message ID 877g56wqye.wl%kuninori.morimoto.gx@renesas.com (mailing list archive)
State Accepted
Commit 730359857f5f0e1fac9881c63d389d73adb5f416
Headers show

Commit Message

Kuninori Morimoto May 28, 2014, 2:57 a.m. UTC 
c7a507eea1db1430476289f525f9c853d5d485e8
(ASoC: fsi: fixup SND_SOC_DAIFMT_CBx_CFx flags)
fixuped FSI driver's behavior
which didn't match to ALSA flags.

But, it didn't care about armadillo800eva HDMI sound flags.
This patch fixed it.

Reported-by: Bui Duc Phuc(Fukuda) <bd-phuc@jinso.co.jp>
Reported-by: Hiep Cao Minh <cm-hiep@jinso.co.jp>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
>> Simon

This patch is needed on latest linus/master tree

 arch/arm/mach-shmobile/board-armadillo800eva.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Horman May 28, 2014, 4:06 a.m. UTC | #1 
On Tue, May 27, 2014 at 07:57:16PM -0700, Kuninori Morimoto wrote:
> c7a507eea1db1430476289f525f9c853d5d485e8
> (ASoC: fsi: fixup SND_SOC_DAIFMT_CBx_CFx flags)
> fixuped FSI driver's behavior
> which didn't match to ALSA flags.
> 
> But, it didn't care about armadillo800eva HDMI sound flags.
> This patch fixed it.
> 
> Reported-by: Bui Duc Phuc(Fukuda) <bd-phuc@jinso.co.jp>
> Reported-by: Hiep Cao Minh <cm-hiep@jinso.co.jp>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> >> Simon
> 
> This patch is needed on latest linus/master tree

Thanks I have queued this up as a fix for v3.16.
Even though it is a fix I think it is too late for it to be included in v3.15.
Instead I will ask for it to be added to stable (LTSI) for v3.15.
And likewise for v3.14 where the problem first appeared (I think).

>  arch/arm/mach-shmobile/board-armadillo800eva.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
> index 92d24a4..deb3b38 100644
> --- a/arch/arm/mach-shmobile/board-armadillo800eva.c
> +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
> @@ -1051,7 +1051,7 @@ static struct asoc_simple_card_info fsi2_hdmi_info = {
>  	.platform	= "sh_fsi2",
>  	.cpu_dai = {
>  		.name	= "fsib-dai",
> -		.fmt	= SND_SOC_DAIFMT_CBM_CFM,
> +		.fmt	= SND_SOC_DAIFMT_CBS_CFS,
>  	},
>  	.codec_dai = {
>  		.name = "sh_mobile_hdmi-hifi",
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kuninori Morimoto May 28, 2014, 4:23 a.m. UTC | #2 
Hi Simon

> > c7a507eea1db1430476289f525f9c853d5d485e8
> > (ASoC: fsi: fixup SND_SOC_DAIFMT_CBx_CFx flags)
> > fixuped FSI driver's behavior
> > which didn't match to ALSA flags.
> > 
> > But, it didn't care about armadillo800eva HDMI sound flags.
> > This patch fixed it.
> > 
> > Reported-by: Bui Duc Phuc(Fukuda) <bd-phuc@jinso.co.jp>
> > Reported-by: Hiep Cao Minh <cm-hiep@jinso.co.jp>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > >> Simon
> > 
> > This patch is needed on latest linus/master tree
> 
> Thanks I have queued this up as a fix for v3.16.
> Even though it is a fix I think it is too late for it to be included in v3.15.
> Instead I will ask for it to be added to stable (LTSI) for v3.15.
> And likewise for v3.14 where the problem first appeared (I think).

Thank you

But, don't use this patch to v3.14.
v3.14 doesn't have this problem.
First appeared version is v3.15 (not released yet)

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman May 28, 2014, 4:41 a.m. UTC | #3 
On Tue, May 27, 2014 at 09:23:24PM -0700, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > c7a507eea1db1430476289f525f9c853d5d485e8
> > > (ASoC: fsi: fixup SND_SOC_DAIFMT_CBx_CFx flags)
> > > fixuped FSI driver's behavior
> > > which didn't match to ALSA flags.
> > > 
> > > But, it didn't care about armadillo800eva HDMI sound flags.
> > > This patch fixed it.
> > > 
> > > Reported-by: Bui Duc Phuc(Fukuda) <bd-phuc@jinso.co.jp>
> > > Reported-by: Hiep Cao Minh <cm-hiep@jinso.co.jp>
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> > > >> Simon
> > > 
> > > This patch is needed on latest linus/master tree
> > 
> > Thanks I have queued this up as a fix for v3.16.
> > Even though it is a fix I think it is too late for it to be included in v3.15.
> > Instead I will ask for it to be added to stable (LTSI) for v3.15.
> > And likewise for v3.14 where the problem first appeared (I think).
> 
> Thank you
> 
> But, don't use this patch to v3.14.
> v3.14 doesn't have this problem.
> First appeared version is v3.15 (not released yet)

Thanks, got it.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Geert Uytterhoeven May 28, 2014, 8:47 a.m. UTC | #4 
Hi Simon,

On Wed, May 28, 2014 at 6:06 AM, Simon Horman <horms@verge.net.au> wrote:
> Instead I will ask for it to be added to stable (LTSI) for v3.15.

According to lists.linuxfoundation.org/pipermail/ltsi-dev/2014-May/003196.html,
the next LTSI kernel will be v3.14?

Good choice, as \pi has an infinite number of digits ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
index 92d24a4..deb3b38 100644
--- a/arch/arm/mach-shmobile/board-armadillo800eva.c
+++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
@@ -1051,7 +1051,7 @@  static struct asoc_simple_card_info fsi2_hdmi_info = {
 	.platform	= "sh_fsi2",
 	.cpu_dai = {
 		.name	= "fsib-dai",
-		.fmt	= SND_SOC_DAIFMT_CBM_CFM,
+		.fmt	= SND_SOC_DAIFMT_CBS_CFS,
 	},
 	.codec_dai = {
 		.name = "sh_mobile_hdmi-hifi",