From patchwork Fri Aug 28 05:20:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 7089441 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E3338BEEC1 for ; Fri, 28 Aug 2015 05:24:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 13F1A207A8 for ; Fri, 28 Aug 2015 05:24:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 214A1207A2 for ; Fri, 28 Aug 2015 05:24:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751327AbbH1FYh (ORCPT ); Fri, 28 Aug 2015 01:24:37 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:62258 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751005AbbH1FYg (ORCPT ); Fri, 28 Aug 2015 01:24:36 -0400 Received: from unknown (HELO relmlir2.idc.renesas.com) ([10.200.68.152]) by relmlie3.idc.renesas.com with ESMTP; 28 Aug 2015 14:24:35 +0900 Received: from relmlac2.idc.renesas.com (relmlac2.idc.renesas.com [10.200.69.22]) by relmlir2.idc.renesas.com (Postfix) with ESMTP id 2C06E468B2; Fri, 28 Aug 2015 14:24:35 +0900 (JST) Received: by relmlac2.idc.renesas.com (Postfix, from userid 0) id 21CAA2806E; Fri, 28 Aug 2015 14:24:35 +0900 (JST) Received: from relmlac2.idc.renesas.com (localhost [127.0.0.1]) by relmlac2.idc.renesas.com (Postfix) with ESMTP id 1C59A2806D; Fri, 28 Aug 2015 14:24:35 +0900 (JST) Received: from relmlii2.idc.renesas.com [10.200.68.66] by relmlac2.idc.renesas.com with ESMTP id QAN23009; Fri, 28 Aug 2015 14:24:35 +0900 X-IronPort-AV: E=Sophos;i="5.17,424,1437404400"; d="scan'";a="194474845" Received: from mail-hk2apc01lp0211.outbound.protection.outlook.com (HELO APC01-HK2-obe.outbound.protection.outlook.com) ([65.55.88.211]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA; 28 Aug 2015 14:24:34 +0900 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.144) by HK2PR06MB0596.apcprd06.prod.outlook.com (10.161.187.147) with Microsoft SMTP Server (TLS) id 15.1.256.15; Fri, 28 Aug 2015 05:24:33 +0000 Date: Fri, 28 Aug 2015 14:20:41 +0900 Message-ID: <87h9nkc7km.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Linus Walleij , Laurent Pinchart CC: Simon , Magnus , "linux-gpio@vger.kernel.org" , "linux-sh@vger.kernel.org" Subject: [PATCH][RFC] sh-pfc: add new PINMUX_IPSR_MODS() macro User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: KAWPR01CA0038.jpnprd01.prod.outlook.com (25.165.48.148) To HK2PR06MB0596.apcprd06.prod.outlook.com (25.161.187.147) X-Microsoft-Exchange-Diagnostics: 1; HK2PR06MB0596; 2:+BTkChvQI7IFULL1eJN4gUcBTHbdUrk0k4vlLTM/01s4PxAvltXAXkEiM/77iWQF1srWehsjsUNbzLc1br1UBCu+4wLTkhkm5WRr4cLRkEaaTQ6VQ/gZio3DefTXz7gLNkXRE2Z0+BrE+GO+t19wrc/hOmih61Z+6x9gjvLCeUs=; 3:jhuETusJym967FgxICjzgnfOG8Nj9JNkKIwmjkJnytLcCrpI6+jcZ2ryE+qvq2Ly/dHnLtGvnhuHSp95Xlsj38p6u11hr0zlN+SvLhKw4zxuIn9IXmVvOu+H+68xB2TPpD6eTX80A2Nbrjz1c9ji3g==; 25:J/a/VUjtakFWVMwiZMWNtScKfZrlR5rlqGAbPa2/uAWbPQSqtupK5BHYHmYrWg/8AYclH9ioS3FsGEWHrpji5IQXfjm81GCMRpNFiZkq1SBhzVmhcK04l/c7ywSTcyVqwM2gKRYWn1/JQ+cEzFY7k8170gwrOk7LOgucQR+d49lshJOaKiPR2ervVdlBYX4oEJ9rAw+CsF+n2how3LjtufsGxtD0CcVBsi8DHNYWyRNbce9I4UyyWtB00wOM8hb8FJWsmalgMr//YlnrgN71kQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HK2PR06MB0596; X-Microsoft-Exchange-Diagnostics: 1; HK2PR06MB0596; 20:pe3uIb2fU4K9NUdAsxfoypGtxywePO11yak89mpVVj87W4VUHFMaPO7FW4g/XKBOD7mJk8OJq9KNGmQ+yEevXztKBOkjAXEe6C3SyeXQnwNmF+g9s2bGmPDM0P9EN8/T56BeZphoGe16k/KFYpAQ8YxZP2XW7ZK5eT5Oq+K7dctTHZpEziZG9rAeD9QlnRMeD3HI+lN1oP7BDIApmbWIbozjZMEmUQ0um4hvbr8AKfcvhjy9czqJB+M/nsNlr4RrtXZGkyTJgBo0RFwJqR9fg0HK8zJP250+iuyVOapOmKfXsxPCFHdwwMRkEr0wx1kYFB7FGNw9FPDKmgyQ3yaYuZUnssJ4Cl7a/IaisBdFoR/vE1AQVi4/Pc460H4UbUwXgZQfO0YI/y0YmjhBXdz7s4kOIksu+7x1c9OXOtY+PQgdhXBZcdiaSdyrpgdWQ1FvXV0o/sQg3h0ziZ1mosYiW8qY1DyPwSxjGUmiYH3xWstW+8h4w6PE9rMAVKKWun8S; 4:XtX1CBxPZySNPecouaollYh8TAsJKTwmPdi4/d+1byRxOicwZ3tUzkzMALVINq5e6o00LJa6nCzyR9LO7j5MeJk+WOCf4i31aWO77mWNVPc6FhIZKQ3VILCLZ2tiXKzWXWqdqFTgpYcdnjrF/dS5C1gPeTptmkVUqBUdzs+/x4cNurL6wW+JMUlXrgsg/D1CIVpnlGKpnjSj358JySImx2FQwdJdLcvD9NSsp8KCg3NKe21HbssifFv9rXhGCdr66NUdt7E0KwK+ygAs/Tq72VdNpW/pezBS3IYH7Rv7bjoRLGdb5D4Y5Cgv/wG81SgE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(8121501046)(5005006)(3002001); SRVR:HK2PR06MB0596; BCL:0; PCL:0; RULEID:; SRVR:HK2PR06MB0596; X-Forefront-PRVS: 0682FC00E8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(189002)(199003)(19580405001)(19580395003)(5001830100001)(86362001)(69596002)(77156002)(87976001)(62966003)(40100003)(5007970100001)(5001860100001)(83506001)(122386002)(5001770100001)(92566002)(5004730100002)(23726002)(189998001)(66066001)(47776003)(64706001)(97736004)(105586002)(53416004)(229853001)(50466002)(36756003)(106356001)(4001540100001)(5001920100001)(5001960100002)(33646002)(77096005)(54356999)(4001350100001)(68736005)(101416001)(46102003)(46406003)(42186005)(50986999)(81156007); DIR:OUT; SFP:1102; SCL:1; SRVR:HK2PR06MB0596; H:morimoto-PC.renesas.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HK2PR06MB0596; 23:OYkR/Ds122xTPVKKz6HiMsDb6+N5Pm8mKXt4b3Sim?= =?us-ascii?Q?vyMhGw5OuSWnaROet7q+B2srejhYh8DHta3lm0zaJUprNC9pr7AXMe3dp/gn?= =?us-ascii?Q?6qjpXKyfNsJntaQrm+tSwcGW2H+GEp86oaS4Chtpwp8UBTyomWxhn16698/r?= =?us-ascii?Q?cOU1zqSHciF15UKC86L1YfH9InErlB8c/U4J2uYMuQqQ3P4D/7Fv3yYWYZ8v?= =?us-ascii?Q?o9dRCrsYya7VT/vgf7vD4KqCAPDT/JmFTpga486CbD2z4JPPuu5iRac8yPQ9?= =?us-ascii?Q?k69A1RE5dpGxXkKK+GlTqxCp5lzrMLURUdoISvDJpuRKiWrcUWMaQRcsjby3?= =?us-ascii?Q?/4+j4VjsRlmwLKdcc17wZzSBATlDe10T0HwW01ydivo84tIpPZ2iOAbJS39q?= =?us-ascii?Q?Y+Hz15kd+kTd6Q/YuGfT/HtJCCjiuPkA9993lcfr1Q0x8Ii1kODV59lNDxgW?= =?us-ascii?Q?FR43p1OL7QujPafJsALzedS4tuehvYTF44o/f43QA2OC6qZzZcJnKYKTCIwz?= =?us-ascii?Q?Wp9q1LNVO48yCQq1hYLksjpLmvKnalx1vmx14kLKa922/3kVOwG5CbXDiCTY?= =?us-ascii?Q?KcEgz5X1Dpyj2h2xA9x4yyEaYUjmXuScxU+m98KpMf2oE8gZbdWBlGhcYFM/?= =?us-ascii?Q?yWjFQcP/U+4eCje/+F6UyQAxCDTFFdK+GK3wIe2HHIVaDMSBIokupl0b/5xf?= =?us-ascii?Q?NQI2jcF6R6btsAQOXV8gBUAs4ZDiMxx3m9o5tuVewAN1bzcMlgBufJjSXdbz?= =?us-ascii?Q?k41VZHklTD9MJw85sSSAf20iVpWXlO63OAsbPC+F3RMVYqZL7mp3okbhozCm?= =?us-ascii?Q?7+NfaRlPIL+p+8cAwrJQH+7tgEnWsHMdbWmT6du6LsczvwN0QZEskFikT26b?= =?us-ascii?Q?qp3tUz0nP8jMiqG7FVjXLxzHiavHKz9WpV3e9XBOGJ9YROv5IA43BqmzXMtp?= =?us-ascii?Q?MKHI4e/iYX7fVkSnv0Y160vO0dL+BUy7V8GRW6S8RxUKgVp7RL0RlKNB/ei+?= =?us-ascii?Q?7uok65d0pCtid/Y0oI7tcfEomGIhem2GmQ4wOrS66NBuYBaN/1CqgcUFEWiE?= =?us-ascii?Q?B+D97qEgjVjpbN3oW/rYL5VolJKYBLJsjZxh9cUEQl/wP3H+/ANb5aKu3XCo?= =?us-ascii?Q?J7XLOaFrnQItbqW+cq18RwJyVWnDEhTgvH4AmBprhBWOWNK4JgSF+y9eJ15Q?= =?us-ascii?Q?hlkMvZSJvgMI2m96kMfm3jpQAMBs3BBMemB0mKGVEzrdK6jz/AgiyZAlw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; HK2PR06MB0596; 5:anL5Jid9/+kmzIo8RUNNeCTKu3iJyifIP94Q/pDbSK9h72iFWJy8B5FeCpeqa2krk6mzE43zGn4jTyE/0+0Nm+HLz0wYH2Rf3uYrpGYAkZeVsoLHLJe105QE1kreBupT5yCMY1cNDd8MH0i/WXpkWw==; 24:Q71lPGUiCs3LngleEZDsvVy7WYwh4416iuFVGmCGcK8pL58hVxSV4Fow3sE+W5iOzY7CEN4VPYIF4uli+GwzYXRVbMi24KDCoU6OfmdWc1E=; 20:QjD3A2OavE4WVWvC5kO/P5+p2+JmB37BbSPT+6/7KLU2MPrVIN5xzwzGgZk/XDFmLBQ6h38b9e05k+nLl26fzBj7Vp4h4TTLY1w5TOwpegBGMT4OUH3HbU/+ZFg1K3TKnsw5dXvmdr31hbCuvbG29u2gddfdACxw13W97+exfZ0= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2015 05:24:33.0069 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR06MB0596 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto Actually, PINMUX_IPSR_MODS() macro is same as PINMUX_IPSR_MODSEL_DATA(). Current PFC driver is very difficult to read, because macro names are using different lenth. Especially PINMUX_IPSR_MODSEL_DATA() is well used macro PINMUX_IPSR_NOGP(ispr, ...) PINMUX_IPSR_DATA(ipsr, ...) PINMUX_IPSR_NOGM(ispr, ...) PINMUX_IPSR_NOFN(ipsr, ...) PINMUX_IPSR_MSEL(ipsr, ...) PINMUX_IPSR_MODSEL_DATA(ipsr, ...) These are readable PINMUX_IPSR_NOGP(ispr, ...) PINMUX_IPSR_DATA(ipsr, ...) PINMUX_IPSR_NOGM(ispr, ...) PINMUX_IPSR_NOFN(ipsr, ...) PINMUX_IPSR_MSEL(ipsr, ...) PINMUX_IPSR_MODS(ipsr, ...) We can replace all PINMUX_IPSR_MODSEL_DATA() to PINMUX_IPSR_MODS(), and remove PINMUX_IPSR_MODSEL_DATA() from header. Signed-off-by: Kuninori Morimoto --- > LinusW, Laurent As I mentioned above, if this patch was accepted, I can replace all PINMUX_IPSR_MODSEL_DATA() to PINMUX_IPSR_MODS(). But I didn't it since it is [RFC] now drivers/pinctrl/sh-pfc/sh_pfc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h index 0874cfe..40447d54 100644 --- a/drivers/pinctrl/sh-pfc/sh_pfc.h +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h @@ -173,6 +173,8 @@ struct sh_pfc_soc_info { PINMUX_DATA(fn##_MARK, FN_##ipsr, FN_##ms) #define PINMUX_IPSR_MSEL(ipsr, fn, ms) \ PINMUX_DATA(fn##_MARK, FN_##fn, FN_##ipsr, FN_##ms) +#define PINMUX_IPSR_MODS(ipsr, fn, ms) \ + PINMUX_DATA(fn##_MARK, FN_##ms, FN_##ipsr, FN_##fn) #define PINMUX_IPSR_MODSEL_DATA(ipsr, fn, ms) \ PINMUX_DATA(fn##_MARK, FN_##ms, FN_##ipsr, FN_##fn)