diff mbox

[3/3] ARM: shmobile: r8a7791: add R-Car sound support on DTSI

Message ID 87k38menyv.wl%kuninori.morimoto.gx@renesas.com (mailing list archive)
State Accepted
Commit 09abd1fd11f98d6abde9c23244234170e7e36c2f
Headers show

Commit Message

Kuninori Morimoto June 12, 2014, 4:44 a.m. UTC
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

This patch support PIO transfer only at this point

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm/boot/dts/r8a7791.dtsi |   56 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

Comments

Simon Horman June 13, 2014, 7:49 a.m. UTC | #1
On Wed, Jun 11, 2014 at 09:44:26PM -0700, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> This patch support PIO transfer only at this point

I have marked this patch as an RFC in patchwork.

As discussed privately I think we should wait until we
can enable audio with DMA as my understanding is that
audio with PIO is not particularly usable.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kuninori Morimoto June 16, 2014, 7:12 a.m. UTC | #2
Hi Simon

> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > This patch support PIO transfer only at this point
> 
> I have marked this patch as an RFC in patchwork.
> 
> As discussed privately I think we should wait until we
> can enable audio with DMA as my understanding is that
> audio with PIO is not particularly usable.

Thank you for your help.

But, this patch adds "SoC" side sound support,
not "board/platform" side.
If you want to use sound, then, both "SoC + board" are needed.

When I sent r8a7790 sound support, I sent both "SoC" + "board",
and, you ignored "board (= lager)" patch. This is OK for me.

This r8a7791 sound support patches, I sent "SoC" patch only,
I didn't sent "board" side.
So, koelsch board still cann't use sound :P
I guess you can apply [3/3] patch ?

r8a7790 has "SoC" sound support patch on devel branch
eed8d04e231ea32fa704e4afb5f304ec0e836c4f
(ARM: shmobile: r8a7790: add R-Car sound support on DTSI)

Sorry for un-understandable / confusable patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman June 17, 2014, 6:09 a.m. UTC | #3
On Mon, Jun 16, 2014 at 12:12:18AM -0700, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > 
> > > This patch support PIO transfer only at this point
> > 
> > I have marked this patch as an RFC in patchwork.
> > 
> > As discussed privately I think we should wait until we
> > can enable audio with DMA as my understanding is that
> > audio with PIO is not particularly usable.
> 
> Thank you for your help.
> 
> But, this patch adds "SoC" side sound support,
> not "board/platform" side.
> If you want to use sound, then, both "SoC + board" are needed.
> 
> When I sent r8a7790 sound support, I sent both "SoC" + "board",
> and, you ignored "board (= lager)" patch. This is OK for me.
> 
> This r8a7791 sound support patches, I sent "SoC" patch only,
> I didn't sent "board" side.
> So, koelsch board still cann't use sound :P
> I guess you can apply [3/3] patch ?
> 
> r8a7790 has "SoC" sound support patch on devel branch
> eed8d04e231ea32fa704e4afb5f304ec0e836c4f
> (ARM: shmobile: r8a7790: add R-Car sound support on DTSI)
> 
> Sorry for un-understandable / confusable patches.

Hi Morimoto-san,

sorry for my confusion.

I have re-marked this patch as "Under Review" in patchwork and
I intend to apply it once I have finished attending rebasing
the tree now that v3.16-rc1 has been released.

Please ping me if I have not queued up this patch by the
the end of this week.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kuninori Morimoto June 17, 2014, 10:10 a.m. UTC | #4
Hi Simon

> sorry for my confusion.
> 
> I have re-marked this patch as "Under Review" in patchwork and
> I intend to apply it once I have finished attending rebasing
> the tree now that v3.16-rc1 has been released.

Thank you for your help !

> Please ping me if I have not queued up this patch by the
> the end of this week.

will do
Thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman June 17, 2014, 12:22 p.m. UTC | #5
On Tue, Jun 17, 2014 at 03:10:44AM -0700, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > sorry for my confusion.
> > 
> > I have re-marked this patch as "Under Review" in patchwork and
> > I intend to apply it once I have finished attending rebasing
> > the tree now that v3.16-rc1 has been released.
> 
> Thank you for your help !
> 
> > Please ping me if I have not queued up this patch by the
> > the end of this week.
> 
> will do

I have queued it up.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index 380d058..bd91a44 100644
--- a/arch/arm/boot/dts/r8a7791.dtsi
+++ b/arch/arm/boot/dts/r8a7791.dtsi
@@ -950,4 +950,60 @@ 
 		#size-cells = <0>;
 		status = "disabled";
 	};
+
+	rcar_sound: rcar_sound@0xec500000 {
+		#sound-dai-cells = <1>;
+		compatible =  "renesas,rcar_sound-r8a7791", "renesas,rcar_sound-gen2", "renesas,rcar_sound";
+		interrupt-parent = <&gic>;
+		reg =	<0 0xec500000 0 0x1000>, /* SCU */
+			<0 0xec5a0000 0 0x100>,  /* ADG */
+			<0 0xec540000 0 0x1000>, /* SSIU */
+			<0 0xec541000 0 0x1280>; /* SSI */
+		clocks = <&mstp10_clks R8A7791_CLK_SSI_ALL>,
+			<&mstp10_clks R8A7791_CLK_SSI9>, <&mstp10_clks R8A7791_CLK_SSI8>,
+			<&mstp10_clks R8A7791_CLK_SSI7>, <&mstp10_clks R8A7791_CLK_SSI6>,
+			<&mstp10_clks R8A7791_CLK_SSI5>, <&mstp10_clks R8A7791_CLK_SSI4>,
+			<&mstp10_clks R8A7791_CLK_SSI3>, <&mstp10_clks R8A7791_CLK_SSI2>,
+			<&mstp10_clks R8A7791_CLK_SSI1>, <&mstp10_clks R8A7791_CLK_SSI0>,
+			<&mstp10_clks R8A7791_CLK_SCU_SRC9>, <&mstp10_clks R8A7791_CLK_SCU_SRC8>,
+			<&mstp10_clks R8A7791_CLK_SCU_SRC7>, <&mstp10_clks R8A7791_CLK_SCU_SRC6>,
+			<&mstp10_clks R8A7791_CLK_SCU_SRC5>, <&mstp10_clks R8A7791_CLK_SCU_SRC4>,
+			<&mstp10_clks R8A7791_CLK_SCU_SRC3>, <&mstp10_clks R8A7791_CLK_SCU_SRC2>,
+			<&mstp10_clks R8A7791_CLK_SCU_SRC1>, <&mstp10_clks R8A7791_CLK_SCU_SRC0>,
+			<&audio_clk_a>, <&audio_clk_b>, <&audio_clk_c>, <&m2_clk>;
+		clock-names = "ssi-all",
+				"ssi.9", "ssi.8", "ssi.7", "ssi.6", "ssi.5",
+				"ssi.4", "ssi.3", "ssi.2", "ssi.1", "ssi.0",
+				"src.9", "src.8", "src.7", "src.6", "src.5",
+				"src.4", "src.3", "src.2", "src.1", "src.0",
+				"clk_a", "clk_b", "clk_c", "clk_i";
+
+		status = "disabled";
+
+		rcar_sound,src {
+			src0: src@0 { };
+			src1: src@1 { };
+			src2: src@2 { };
+			src3: src@3 { };
+			src4: src@4 { };
+			src5: src@5 { };
+			src6: src@6 { };
+			src7: src@7 { };
+			src8: src@8 { };
+			src9: src@9 { };
+		};
+
+		rcar_sound,ssi {
+			ssi0: ssi@0 { interrupts = <0 370 IRQ_TYPE_LEVEL_HIGH>; };
+			ssi1: ssi@1 { interrupts = <0 371 IRQ_TYPE_LEVEL_HIGH>; };
+			ssi2: ssi@2 { interrupts = <0 372 IRQ_TYPE_LEVEL_HIGH>; };
+			ssi3: ssi@3 { interrupts = <0 373 IRQ_TYPE_LEVEL_HIGH>; };
+			ssi4: ssi@4 { interrupts = <0 374 IRQ_TYPE_LEVEL_HIGH>; };
+			ssi5: ssi@5 { interrupts = <0 375 IRQ_TYPE_LEVEL_HIGH>; };
+			ssi6: ssi@6 { interrupts = <0 376 IRQ_TYPE_LEVEL_HIGH>; };
+			ssi7: ssi@7 { interrupts = <0 377 IRQ_TYPE_LEVEL_HIGH>; };
+			ssi8: ssi@8 { interrupts = <0 378 IRQ_TYPE_LEVEL_HIGH>; };
+			ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
+		};
+	};
 };