| Message ID | 87vbk0n3q3.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Morimoto-san, Thank you for the patch. On Wednesday 21 January 2015 04:42:22 Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > The driver doesn't support residue reporting at all. > residue_granularity should be set to DMA_RESIDUE_GRANULARITY_DESCRIPTOR. > Special thanks to Laurent > > Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> I thought the plan was to fix this in v4 of "[PATCH v3] dmaengine:: rcar- hpbdma: add dma_dev->directions" ? > --- > drivers/dma/sh/rcar-hpbdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c > index 6fef1b9..749f26e 100644 > --- a/drivers/dma/sh/rcar-hpbdma.c > +++ b/drivers/dma/sh/rcar-hpbdma.c > @@ -600,7 +600,7 @@ static int hpb_dmae_probe(struct platform_device *pdev) > dma_dev->src_addr_widths = widths; > dma_dev->dst_addr_widths = widths; > dma_dev->directions = BIT(DMA_MEM_TO_DEV) | BIT(DMA_DEV_TO_MEM); > - dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST; > + dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR; > > hpbdev->shdma_dev.ops = &hpb_dmae_ops; > hpbdev->shdma_dev.desc_size = sizeof(struct hpb_desc);
Hi Laurent > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > > > The driver doesn't support residue reporting at all. > > residue_granularity should be set to DMA_RESIDUE_GRANULARITY_DESCRIPTOR. > > Special thanks to Laurent > > > > Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > I thought the plan was to fix this in v4 of "[PATCH v3] dmaengine:: rcar- > hpbdma: add dma_dev->directions" ? Yes, I had same plan, but, it seems that dma/next branch already had previous patch. so, I sent additional patch I'm happy to create v4 patch of course. => Vinod ? Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Morimoto-san, On Thursday 22 January 2015 00:24:05 Kuninori Morimoto wrote: > >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > >> > >> The driver doesn't support residue reporting at all. > >> residue_granularity should be set to DMA_RESIDUE_GRANULARITY_DESCRIPTOR. > >> Special thanks to Laurent > >> > >> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > > > I thought the plan was to fix this in v4 of "[PATCH v3] dmaengine:: rcar- > > hpbdma: add dma_dev->directions" ? > > Yes, I had same plan, but, it seems that dma/next branch already had > previous patch. so, I sent additional patch > > I'm happy to create v4 patch of course. > => Vinod ? Just for the record, if the base patch has already been merged, I'm totally fine with a separate patch.
Vi Vinod
I had sent rcar-hpbdma directions fixup patches before
Subject: [PATCH v3] dmaengine:: rcar-hpbdma: add dma_dev->directions
Date: Tue, 20 Jan 2015 01:22:48 +0000
After that, I got feedback from Laurent about residue_granularity.
But, then, I could find above patch on dma/next branch, so, I sent below
patch as additional patch.
Subject: [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity
Date: Wed, 21 Jan 2015 04:42:22 +0000
But, could you please replace it to 1) if possible ?
I found shdmac has same issue (= 2).
Kuninori Morimoto (2):
1) dmaengine: rcar-hpbdma: fixup WARNING of slave caps retrieval
2) dmaengine: shdmac: fixup WARNING of slave caps retrieval
drivers/dma/sh/rcar-hpbdma.c | 6 ++++++
drivers/dma/sh/shdmac.c | 9 +++++++++
2 files changed, 15 insertions(+)
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Morimoto-san, Thank you for the patches. For the whole series, Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> On Thursday 22 January 2015 02:31:42 Kuninori Morimoto wrote: > Vi Vinod > > I had sent rcar-hpbdma directions fixup patches before > > Subject: [PATCH v3] dmaengine:: rcar-hpbdma: add dma_dev->directions > Date: Tue, 20 Jan 2015 01:22:48 +0000 > > After that, I got feedback from Laurent about residue_granularity. > But, then, I could find above patch on dma/next branch, so, I sent below > patch as additional patch. > > Subject: [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity > Date: Wed, 21 Jan 2015 04:42:22 +0000 > > But, could you please replace it to 1) if possible ? > I found shdmac has same issue (= 2). > > Kuninori Morimoto (2): > 1) dmaengine: rcar-hpbdma: fixup WARNING of slave caps retrieval > 2) dmaengine: shdmac: fixup WARNING of slave caps retrieval > > drivers/dma/sh/rcar-hpbdma.c | 6 ++++++ > drivers/dma/sh/shdmac.c | 9 +++++++++ > 2 files changed, 15 insertions(+)
On Thu, Jan 22, 2015 at 02:31:42AM +0000, Kuninori Morimoto wrote: > > Vi Vinod > > I had sent rcar-hpbdma directions fixup patches before > > Subject: [PATCH v3] dmaengine:: rcar-hpbdma: add dma_dev->directions > Date: Tue, 20 Jan 2015 01:22:48 +0000 > > After that, I got feedback from Laurent about residue_granularity. > But, then, I could find above patch on dma/next branch, so, I sent below > patch as additional patch. > > Subject: [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity > Date: Wed, 21 Jan 2015 04:42:22 +0000 > > But, could you please replace it to 1) if possible ? > I found shdmac has same issue (= 2). I will just apply this patch, so should be okay..
On Wed, Jan 21, 2015 at 04:42:22AM +0000, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > The driver doesn't support residue reporting at all. > residue_granularity should be set to DMA_RESIDUE_GRANULARITY_DESCRIPTOR. > Special thanks to Laurent Applied, thanks
On Thu, Jan 22, 2015 at 02:31:42AM +0000, Kuninori Morimoto wrote: > > Vi Vinod > > I had sent rcar-hpbdma directions fixup patches before > > Subject: [PATCH v3] dmaengine:: rcar-hpbdma: add dma_dev->directions > Date: Tue, 20 Jan 2015 01:22:48 +0000 > > After that, I got feedback from Laurent about residue_granularity. > But, then, I could find above patch on dma/next branch, so, I sent below > patch as additional patch. > > Subject: [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity > Date: Wed, 21 Jan 2015 04:42:22 +0000 > > But, could you please replace it to 1) if possible ? > I found shdmac has same issue (= 2). > > Kuninori Morimoto (2): > 1) dmaengine: rcar-hpbdma: fixup WARNING of slave caps retrieval > 2) dmaengine: shdmac: fixup WARNING of slave caps retrieval I tried applying, got conflict on 1st one, applied second one, please rebase and resnd 1st. Thanks
diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c index 6fef1b9..749f26e 100644 --- a/drivers/dma/sh/rcar-hpbdma.c +++ b/drivers/dma/sh/rcar-hpbdma.c @@ -600,7 +600,7 @@ static int hpb_dmae_probe(struct platform_device *pdev) dma_dev->src_addr_widths = widths; dma_dev->dst_addr_widths = widths; dma_dev->directions = BIT(DMA_MEM_TO_DEV) | BIT(DMA_DEV_TO_MEM); - dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST; + dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR; hpbdev->shdma_dev.ops = &hpb_dmae_ops; hpbdev->shdma_dev.desc_size = sizeof(struct hpb_desc);