diff mbox

ARM: shmobile: bockw: use wp-gpios instead of WP pin

Message ID 87zjmc676u.wl%kuninori.morimoto.gx@gmail.com (mailing list archive)
State Accepted
Commit f729dd554e9a04a55950693ea8eca0d3aaa28d22
Headers show

Commit Message

Kuninori Morimoto Jan. 31, 2014, 5:39 a.m. UTC
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Latest Renesas Chip has some SDHI channels and the WP pin
availability depends on its channel or HW implementation.
Thus, this patch decides new policy whch indicates
WP is disabled as default.
But, we can use wp-gpios property to enable it as
other method.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
Simon

This was included on v1 patch series,
but no relationship with mmc part patches.

 arch/arm/boot/dts/r8a7778-bockw-reference.dts |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Simon Horman Feb. 3, 2014, 6:35 a.m. UTC | #1
On Thu, Jan 30, 2014 at 09:39:40PM -0800, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Latest Renesas Chip has some SDHI channels and the WP pin
> availability depends on its channel or HW implementation.
> Thus, this patch decides new policy whch indicates
> WP is disabled as default.
> But, we can use wp-gpios property to enable it as
> other method.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> Simon
> 
> This was included on v1 patch series,
> but no relationship with mmc part patches.

So I could take this patch into the renesas tree now?

> 
>  arch/arm/boot/dts/r8a7778-bockw-reference.dts |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7778-bockw-reference.dts b/arch/arm/boot/dts/r8a7778-bockw-reference.dts
> index bb62c7a..06cda19 100644
> --- a/arch/arm/boot/dts/r8a7778-bockw-reference.dts
> +++ b/arch/arm/boot/dts/r8a7778-bockw-reference.dts
> @@ -17,6 +17,7 @@
>  /dts-v1/;
>  #include "r8a7778.dtsi"
>  #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/gpio/gpio.h>
>  
>  / {
>  	model = "bockw";
> @@ -84,7 +85,7 @@
>  
>  	sdhi0_pins: sd0 {
>  		renesas,groups = "sdhi0_data4", "sdhi0_ctrl",
> -				  "sdhi0_cd", "sdhi0_wp";
> +				  "sdhi0_cd";
>  		renesas,function = "sdhi0";
>  	};
>  
> @@ -101,6 +102,7 @@
>  	vmmc-supply = <&fixedregulator3v3>;
>  	bus-width = <4>;
>  	status = "okay";
> +	wp-gpios = <&gpio3 18 GPIO_ACTIVE_HIGH>;
>  };
>  
>  &hspi0 {
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kuninori Morimoto Feb. 4, 2014, 1:32 a.m. UTC | #2
Hi Simon

> > Latest Renesas Chip has some SDHI channels and the WP pin
> > availability depends on its channel or HW implementation.
> > Thus, this patch decides new policy whch indicates
> > WP is disabled as default.
> > But, we can use wp-gpios property to enable it as
> > other method.
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > Simon
> > 
> > This was included on v1 patch series,
> > but no relationship with mmc part patches.
> 
> So I could take this patch into the renesas tree now?

Yes, I guess so

# my PC broken this morning somehow...

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Feb. 6, 2014, 6:59 a.m. UTC | #3
On Mon, Feb 03, 2014 at 05:32:08PM -0800, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > Latest Renesas Chip has some SDHI channels and the WP pin
> > > availability depends on its channel or HW implementation.
> > > Thus, this patch decides new policy whch indicates
> > > WP is disabled as default.
> > > But, we can use wp-gpios property to enable it as
> > > other method.
> > > 
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> > > Simon
> > > 
> > > This was included on v1 patch series,
> > > but no relationship with mmc part patches.
> > 
> > So I could take this patch into the renesas tree now?
> 
> Yes, I guess so

Thanks, I have queued this up.

> 
> # my PC broken this morning somehow...

Ouch
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a7778-bockw-reference.dts b/arch/arm/boot/dts/r8a7778-bockw-reference.dts
index bb62c7a..06cda19 100644
--- a/arch/arm/boot/dts/r8a7778-bockw-reference.dts
+++ b/arch/arm/boot/dts/r8a7778-bockw-reference.dts
@@ -17,6 +17,7 @@ 
 /dts-v1/;
 #include "r8a7778.dtsi"
 #include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "bockw";
@@ -84,7 +85,7 @@ 
 
 	sdhi0_pins: sd0 {
 		renesas,groups = "sdhi0_data4", "sdhi0_ctrl",
-				  "sdhi0_cd", "sdhi0_wp";
+				  "sdhi0_cd";
 		renesas,function = "sdhi0";
 	};
 
@@ -101,6 +102,7 @@ 
 	vmmc-supply = <&fixedregulator3v3>;
 	bus-width = <4>;
 	status = "okay";
+	wp-gpios = <&gpio3 18 GPIO_ACTIVE_HIGH>;
 };
 
 &hspi0 {