diff mbox

sh: simplify WARN usage in SH clock driver

Message ID Pine.LNX.4.64.1005041613210.4925@axis700.grange (mailing list archive)
State Accepted
Commit f5ca6d4cbd49dbb6e179a71fa610eb321a3e9951
Headers show

Commit Message

Guennadi Liakhovetski May 4, 2010, 2:15 p.m. UTC
None
diff mbox

Patch

diff --git a/drivers/sh/clk.c b/drivers/sh/clk.c
index f8c1740..b0cfb75 100644
--- a/drivers/sh/clk.c
+++ b/drivers/sh/clk.c
@@ -163,12 +163,9 @@  void propagate_rate(struct clk *tclk)
 
 static void __clk_disable(struct clk *clk)
 {
-	if (clk->usecount == 0) {
-		printk(KERN_ERR "Trying disable clock %s with 0 usecount\n",
-		       clk->name);
-		WARN_ON(1);
+	if (WARN(!clk->usecount, "Trying to disable clock %s with 0 usecount\n",
+		 clk->name))
 		return;
-	}
 
 	if (!(--clk->usecount)) {
 		if (likely(clk->ops && clk->ops->disable))