From patchwork Tue Jul 9 14:27:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 2825313 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 26658C0AB2 for ; Tue, 9 Jul 2013 14:27:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E939B2018B for ; Tue, 9 Jul 2013 14:27:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FF5A201B4 for ; Tue, 9 Jul 2013 14:27:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753538Ab3GIO13 (ORCPT ); Tue, 9 Jul 2013 10:27:29 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:55199 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753803Ab3GIO11 (ORCPT ); Tue, 9 Jul 2013 10:27:27 -0400 Received: from axis700.grange (dslb-084-061-104-235.pools.arcor-ip.net [84.61.104.235]) by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis) id 0M6c40-1U0RvV0gsO-00wVlk; Tue, 09 Jul 2013 16:27:25 +0200 Received: by axis700.grange (Postfix, from userid 1000) id B3DF240BB4; Tue, 9 Jul 2013 16:27:24 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by axis700.grange (Postfix) with ESMTP id AA82A40BB3; Tue, 9 Jul 2013 16:27:24 +0200 (CEST) Date: Tue, 9 Jul 2013 16:27:24 +0200 (CEST) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: linux-sh@vger.kernel.org cc: Laurent Pinchart , Magnus Damm , Linus Walleij Subject: [PATCH] pinctrl: sh-pfc: fix SDHI0 VccQ regulator on sh73a0 with DT Message-ID: MIME-Version: 1.0 X-Provags-ID: V02:K0:qdJNERw8DzSsz3fJ0BBNuUg/dQmPwkP5oPoyve9X60m kOwROUtaEzed7pXGWxs5tMyx9pc/Sn1YlbQtF/Wbc56VTnMo+C U+maPLe7zPSuiWdIRZTsnJ/w16243+UiZUIdMTN5BLUyEgRRji YSGfUnABmlp7YHxHGL41J3Sk0VgJ5l1XBvhdHo8hLUDe3ra6tS YVY404Qk+DD3K6RLi3AEGmCM3fHEoivlmAKkPrSKN8gJxYCw75 efFYWhiFyAvmek6tO4zDsKbLTO74PtYzEy3vt5v/NSWf4B0NBZ wRTJAYWoVimYg0LoKM/tBvczX9rnYtFwEGo2QGJjrAlW0I5S/o vAXS3gFHZgbaX5+NY4dsRSFiyRp33NX1WbyplcK/VxALxBYXBK 8KC948CdiQubQ== Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The PFC pinctrl driver on sh73a0 is also regiatering a VccQ regulator for SDHI0. However, its consumers list only included the platform-data based SDHI device name. When booted with DT SDHI0 couldn't enable VccQ and therefore was unusable. Fix this by adding a consumer with DT-based name. Signed-off-by: Guennadi Liakhovetski Acked-by: Simon Horman Acked-by: Laurent Pinchart --- Is this the correct fix or is there a better option? Observed and tested on kzm9g-reference. drivers/pinctrl/sh-pfc/pfc-sh73a0.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c index 7956df5..31f7d0e 100644 --- a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c +++ b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c @@ -3785,6 +3785,7 @@ static const struct regulator_desc sh73a0_vccq_mc0_desc = { static struct regulator_consumer_supply sh73a0_vccq_mc0_consumers[] = { REGULATOR_SUPPLY("vqmmc", "sh_mobile_sdhi.0"), + REGULATOR_SUPPLY("vqmmc", "ee100000.sdhi"), }; static const struct regulator_init_data sh73a0_vccq_mc0_init_data = {