diff mbox

ARM: shmobile: armadillo800eva-reference: fix compiler warning

Message ID Pine.LNX.4.64.1307191758510.26183@axis700.grange (mailing list archive)
State Superseded
Commit ab40900b70dc31a64f23b1b4dbb0917afb039775
Headers show

Commit Message

Guennadi Liakhovetski July 19, 2013, 4:02 p.m. UTC
Fix the compiler warning:

arch/arm/mach-shmobile/board-armadillo800eva-reference.c:196:2: warning: initialization from incompatible pointer type [enabled by default]
arch/arm/mach-shmobile/board-armadillo800eva-reference.c:196:2: warning: (near initialization for '__mach_desc_ARMADILLO800EVA_DT.restart') [enabled by default]

While at it also remove superfluous parenthesis.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
---

renesas.git devel branch

 .../board-armadillo800eva-reference.c              |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Horman July 24, 2013, 8:06 a.m. UTC | #1
On Fri, Jul 19, 2013 at 06:02:16PM +0200, Guennadi Liakhovetski wrote:
> Fix the compiler warning:
> 
> arch/arm/mach-shmobile/board-armadillo800eva-reference.c:196:2: warning: initialization from incompatible pointer type [enabled by default]
> arch/arm/mach-shmobile/board-armadillo800eva-reference.c:196:2: warning: (near initialization for '__mach_desc_ARMADILLO800EVA_DT.restart') [enabled by default]
> 
> While at it also remove superfluous parenthesis.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>

Thanks, I have queued this up for v3.12 in the fixes2-for-v3.12 branch.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-shmobile/board-armadillo800eva-reference.c b/arch/arm/mach-shmobile/board-armadillo800eva-reference.c
index 002d8d3..fd2446d 100644
--- a/arch/arm/mach-shmobile/board-armadillo800eva-reference.c
+++ b/arch/arm/mach-shmobile/board-armadillo800eva-reference.c
@@ -174,10 +174,10 @@  static void __init eva_init(void)
 }
 
 #define RESCNT2 IOMEM(0xe6188020)
-static void eva_restart(char mode, const char *cmd)
+static void eva_restart(enum reboot_mode mode, const char *cmd)
 {
 	/* Do soft power on reset */
-	writel((1 << 31), RESCNT2);
+	writel(1 << 31, RESCNT2);
 }
 
 static const char *eva_boards_compat_dt[] __initdata = {