From patchwork Thu Oct 31 19:42:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 3121881 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9B82B9F466 for ; Thu, 31 Oct 2013 19:37:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9EB3320375 for ; Thu, 31 Oct 2013 19:43:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8B7020348 for ; Thu, 31 Oct 2013 19:43:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753463Ab3JaTnB (ORCPT ); Thu, 31 Oct 2013 15:43:01 -0400 Received: from jacques.telenet-ops.be ([195.130.132.50]:40621 "EHLO jacques.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752769Ab3JaTnA convert rfc822-to-8bit (ORCPT ); Thu, 31 Oct 2013 15:43:00 -0400 Received: from ayla.of.borg ([84.193.72.141]) by jacques.telenet-ops.be with bizsmtp id jvis1m00e32ts5g0JvisWj; Thu, 31 Oct 2013 20:42:57 +0100 Received: from geert (helo=localhost) by ayla.of.borg with local-esmtp (Exim 4.76) (envelope-from ) id 1Vby8q-0003XW-5j; Thu, 31 Oct 2013 20:42:52 +0100 Date: Thu, 31 Oct 2013 20:42:52 +0100 (CET) From: Geert Uytterhoeven To: Laurent Pinchart cc: linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org Subject: Re: [PATCH v2 19/19] fbdev: sh-mobile-lcdcfb: Enable the driver on all ARM platforms In-Reply-To: <1383086274-11049-20-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Message-ID: References: <1383086274-11049-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1383086274-11049-20-git-send-email-laurent.pinchart+renesas@ideasonboard.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Laurent, On Tue, 29 Oct 2013, Laurent Pinchart wrote: > Renesas ARM platforms are transitioning from single-platform to > multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the > driver available on all ARM platforms to enable it on both ARCH_SHMOBILE > and ARCH_SHMOBILE_MULTI, and increase build testing coverage with > COMPILE_TEST. > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 84b685f..32b5c86 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -2482,7 +2482,7 @@ endif > > config FB_SH_MOBILE_MERAM > tristate "SuperH Mobile MERAM read ahead support" > - depends on (SUPERH || ARCH_SHMOBILE) > + depends on (SUPERH || ARM || COMPILE_TEST) > select GENERIC_ALLOCATOR > ---help--- > Enable MERAM support for the SuperH controller. While the below compiler warnings have been seen with sh-randconfig before, they're more likely to happen with COMPILE_TEST=y. I now see them with e.g. m68k-allmodconfig, so I created a patch. From 15eb69172457c675cde177a6f742b6f1dabdeb18 Mon Sep 17 00:00:00 2001 From: Geert Uytterhoeven Date: Thu, 31 Oct 2013 20:35:14 +0100 Subject: [PATCH] fbdev: sh_mobile_meram: Fix defined but not used compiler warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If CONFIG_PM_SLEEP resp. CONFIG_PM_RUNTIME are not set: drivers/video/sh_mobile_meram.c:573: warning: ‘sh_mobile_meram_suspend’ defined but not used drivers/video/sh_mobile_meram.c:597: warning: ‘sh_mobile_meram_resume’ defined but not used Signed-off-by: Geert Uytterhoeven --- drivers/video/sh_mobile_meram.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/video/sh_mobile_meram.c b/drivers/video/sh_mobile_meram.c index e0f098562a74..56a8e47ffceb 100644 --- a/drivers/video/sh_mobile_meram.c +++ b/drivers/video/sh_mobile_meram.c @@ -569,6 +569,7 @@ EXPORT_SYMBOL_GPL(sh_mobile_meram_cache_update); * Power management */ +#ifdef CONFIG_PM_SLEEP static int sh_mobile_meram_suspend(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); @@ -592,7 +593,9 @@ static int sh_mobile_meram_suspend(struct device *dev) } return 0; } +#endif +#ifdef CONFIG_PM_RUNTIME static int sh_mobile_meram_resume(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); @@ -611,6 +614,7 @@ static int sh_mobile_meram_resume(struct device *dev) meram_write_reg(priv->base, common_regs[i], priv->regs[i]); return 0; } +#endif static UNIVERSAL_DEV_PM_OPS(sh_mobile_meram_dev_pm_ops, sh_mobile_meram_suspend,