diff mbox series

[afzal.mohd.ma@gmail.com:,[PATCH,v3] ARM: cns3xxx: replace setup_irq() by request_irq()]

Message ID 20200327110218.GC8207@afzalpc (mailing list archive)
State Superseded
Headers show
Series [afzal.mohd.ma@gmail.com:,[PATCH,v3] ARM: cns3xxx: replace setup_irq() by request_irq()] | expand

Commit Message

afzal mohammed March 27, 2020, 11:02 a.m. UTC
----- Forwarded message from afzal mohammed <afzal.mohd.ma@gmail.com> -----

Date: Sun,  1 Mar 2020 17:51:55 +0530
From: afzal mohammed <afzal.mohd.ma@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>, Krzysztof Halasa <khalasa@piap.pl>, Russell King <linux@armlinux.org.uk>, linux-arm-kernel@lists.infradead.org,
Cc: afzal mohammed <afzal.mohd.ma@gmail.com>
Subject: [PATCH v3] ARM: cns3xxx: replace setup_irq() by request_irq()
X-Mailer: git-send-email 2.18.0

request_irq() is preferred over setup_irq(). Invocations of setup_irq()
occur after memory allocators are ready.

Per tglx[1], setup_irq() existed in olden days when allocators were not
ready by the time early interrupts were initialized.

Hence replace setup_irq() by request_irq().

[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos

Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
Hi sub-arch maintainers,

If the patch is okay, please take it thr' your tree.


 * Split out from series, also split out from ARM patch to subarch level
	as Thomas suggested to take it thr' respective maintainers
 * Modify string displayed in case of error as suggested by Thomas
 * Re-arrange code as required to improve readability
 * Remove irrelevant parts from commit message & improve
 * Replace pr_err("request_irq() on %s failed" by
           pr_err("%s: request_irq() failed"
 * Commit message massage

 arch/arm/mach-cns3xxx/core.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
diff mbox series


diff --git a/arch/arm/mach-cns3xxx/core.c b/arch/arm/mach-cns3xxx/core.c
index 1d61a7701c11..e4f4b20b83a2 100644
--- a/arch/arm/mach-cns3xxx/core.c
+++ b/arch/arm/mach-cns3xxx/core.c
@@ -189,12 +189,6 @@  static irqreturn_t cns3xxx_timer_interrupt(int irq, void *dev_id)
 	return IRQ_HANDLED;
-static struct irqaction cns3xxx_timer_irq = {
-	.name		= "timer",
-	.handler	= cns3xxx_timer_interrupt,
  * Set up the clock source and clock events devices
@@ -245,7 +239,9 @@  static void __init __cns3xxx_timer_init(unsigned int timer_irq)
 	writel(val, cns3xxx_tmr1 + TIMER1_2_CONTROL_OFFSET);
 	/* Make irqs happen for the system timer */
-	setup_irq(timer_irq, &cns3xxx_timer_irq);
+	if (request_irq(timer_irq, cns3xxx_timer_interrupt,
+		pr_err("Failed to request irq %d (timer)\n", timer_irq);