| Message ID | 20200723073744.13400-21-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | memory: Cleanup, improve and compile test memory drivers | expand |
On Thu, Jul 23, 2020 at 9:39 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > @@ -1756,7 +1756,7 @@ static int gpmc_calc_common_timings(struct gpmc_timings *gpmc_t, > /* TODO: remove this function once all peripherals are confirmed to > * work with generic timing. Simultaneously gpmc_cs_set_timings() > * has to be modified to handle timings in ps instead of ns > -*/ > + */ This still doesn't follow the normal coding style for multi-line comments. I don't think it's worth fixing, but if you think it should be changed, then make it /* * mult-line comment * ... */ Arnd
On Thu, Jul 23, 2020 at 11:11:08AM +0200, Arnd Bergmann wrote: > On Thu, Jul 23, 2020 at 9:39 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > @@ -1756,7 +1756,7 @@ static int gpmc_calc_common_timings(struct gpmc_timings *gpmc_t, > > /* TODO: remove this function once all peripherals are confirmed to > > * work with generic timing. Simultaneously gpmc_cs_set_timings() > > * has to be modified to handle timings in ps instead of ns > > -*/ > > + */ > > This still doesn't follow the normal coding style for multi-line comments. > > I don't think it's worth fixing, but if you think it should be changed, then > make it > > /* > * mult-line comment > * ... > */ Sure, thanks for feedback. Best regards, Krzysztof
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index bb85aa56d247..dc10f55a3162 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -958,7 +958,7 @@ static int gpmc_cs_remap(int cs, u32 base) * Make sure we ignore any device offsets from the GPMC partition * allocated for the chip select and that the new base confirms * to the GPMC 16MB minimum granularity. - */ + */ base &= ~(SZ_16M - 1); gpmc_cs_get_memconf(cs, &old_base, &size); @@ -1756,7 +1756,7 @@ static int gpmc_calc_common_timings(struct gpmc_timings *gpmc_t, /* TODO: remove this function once all peripherals are confirmed to * work with generic timing. Simultaneously gpmc_cs_set_timings() * has to be modified to handle timings in ps instead of ns -*/ + */ static void gpmc_convert_ps_to_ns(struct gpmc_timings *t) { t->cs_on /= 1000;
Fix minor whitespace issues. No functional changes. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/memory/omap-gpmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)