diff mbox series

[1/2] arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller

Message ID 20200917165040.22908-1-krzk@kernel.org (mailing list archive)
State Accepted
Commit 5e7365fd7fd3eb1761684ec5446b4bda43ff9083
Headers show
Series [1/2] arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller | expand

Commit Message

Krzysztof Kozlowski Sept. 17, 2020, 4:50 p.m. UTC
The Synopsys DesignWare APB GPIO controller driver does not parse
reg-io-width and dtschema does not allow it so drop it to fix dtschema
warnings like:

  arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:
    'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. New patch
---
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 -
 arch/arm64/boot/dts/apm/apm-storm.dtsi     | 1 -
 2 files changed, 2 deletions(-)

Comments

Krzysztof Kozlowski Oct. 2, 2020, 4:09 p.m. UTC | #1
On Thu, Sep 17, 2020 at 06:50:39PM +0200, Krzysztof Kozlowski wrote:
> The Synopsys DesignWare APB GPIO controller driver does not parse
> reg-io-width and dtschema does not allow it so drop it to fix dtschema
> warnings like:
> 
>   arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:
>     'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> ---

Dear Arnd and Olof,

There is no response from APM maintainer, so maybe you could apply these
two patches directly? Optionally I could take it and send to you via
pull-request.

Best regards,
Krzysztof


> 
> Changes since v1:
> 1. New patch
> ---
>  arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 -
>  arch/arm64/boot/dts/apm/apm-storm.dtsi     | 1 -
>  2 files changed, 2 deletions(-)
>
Olof Johansson Oct. 3, 2020, 7:31 p.m. UTC | #2
On Fri, Oct 02, 2020 at 06:09:22PM +0200, Krzysztof Kozlowski wrote:
> On Thu, Sep 17, 2020 at 06:50:39PM +0200, Krzysztof Kozlowski wrote:
> > The Synopsys DesignWare APB GPIO controller driver does not parse
> > reg-io-width and dtschema does not allow it so drop it to fix dtschema
> > warnings like:
> > 
> >   arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:
> >     'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > 
> > ---
> 
> Dear Arnd and Olof,
> 
> There is no response from APM maintainer, so maybe you could apply these
> two patches directly? Optionally I could take it and send to you via
> pull-request.

Sure, applying.


-Olof
Olof Johansson Oct. 3, 2020, 7:33 p.m. UTC | #3
On Fri, Oct 02, 2020 at 06:09:22PM +0200, Krzysztof Kozlowski wrote:
> On Thu, Sep 17, 2020 at 06:50:39PM +0200, Krzysztof Kozlowski wrote:
> > The Synopsys DesignWare APB GPIO controller driver does not parse
> > reg-io-width and dtschema does not allow it so drop it to fix dtschema
> > warnings like:
> > 
> >   arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:
> >     'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > 
> > ---
> 
> Dear Arnd and Olof,
> 
> There is no response from APM maintainer, so maybe you could apply these
> two patches directly? Optionally I could take it and send to you via
> pull-request.

I've already applied them, so no need. Thanks for following up though, seems
like the patchwork email service hasn't been working on all patches.


-Olof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
index 3feb1881bbc2..2da5b8a0cd35 100644
--- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
@@ -709,7 +709,6 @@ 
 		dwgpio: gpio@1c024000 {
 			compatible = "snps,dw-apb-gpio";
 			reg = <0x0 0x1c024000 0x0 0x1000>;
-			reg-io-width = <4>;
 			#address-cells = <1>;
 			#size-cells = <0>;
 
diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
index 8c802d87e751..560b2a6f2082 100644
--- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
@@ -825,7 +825,6 @@ 
 		dwgpio: gpio@1c024000 {
 			compatible = "snps,dw-apb-gpio";
 			reg = <0x0 0x1c024000 0x0 0x1000>;
-			reg-io-width = <4>;
 			#address-cells = <1>;
 			#size-cells = <0>;