| Message ID | 20220601090548.47616-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7c7ff68daa93d8c4cdea482da4f2429c0398fcde |
| Headers | show |
| Series | [RESEND] ARM: Fix refcount leak in axxia_boot_secondary | expand |
Hello: This patch was applied to soc/soc.git (arm/fixes) by Arnd Bergmann <arnd@arndb.de>: On Wed, 1 Jun 2022 13:05:48 +0400 you wrote: > of_find_compatible_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when done. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 1d22924e1c4e ("ARM: Add platform support for LSI AXM55xx SoC") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > > [...] Here is the summary with links: - [RESEND] ARM: Fix refcount leak in axxia_boot_secondary https://git.kernel.org/soc/soc/c/7c7ff68daa93 You are awesome, thank you!
diff --git a/arch/arm/mach-axxia/platsmp.c b/arch/arm/mach-axxia/platsmp.c index 512943eae30a..2e203626eda5 100644 --- a/arch/arm/mach-axxia/platsmp.c +++ b/arch/arm/mach-axxia/platsmp.c @@ -39,6 +39,7 @@ static int axxia_boot_secondary(unsigned int cpu, struct task_struct *idle) return -ENOENT; syscon = of_iomap(syscon_np, 0); + of_node_put(syscon_np); if (!syscon) return -ENOMEM;
of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 1d22924e1c4e ("ARM: Add platform support for LSI AXM55xx SoC") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- I follow the instruction to resend this patch to soc@kernel.org. v1 link: https://lore.kernel.org/all/20220512020641.45156-1-linmq006@gmail.com/ --- arch/arm/mach-axxia/platsmp.c | 1 + 1 file changed, 1 insertion(+)