| Message ID | 20230516153109.514251-8-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 94c1c0a29bfccf94c70afef5d89734bce778add6 |
| Headers | show |
| Series | ARM: SoC: address -Wmissing-prototype warnings | expand |
On Tue, May 16, 2023 at 05:31:03PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The omap_serial_wakeup_init() declaration is not visible where it is > defined, so make sure "common.h" is included here, avoiding: > > arch/arm/mach-omap1/serial.c:221:12: error: no previous prototype for 'omap_serial_wakeup_init' [-Werror=missing-prototypes] > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi> A. > --- > arch/arm/mach-omap1/serial.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-omap1/serial.c b/arch/arm/mach-omap1/serial.c > index 96f59110d649..f25b94c86aec 100644 > --- a/arch/arm/mach-omap1/serial.c > +++ b/arch/arm/mach-omap1/serial.c > @@ -19,6 +19,7 @@ > > #include <asm/mach-types.h> > > +#include "common.h" > #include "serial.h" > #include "mux.h" > #include "pm.h" > -- > 2.39.2 >
* Aaro Koskinen <aaro.koskinen@iki.fi> [230516 23:18]: > On Tue, May 16, 2023 at 05:31:03PM +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > > > The omap_serial_wakeup_init() declaration is not visible where it is > > defined, so make sure "common.h" is included here, avoiding: > > > > arch/arm/mach-omap1/serial.c:221:12: error: no previous prototype for 'omap_serial_wakeup_init' [-Werror=missing-prototypes] > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi> Acked-by: Tony Lindgren <tony@atomide.com>
* Aaro Koskinen <aaro.koskinen@iki.fi> [230516 23:18]: > On Tue, May 16, 2023 at 05:31:03PM +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > > > The omap_serial_wakeup_init() declaration is not visible where it is > > defined, so make sure "common.h" is included here, avoiding: > > > > arch/arm/mach-omap1/serial.c:221:12: error: no previous prototype for 'omap_serial_wakeup_init' [-Werror=missing-prototypes] > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi> Acked-by: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/mach-omap1/serial.c b/arch/arm/mach-omap1/serial.c index 96f59110d649..f25b94c86aec 100644 --- a/arch/arm/mach-omap1/serial.c +++ b/arch/arm/mach-omap1/serial.c @@ -19,6 +19,7 @@ #include <asm/mach-types.h> +#include "common.h" #include "serial.h" #include "mux.h" #include "pm.h"