From patchwork Sat May 4 13:20:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13653976 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1C73C4345F for ; Sat, 4 May 2024 13:17:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id D4434C4AF18; Sat, 4 May 2024 13:17:07 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2081.outbound.protection.outlook.com [40.107.22.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 996EAC072AA; Sat, 4 May 2024 13:17:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 996EAC072AA Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UlggmPZvqE79ZaeW1gTAbA+cs1kIqi2SIyvOM1HB4159JF/+JtCxmfQiW0ivqdXP5CXkKje/nyrmWH/Yrn/GJo/ayUbcZ+X7nWP9o82PvscO9WYRE33rPFwr6REMQXZZgRmeuzGld47CW5hNOyINSpkGwwt41YY4W+dJkF2OBzO9Jru7wS7dw8RyU47sOrtdJeQefKEOH5Rf01ZmrXjRMuEfr+0BICN4NYt1LACPnQEuj41Jh4qqSfByzmuZ1dMuc1l7qwVm73K3m2oHRU+DAEs8Gi2JKGyam4WkrpLUqSqCD0bxtus6agOBE0cWUaxvdjW+UkG+HtJXUKZx3q8OyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OzFmWqqgAaHNbNJ4y5r21eHdO5OywXD/utfmPqrXP8Q=; b=TgVpot3hegYYv3qbkWnLZxHoF9Lz7u+bMV5C77TdeGnx3Ry6fBW9wp98fjl8BNVSkpfnxfSzk3ETv8W9t2zD/MuPKI01Ilsgqe23L7MPimZ4SNdsBCI/2UAeCuxN6ej1okwS8bXnqP1nsWbmIvxD1AAwBe9FFp/+vFE1GVbmZ7o0jAf+PHqp2by/jQp92NhEoS4xiFsH3W3i6UgEzOCXNB7Bx+Ti9HYrCmDvb++GAKFHiKLqPkGZY6rNJHrWf3p2+OGupUqsfQOQjc1jZs8Th7uhdyRGqBvFpKqcjOU4ReHTJRv2IQUjfDIG5+xEw4EY3//hA5atG4ZS1cixltpUMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OzFmWqqgAaHNbNJ4y5r21eHdO5OywXD/utfmPqrXP8Q=; b=Hujfgk6pBbJGD9Gn7U6zkbL3oeUYDzP9UMdHGvZL/K+xEh+dg1xpaQYo1lBHM8dRZTsMDLDcMg7aDlpeBuyBnsTkrCN9AI7lSKXvaG3RIin2lRLyV/vsqE6L59CW7E1hXxjdoMrKgn3ksp4JBgAQIzBAi4SZ3isnWO3ZQqIciJU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:17:04 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:17:03 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:15 +0800 Subject: [PATCH v2 17/20] pinctrl: pinconf-generic: Use scope based of_node_put() cleanups Message-Id: <20240504-pinctrl-cleanup-v2-17-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> List-Id: To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=1107; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=2wM6S75hkeICu8KMVBGWw7nINzfNCEUbOtGveeJZglQ=; b=W5Ezlhd9RfExH8zWzuKwrmVUyRSF1AbQsCIMFKOLEKa6ZeJmr07/EaJgdP6wSTycJk1QVaR5H zbLbDF4FDjFBbtd58shfrCerWTDLaxNYTJIpazadXEO2mmS4+ShJxp+ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c1176af-102a-4e3f-0f53-08dc6c3c7d6a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?q?DdikzDKEmMOr8kCCk+DIhoh4V3Om6JX?= =?utf-8?q?8zvr293WBwCkO5zN3r1R1nguEHpcU2FgRZ69PDpIGhXBU2oQptG+/4fe0P2QEoz25?= =?utf-8?q?JdUjAge0UwjtY776v6TVQJjgPtNspY9TCg5hoGCtPG2EBnVrrUNJk/F2tJaJ5POg4?= =?utf-8?q?7E4BlApYa8eMQhNBCIoEUQFRNZ4qTrCq+QUlceyDW0A0xMg77eOivMWnc4we6mr1y?= =?utf-8?q?JVkAmB1kizxHGhRwIPIsnkGQy34seQQqeV5NxMaPtS0a1FC4DZ2OwET2TgRQQ/tp7?= =?utf-8?q?hUCSJs8h3laOAE9X+P2PDwG4ID2lIn7IUdWxxm077RGfCBaG5ksHtSwh+iS3c3Hfc?= =?utf-8?q?yH/M2qo48iCe1n0D3JhzhZKP2Vaf/9ANjbdApmccJml8p0X1EnnY3JZ1roMvJjfBA?= =?utf-8?q?vLlka/wEIJZbQXv/j3746zE8emyA0x/Epaxu2duXY9OREocLYvC9IayvP4FgaGgtf?= =?utf-8?q?Pr8rK4etodsOID1eClHO5dPvzTR0ga/FEg+5uDH+1wQWQQI8YnE48jOXZPm7p4ULd?= =?utf-8?q?PP7ynEEGOLFHWpNAuI992fgnUeZ0ApeELUQ2IG27wXzOoXiWlydQ6thhh5iGDj7WG?= =?utf-8?q?6PbEmQtUTOtxbXV8I86NZr1oKMKOodKXqplhNx9nEWMv8+AsgACuDgyFLv3x28E9f?= =?utf-8?q?2dxQfG7nSaI30Mv1yGxDSykKdt2H2QuW5lHqdx6T3CZ4KVAxo7h1XhxPIhEJ6rWkC?= =?utf-8?q?y+cLgeRuMq8UIk/EAqyJQga2bbwu/utuRaJrt2TZJtZUM1Twn0mowIw0j5N+lg0OW?= =?utf-8?q?na74qOVnJBLG9CU1ofbCfXmC/DZ/KWZsQaBapn1KODTb3kk3JJzaFYcDCIRuq7mTA?= =?utf-8?q?lEWlXbxjN8enA1w91gLERzVKJiRzaho4OJY1Ju2D6Cz0DErp3SdzCYXV3l6HXSbwi?= =?utf-8?q?MBbzFHoSVVZCISABGhvT6FnWiG8omzG1A0cdAD4Ok7aWqI1dFUxrZiZ5kC6yuRjFw?= =?utf-8?q?BUYLGItuLBZzrM0y9R/gD5To4dA3GR64lP5Y8XIX6HtFBtCwo0ka8zH5wayeJA6AT?= =?utf-8?q?KuQ6wDzmLjLfPnWdZd7zOf9+DAfW+9ZRw+1LkVeNrP4mbui1Wn+Hz42H+q5Y56Yjn?= =?utf-8?q?X7B6TPiIPq9a3VaC2YOH5QBMcIVNk7xUR/Sqw0ifvrO8J8XlItceggWlTUohLvfdz?= =?utf-8?q?QV6Zjm4qASebgb/mNJ48bbLBBkReFK17V8DDM3Zhu7jh84eDnzLU+08N3PpA923pP?= =?utf-8?q?Ayg7X6PtgHUx2odrszIrFXPMaUMOx0cYxRS8jUhSa9HFh7TFxS+vBCJCwQaTLM0d/?= =?utf-8?q?Q9tUXfPADwY+gfIxAskUGekrTbvrNDIe8lMFMn0euljNvOtJCVLh9uYQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ol09Toww7IhsQ8TQz7xB63ohG6rx?= =?utf-8?q?t/0BWWJF6gVo+v/WvXZoYDEnZajxSKG35Ej/HKzZM5pCnpcwxC8o94GB5/0nbIwUN?= =?utf-8?q?NAtzc9w/Qa4ltRoXEN4igcZZnAa5Fk2z7ukveTb6TfGsbx87rT3F1iMcNihfbADdp?= =?utf-8?q?XBBgm+RXdflxczUNhiILg0KOSpeFpnQ11bvKMrq+LnBFjXE+ocO0bRMs2ZJvt+51O?= =?utf-8?q?RwFlhKgCHeHYvj33jIRnDUCQ12GZNP3aZth2QNVSb6GQjDf0ibrhoXHH5w11yi0GM?= =?utf-8?q?xAp6f6DO6rwoePs5Sc8w7BqwoRRGs3OQ3rpTIm2jlJPmOZPBxw+xFgXt3tFohcZWH?= =?utf-8?q?fn4B7W6LUXBLx3ISzMHymPae8jE1Y4FXzpR/sHO8/DyoDlAYhz19XNhSgyCW8pR0+?= =?utf-8?q?zB4/zPh+GK35BI+nEEMk0eCcRIuIVfWoNpzcuFr4pTrxCvGEcRfbzwAWzJMgpj831?= =?utf-8?q?KV7Sk2u6vyWikeE5JIlo6j16ZxMncurxSfEkzvY7pEMof8KIHyn6LXSYMbuSg7Rmk?= =?utf-8?q?fkmPXeAyk84bBTGc0ymE9pVYQTcWq59zYtRMPuAVTRIEOSAI0Z/+eDrm74Pba5F+F?= =?utf-8?q?ab4+O9X2SSc3fdBXIZxkBnbRkD1Ivxr90FePqNKiZqkZcRqLjOlQrYfe8De27zCKv?= =?utf-8?q?fZj1xmNXRQnvwj9KKz01LQn6xCziBGaR8w16plQ31Y4UW1wNQGotRSFu+HKMuLgeF?= =?utf-8?q?bkHgAtePfeOpX3nGeFiXEknfwQ0Sjz5TKHguqk4eI9amg2qaSkhpMxTueZobeTDGe?= =?utf-8?q?HO9kMOQP2GJlP/fJ/Vqth8LhQbXZUWnycV6wOu3BtW3WDhgSQHSNG6qnyku+cq6f1?= =?utf-8?q?VEzAaxYEmd9YlroTN7WNn46OTGETzsmdYVgahkaRpqd7qa6avUVrK/eQatBrxVBAf?= =?utf-8?q?kz56uNj2RFid4PERMWsG9mX36mrd+ghaiofCoQby7gw1bx7kobeS4Skxxr/V+qBiW?= =?utf-8?q?/44dkMCqK/tjrXPolP0nwKSmgsDvFbuiYa7sL1hr18duvJQ+bz7abYOKw+6lQ31Xz?= =?utf-8?q?M/nMxlC2Dn5f6RyWeVd+elT09+6NWm8qn14QHxRM9ue7VmWhjrWI1i2yHBMJbqL5w?= =?utf-8?q?ImbX1h/Dcwk0osJoRk2giEH0i2Zt7F6cBgSGkWELi8xcQwWYPFU0SXG2WFUKxd54W?= =?utf-8?q?e+p4j7l0yQtVDbzuw7qI6f6OJ7xdzR/b40zqoGt/oOchZUP8hKU9sdVrnjSPa/VUI?= =?utf-8?q?+No2K8nEP1DGuEihio+mMZBj4UHhKxgciO6fCVRLpHoOArt0Li1IyKcvVQTn7j+DZ?= =?utf-8?q?eUw77uthUF4j4y/Kb8KnfzTQFe4aPEjf/R2Q9jz5UCv+y+ZjTkJ3ItZi83alCNHgW?= =?utf-8?q?L1yuzDadDyjzZFHR+kKEDG/iolcxJwzI2VHgbNGQcBDRkRFYj/9DYJNuM8nkHApT0?= =?utf-8?q?qlR5a0TYGfJBJkrSGbBLhWfZuGPrpEDrhDjfohonie2GYzdKja/v28sEYLDvSR6rV?= =?utf-8?q?PEGypaurmP5dBNDuyz0e6ICJf8dDnmuRe/ClF0ndV96DbbGSSoRRkpc0BrcBPbGpY?= =?utf-8?q?rGqyMcFmCYKd?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c1176af-102a-4e3f-0f53-08dc6c3c7d6a X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:17:03.8642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QEgJUaP4zRnl3xuiECIIdwnDgtv8meyTZQoA+0gbgaDOSP2A4ZANHr3rQdpLv48ANaBT0NARX4dl/yrvw7Rd4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/pinconf-generic.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c index 80de389199bd..a499b8af5c1f 100644 --- a/drivers/pinctrl/pinconf-generic.c +++ b/drivers/pinctrl/pinconf-generic.c @@ -382,7 +382,6 @@ int pinconf_generic_dt_node_to_map(struct pinctrl_dev *pctldev, unsigned int *num_maps, enum pinctrl_map_type type) { unsigned int reserved_maps; - struct device_node *np; int ret; reserved_maps = 0; @@ -394,13 +393,11 @@ int pinconf_generic_dt_node_to_map(struct pinctrl_dev *pctldev, if (ret < 0) goto exit; - for_each_available_child_of_node(np_config, np) { + for_each_available_child_of_node_scoped(np_config, np) { ret = pinconf_generic_dt_subnode_to_map(pctldev, np, map, &reserved_maps, num_maps, type); - if (ret < 0) { - of_node_put(np); + if (ret < 0) goto exit; - } } return 0;