From patchwork Mon Sep 2 12:41:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marek_Beh=C3=BAn?= X-Patchwork-Id: 13787230 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A56FCA0ED3 for ; Mon, 2 Sep 2024 12:41:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 08F73C4CEC6; Mon, 2 Sep 2024 12:41:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C584C4CEC7; Mon, 2 Sep 2024 12:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725280892; bh=uTYJGwS6gkq0hTSsIoEjD5EwGJH188e8KYtruqHsaHM=; h=From:To:List-Id:Cc:Subject:Date:In-Reply-To:References:From; b=F0GzgIRB6w2CvYOraSJszSpQ8kE+I6hMtw30JwD2PvUJ36wED0G34QwhOCGd0dNgV yrHm4y0aL1EZmp6uV3uqWa9h3OwbIlqHQSrNr6ZL6EbFruSTqQ/M94zQnSWoy+3Tx0 uqI4quEGzSgJ8/WkBz3K0O/CxeWtadtu1dYfTP5uU2WfyP3Fm0pBq2dvkxa66Jk9Dc EELxhR7CF6swkftC25TybMBlDyhNAfnuZ7ppmI1Q6BuF3o+rvFzZV1DnjbsZR75syE 9u7HrDMeLaxXq/ZJHg4BdE4/mzTjbWIx3BrHiRS1wYV4iQGbQYrmZhONWQOR2T4c6M 6EF4GfF0L16Pw== From: =?utf-8?q?Marek_Beh=C3=BAn?= To: Lee Jones List-Id: Cc: Pavel Machek , linux-leds@vger.kernel.org, Arnd Bergmann , soc@kernel.org, Gregory CLEMENT , arm@kernel.org, Andy Shevchenko , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Andrew Lunn , Sebastian Hesselbarth , =?utf-8?q?Marek_Be?= =?utf-8?q?h=C3=BAn?= Subject: [PATCH leds 7/8] leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU driver Date: Mon, 2 Sep 2024 14:41:03 +0200 Message-ID: <20240902124104.14297-8-kabel@kernel.org> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240902124104.14297-1-kabel@kernel.org> References: <20240902124104.14297-1-kabel@kernel.org> MIME-Version: 1.0 If the LED gamma correction feature is missing in the MCU firmware, inform about this in the MCU firmware probe function instead of LED driver probe function, so that all the feature checks are in one place. Signed-off-by: Marek Behún --- drivers/leds/leds-turris-omnia.c | 9 +-------- drivers/platform/cznic/turris-omnia-mcu-base.c | 1 + 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/leds/leds-turris-omnia.c b/drivers/leds/leds-turris-omnia.c index bf8635cec72e..7b5c1484924e 100644 --- a/drivers/leds/leds-turris-omnia.c +++ b/drivers/leds/leds-turris-omnia.c @@ -465,15 +465,8 @@ static int omnia_leds_probe(struct i2c_client *client) return ret; } - has_brightness_interrupt = ret & OMNIA_FEAT_BRIGHTNESS_INT; - leds->has_gamma_correction = ret & OMNIA_FEAT_LED_GAMMA_CORRECTION; - if (!leds->has_gamma_correction) { - dev_info(dev, - "Your board's MCU firmware does not support the LED gamma correction feature.\n"); - dev_info(dev, - "Consider upgrading MCU firmware with the omnia-mcutool utility.\n"); - } + has_brightness_interrupt = ret & OMNIA_FEAT_BRIGHTNESS_INT; mutex_init(&leds->lock); diff --git a/drivers/platform/cznic/turris-omnia-mcu-base.c b/drivers/platform/cznic/turris-omnia-mcu-base.c index 3bb4a3cfdb29..770e680b96f9 100644 --- a/drivers/platform/cznic/turris-omnia-mcu-base.c +++ b/drivers/platform/cznic/turris-omnia-mcu-base.c @@ -259,6 +259,7 @@ static int omnia_mcu_read_features(struct omnia_mcu *mcu) _DEF_FEAT(POWEROFF_WAKEUP, "poweroff and wakeup"), _DEF_FEAT(TRNG, "true random number generator"), _DEF_FEAT(BRIGHTNESS_INT, "LED panel brightness change interrupt"), + _DEF_FEAT(LED_GAMMA_CORRECTION, "LED gamma correction"), #undef _DEF_FEAT }; struct i2c_client *client = mcu->client;