From patchwork Tue Oct 29 13:56:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marek_Beh=C3=BAn?= X-Patchwork-Id: 13854953 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7B4920697B for ; Tue, 29 Oct 2024 13:57:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730210228; cv=none; b=baoJJypNcnpFIyVR9Fo8oati+MbKF1UYvsMt+y5tnLg+ZAN2VOnknlgllKkNc6WlcJwGcYZwio4RmA0TtAYYwrJib+jseKaM5jEZt9YJcw+QQwvv2v6HdxmGJSJ6utBfhHTtLymwVJtSIDvJkgpIxFGqP7IAQoBYFdKZuRC+yfw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730210228; c=relaxed/simple; bh=CCLzLrkY1aUdwA4JUmu0VIFCmTUXNRsm5pghqLPBTbQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VJv2a67mCcdYNvBOmrwizEua2fbpzudeNkazPwXOlsD7pL90eY6LCOIepEXe8V54MUvoMJ2LY5NwdwgoXMvT5EJlHhQKp21CmV6GrYYiH19FJImk8dX9/EKqWIESM83h/k3VlMKKzOQkaxhvgQhzMcj2ukFfeAsosOkrvXT2wnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HPDqrvHz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HPDqrvHz" Received: by smtp.kernel.org (Postfix) id 6C80FC4AF0F; Tue, 29 Oct 2024 13:57:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7229C4CEEA; Tue, 29 Oct 2024 13:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730210228; bh=CCLzLrkY1aUdwA4JUmu0VIFCmTUXNRsm5pghqLPBTbQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HPDqrvHzA5uFPY5XHbdOY6BmwmPDyllAmOtgQuD1DjfPKQYqR3JupXtNRmHWhp7xm kCrtgvqtVcalhmx5HePCy/rM410y5quStkMkojOXVbKBELZv3zggofkhfTcnjwLuje ubPIqmr5/v+dau4OuWAF8RXqXmV8A7Yp/SVbdAPI7obmcVNgz8p8ygRmvth0CsanQ7 ov7oUJzKUI7Hg4I9J55uz+jMvMdKXXt4d7y0vJDDS9VTAiJfpbdq0xDubw144lBHzi mzNXoXVDlAWf+rQoNvnafJ4hX+kDZH5IYmOAaf71GJxDHcK6LNzXmcNUixFAPHmIpc PGZuqAgw2uFzg== From: =?utf-8?q?Marek_Beh=C3=BAn?= To: Lee Jones Cc: Pavel Machek , linux-leds@vger.kernel.org, Arnd Bergmann , soc@kernel.org, Gregory CLEMENT , arm@kernel.org, Andy Shevchenko , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, =?utf-8?q?M?= =?utf-8?q?arek_Beh=C3=BAn?= Subject: [PATCH leds v4 09/12] leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU driver Date: Tue, 29 Oct 2024 14:56:18 +0100 Message-ID: <20241029135621.12546-10-kabel@kernel.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241029135621.12546-1-kabel@kernel.org> References: <20241029135621.12546-1-kabel@kernel.org> Precedence: bulk X-Mailing-List: soc@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 If the LED gamma correction feature is missing in the MCU firmware, inform about this in the MCU firmware probe function instead of LED driver probe function, so that all the feature checks are in one place. Signed-off-by: Marek Behún --- drivers/leds/leds-turris-omnia.c | 6 ------ drivers/platform/cznic/turris-omnia-mcu-base.c | 1 + 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/leds/leds-turris-omnia.c b/drivers/leds/leds-turris-omnia.c index ac7938f57bfe..0b0cf592557a 100644 --- a/drivers/leds/leds-turris-omnia.c +++ b/drivers/leds/leds-turris-omnia.c @@ -456,12 +456,6 @@ static int omnia_leds_probe(struct i2c_client *client) } leds->has_gamma_correction = ret & OMNIA_FEAT_LED_GAMMA_CORRECTION; - if (!leds->has_gamma_correction) { - dev_info(dev, - "Your board's MCU firmware does not support the LED gamma correction feature.\n"); - dev_info(dev, - "Consider upgrading MCU firmware with the omnia-mcutool utility.\n"); - } if (ret & OMNIA_FEAT_BRIGHTNESS_INT) { ret = devm_request_threaded_irq(dev, client->irq, NULL, diff --git a/drivers/platform/cznic/turris-omnia-mcu-base.c b/drivers/platform/cznic/turris-omnia-mcu-base.c index 3bb4a3cfdb29..770e680b96f9 100644 --- a/drivers/platform/cznic/turris-omnia-mcu-base.c +++ b/drivers/platform/cznic/turris-omnia-mcu-base.c @@ -259,6 +259,7 @@ static int omnia_mcu_read_features(struct omnia_mcu *mcu) _DEF_FEAT(POWEROFF_WAKEUP, "poweroff and wakeup"), _DEF_FEAT(TRNG, "true random number generator"), _DEF_FEAT(BRIGHTNESS_INT, "LED panel brightness change interrupt"), + _DEF_FEAT(LED_GAMMA_CORRECTION, "LED gamma correction"), #undef _DEF_FEAT }; struct i2c_client *client = mcu->client;