| Message ID | 20240716183333.138498-1-sj@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Backport patches for DAMON merge regions fix | expand |
On Tue, Jul 16, 2024 at 11:33:25AM -0700, SeongJae Park wrote: > Commit 310d6c15e910 ("mm/damon/core: merge regions aggressively when > max_nr_regions") causes a build warning and a build failure [1] on > 5.15.y. Those are due to > 1) unnecessarily strict type check from max(), and > 2) use of not-yet-introduced damon_ctx->attrs field, respectively. > > Fix the warning by backporting a minmax.h upstream commit that made the > type check less strict for unnecessary case, and upstream commits that > it depends on. > > Note that all patches except the fourth one ("minmax: fix header > inclusions") are clean cherry-picks of upstream commit. For the fourth > one, minor conflict resolving was needed. > > Also, the last patch, which is the backport of the DAMON fix, was > cleanly cherry-picked, but added manual fix for the build failure. > > [1] https://lore.kernel.org/2024071532-pebble-jailhouse-48b2@gregkh All now queued up, again, thank you for the minmax backports, much appreciated. greg k-h
Commit 310d6c15e910 ("mm/damon/core: merge regions aggressively when max_nr_regions") causes a build warning and a build failure [1] on 5.15.y. Those are due to 1) unnecessarily strict type check from max(), and 2) use of not-yet-introduced damon_ctx->attrs field, respectively. Fix the warning by backporting a minmax.h upstream commit that made the type check less strict for unnecessary case, and upstream commits that it depends on. Note that all patches except the fourth one ("minmax: fix header inclusions") are clean cherry-picks of upstream commit. For the fourth one, minor conflict resolving was needed. Also, the last patch, which is the backport of the DAMON fix, was cleanly cherry-picked, but added manual fix for the build failure. [1] https://lore.kernel.org/2024071532-pebble-jailhouse-48b2@gregkh Andy Shevchenko (1): minmax: fix header inclusions Bart Van Assche (1): tracing: Define the is_signed_type() macro once David Laight (3): minmax: allow min()/max()/clamp() if the arguments have the same signedness. minmax: allow comparisons of 'int' against 'unsigned char/short' minmax: relax check to allow comparison between unsigned arguments and signed constants Jason A. Donenfeld (2): minmax: sanity check constant bounds when clamping minmax: clamp more efficiently by avoiding extra comparison SeongJae Park (1): mm/damon/core: merge regions aggressively when max_nr_regions is unmet include/linux/compiler.h | 6 +++ include/linux/minmax.h | 89 ++++++++++++++++++++++++++---------- include/linux/overflow.h | 1 - include/linux/trace_events.h | 2 - mm/damon/core.c | 23 ++++++++-- 5 files changed, 90 insertions(+), 31 deletions(-) base-commit: 4d1b7f1bf3858ed48a98c004bda5fdff2cdf13c8