From patchwork Fri Sep 28 01:54:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Santos X-Patchwork-Id: 1516441 Return-Path: X-Original-To: patchwork-linux-sparse@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id EFB86DFFAD for ; Fri, 28 Sep 2012 01:57:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756287Ab2I1B52 (ORCPT ); Thu, 27 Sep 2012 21:57:28 -0400 Received: from b-pb-sasl-quonix.pobox.com ([208.72.237.35]:50960 "EHLO smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756588Ab2I1Bzx (ORCPT ); Thu, 27 Sep 2012 21:55:53 -0400 Received: from smtp.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id 78AB18EB6; Thu, 27 Sep 2012 21:55:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:date:message-id:in-reply-to:references; s=sasl; bh=+t3t /prdOMp20eGqzono5UJC0ts=; b=I43Rj3y3u/vPnNOu43+uhQ4rJugdkqR/urjs yhGHG8fAudtHxMp7WXwoky+mWSGcS7xeh2+QaFPD6axqbhm1nAG2+OV5ELA6YVU7 x3y9Hcn/wcF+XqnAN7oVtXY+rGI9NB9qdFAJeE9AL3wJNdjpRNuWOkkp2NH/LhTR HCPShfY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:date:message-id:in-reply-to:references; q=dns; s=sasl; b= uBMQbfqjA7KO93K2buaj/SzeHm0/piWvbdZksA4s7L4rWr6yTyGJgcx3dWl9Sg7h fUW48C2GEotd0uh6Sm85f/aSiJkwCJYx37EgSRrfGp4gMHmK8YqMIM1vRhIyJGmA PjUXS4ulIEsxEhYpvn3VXhQX3LCFDqlebx3mbOh0c+8= Received: from b-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id 643D78EB4; Thu, 27 Sep 2012 21:55:53 -0400 (EDT) Received: from localhost.localdomain (unknown [99.70.244.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by b-sasl-quonix.pobox.com (Postfix) with ESMTPSA id D6FC38EB2; Thu, 27 Sep 2012 21:55:50 -0400 (EDT) From: Daniel Santos To: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-sparse@vger.kernel.org, Akinobu Mita , Andi Kleen , Andrea Arcangeli , Andrew Morton , Christopher Li , David Daney , David Howells , David Rientjes , David Woodhouse , Don Zickus , Greg Kroah-Hartman , Hidetoshi Seto , "H. Peter Anvin" Cc: Daniel Santos Subject: [PATCH v6 3/25] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro Date: Thu, 27 Sep 2012 20:54:19 -0500 Message-Id: <1348797281-25021-4-git-send-email-daniel.santos@pobox.com> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: <1348797281-25021-1-git-send-email-daniel.santos@pobox.com> References: <1348797281-25021-1-git-send-email-daniel.santos@pobox.com> X-Pobox-Relay-ID: A282C21C-090F-11E2-84AF-18772E706CDE-06139138!b-pb-sasl-quonix.pobox.com Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org Throughout compiler*.h, many version checks are made. These can be simplified by using the macro that gcc's documentation recommends. However, my primary reason for adding this is that I need bug-check macros that are enabled at certain gcc versions and it's cleaner to use this macro than the tradition method: if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ => 2) If you add patch level, it gets this ugly: if __GNUC__ > 4 || (__GNUC__ == 4 && (__GNUC_MINOR__ > 2 || \ __GNUC_MINOR__ == 2 __GNUC_PATCHLEVEL__ >= 1)) As opposed to: if GCC_VERSION >= 40201 While having separate headers for gcc 3 & 4 eliminates some of this verbosity, they can still be cleaned up by this. See also: http://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html Signed-off-by: Daniel Santos --- include/linux/compiler-gcc.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index 6a6d7ae..24545cd 100644 --- a/include/linux/compiler-gcc.h +++ b/include/linux/compiler-gcc.h @@ -5,6 +5,9 @@ /* * Common definitions for all gcc versions go here. */ +#define GCC_VERSION (__GNUC__ * 10000 \ + + __GNUC_MINOR__ * 100 \ + + __GNUC_PATCHLEVEL__) /* Optimization barrier */