From patchwork Wed Jan 30 19:32:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 2069551 Return-Path: X-Original-To: patchwork-linux-sparse@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 74D01DF2E5 for ; Wed, 30 Jan 2013 19:33:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755333Ab3A3TdC (ORCPT ); Wed, 30 Jan 2013 14:33:02 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:64764 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753070Ab3A3TdB (ORCPT ); Wed, 30 Jan 2013 14:33:01 -0500 Received: from mailbox.adnet.avionic-design.de (mailbox.avionic-design.de [109.75.18.3]) by mrelayeu.kundenserver.de (node=mrbap4) with ESMTP (Nemesis) id 0LlVhP-1UbLGW3dbD-00b3gz; Wed, 30 Jan 2013 20:33:00 +0100 Received: from localhost (localhost [127.0.0.1]) by mailbox.adnet.avionic-design.de (Postfix) with ESMTP id 284E92A281E7; Wed, 30 Jan 2013 20:32:59 +0100 (CET) X-Virus-Scanned: amavisd-new at avionic-design.de Received: from mailbox.adnet.avionic-design.de ([127.0.0.1]) by localhost (mailbox.avionic-design.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RgrD-oEA5jwB; Wed, 30 Jan 2013 20:32:58 +0100 (CET) Received: from mailman.adnet.avionic-design.de (mailman.adnet.avionic-design.de [172.20.31.172]) by mailbox.adnet.avionic-design.de (Postfix) with ESMTP id 2F3D32A281DE; Wed, 30 Jan 2013 20:32:58 +0100 (CET) Received: from localhost (avionic-0098.adnet.avionic-design.de [172.20.31.233]) by mailman.adnet.avionic-design.de (Postfix) with ESMTP id 8AC9B100475; Wed, 30 Jan 2013 20:32:54 +0100 (CET) From: Thierry Reding To: linux-sparse@vger.kernel.org Cc: Christopher Li , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: [PATCH 2/2] Ignore address space for IS_ERR() and friends Date: Wed, 30 Jan 2013 20:32:57 +0100 Message-Id: <1359574377-3402-2-git-send-email-thierry.reding@avionic-design.de> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1359574377-3402-1-git-send-email-thierry.reding@avionic-design.de> References: <1359574377-3402-1-git-send-email-thierry.reding@avionic-design.de> X-Provags-ID: V02:K0:QYUPWslRk+j1faeoVWvzDvWZVCrVE4rWPB9EOfDuKBF K/bKHps9Ey7xkG/dhvl7sbI6lD36++GFHn26dh7jhaAcqEdyUi pYN8IGJDBimU8bpHAzuV5wYyaA4THH77DPEspJ1DGbzebbECuB dyPYuxnDcVeyaYYBQoc7EV+RoW8nfhgJY1ETpV/2YQjqpJXzdM OuUNlgF9ygsK6Fm5xkZBkOoc46NxDo7gDDOcNSQLc59SYsWNlD yk+XowtWJvXCMm3mgSFI5exlpDjtxgCaeqcetS4arq3vQJh9t7 u1JWUrB/nTuCrcPK6g225e9bB8kNfUB5BW9+3Zqrs7V8QMy09Y reLxl0Sowc8FrzQausWeHbGy9aB0OuuzhmgSAd3r+hMlFwP25m 2ad3m9mLHd+ibZb2h1gFaH/BtIujQfv/cK2F11DJYJ/QS/B7Af tTxJi Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org This patch ignores sparse' address_space and noderef attributes for pointers passed to the IS_ERR() and related functions. Since they only extract an error code or compare the pointer to an integer value, they can safely be used on any type of pointer. Signed-off-by: Thierry Reding --- Note that in order for this to work a patched version of sparse is required. include/linux/err.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/err.h b/include/linux/err.h index f2edce2..92103bf 100644 --- a/include/linux/err.h +++ b/include/linux/err.h @@ -24,17 +24,17 @@ static inline void * __must_check ERR_PTR(long error) return (void *) error; } -static inline long __must_check PTR_ERR(const void *ptr) +static inline long __must_check PTR_ERR(const void __force *ptr) { return (long) ptr; } -static inline long __must_check IS_ERR(const void *ptr) +static inline long __must_check IS_ERR(const void __force *ptr) { return IS_ERR_VALUE((unsigned long)ptr); } -static inline long __must_check IS_ERR_OR_NULL(const void *ptr) +static inline long __must_check IS_ERR_OR_NULL(const void __force *ptr) { return !ptr || IS_ERR_VALUE((unsigned long)ptr); } @@ -46,13 +46,13 @@ static inline long __must_check IS_ERR_OR_NULL(const void *ptr) * Explicitly cast an error-valued pointer to another pointer type in such a * way as to make it clear that's what's going on. */ -static inline void * __must_check ERR_CAST(const void *ptr) +static inline void * __must_check ERR_CAST(const void __force *ptr) { /* cast away the const */ return (void *) ptr; } -static inline int __must_check PTR_RET(const void *ptr) +static inline int __must_check PTR_RET(const void __force *ptr) { if (IS_ERR(ptr)) return PTR_ERR(ptr);