| Message ID | 1422757186-8007-3-git-send-email-luc.vanoostenryck@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Sat, Jan 31, 2015 at 6:19 PM, Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote: > The purpose of show_data() is to visualize data, more or less I think show_data() is a bad name. Data is very generic term, it has not specific meaning what exactly is that data. What you really want to show is the initializer expression. Make the function name reflect that. > diff --git a/linearize.c b/linearize.c Why is this function belongs to linearize.c? It has nothing to do with linearization instruction. It has every thing to do with the AST structure. I suggest that move this code to show-parse.c. There are many functions showing internal of the AST there. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Feb 01, 2015 at 09:30:44PM -0800, Christopher Li wrote: > On Sat, Jan 31, 2015 at 6:19 PM, Luc Van Oostenryck > <luc.vanoostenryck@gmail.com> wrote: > > The purpose of show_data() is to visualize data, more or less > > I think show_data() is a bad name. Data is very generic term, > it has not specific meaning what exactly is that data. > > What you really want to show is the initializer expression. > Make the function name reflect that. Yes, the name is too generic. The purpose was to use 'data' in opposition to 'code'. > > diff --git a/linearize.c b/linearize.c > > Why is this function belongs to linearize.c? > It has nothing to do with linearization instruction. It has > every thing to do with the AST structure. > > I suggest that move this code to show-parse.c. > There are many functions showing internal of the AST > there. Well, I put it in linearize because it's where show_entry() is defined and since I wanted this new show function be its complement, it seemed to me much better to put it there than in show-parse.c Even more so because I'm not interested in showing anything close to the AST, on the contrary, I want to show the values like you would find them in an assembler code file generated by a compiler after constant folding, string expansion, type coercion, ... Anyway, my intention was not to have it included as is (mainly because it's not complete) but only as a quick tool to investigate the bug that Rasmus have reported. I'll try to complete it and resubmit it then, taking your remarks in account. Regards, Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/linearize.c b/linearize.c index c6ada1e8..28beb271 100644 --- a/linearize.c +++ b/linearize.c @@ -2220,3 +2220,89 @@ struct entrypoint *linearize_symbol(struct symbol *sym) return linearize_fn(sym, base_type); return NULL; } + +static void do_indent(int level) +{ + while (level--) + printf("\t"); +} + +static void show_data_expr(struct expression *expr, int indent) +{ + struct expression *entry; + struct symbol *sym; + + switch (expr->type) { + case EXPR_VALUE: + printf("%lld", expr->value); + break; + case EXPR_SYMBOL: + sym = expr->symbol; + if (sym->initializer && sym->initializer->type == EXPR_STRING) + return show_data_expr(sym->initializer, indent); + printf("%s", show_ident(expr->symbol_name)); + break; + case EXPR_IMPLIED_CAST: + show_data_expr(expr->cast_expression, indent); + break; + case EXPR_STRING: + printf("%s", show_string(expr->string)); + break; + case EXPR_INITIALIZER: + printf("{"); + FOR_EACH_PTR(expr->expr_list, entry) { + switch (entry->type) { + case EXPR_POS: + case EXPR_INDEX: + case EXPR_IDENTIFIER: + continue; + } + do_indent(indent+1); + show_data_expr(entry, indent+1); + printf(",\n"); + } END_FOR_EACH_PTR(entry); + do_indent(indent); + printf("}"); + break; + case EXPR_PREOP: + if (expr->op == '*') { + show_data_expr(expr->unop, indent); + break; + } + // Fall through + default: + printf("!!unhandled expression type (%d)", expr->type); + break; + } +} + +void show_data(struct symbol *sym) +{ + struct expression *expr = sym->initializer; + + printf("symbol %s:\n", show_ident(sym->ident)); + printf("\t"); show_type(sym); printf("\n"); + printf("\tbit_size = %i\n", sym->bit_size); + printf("\tval = "); + switch (sym->ctype.base_type->type) { + case SYM_BASETYPE: + case SYM_ENUM: + show_data_expr(expr, 0); + break; + case SYM_PTR: + printf("&"); + show_data_expr(expr, 0); + break; + case SYM_ARRAY: + show_data_expr(expr, 0); + break; + case SYM_STRUCT: + case SYM_UNION: + show_data_expr(expr, 1); + break; + default: + printf("\ttype = %d\n", sym->ctype.base_type->type); + break; + } + printf("\n"); +} diff --git a/linearize.h b/linearize.h index 61fbd831..7b2d0681 100644 --- a/linearize.h +++ b/linearize.h @@ -344,6 +344,7 @@ void show_entry(struct entrypoint *ep); const char *show_pseudo(pseudo_t pseudo); void show_bb(struct basic_block *bb); const char *show_instruction(struct instruction *insn); +void show_data(struct symbol *sym); #endif /* LINEARIZE_H */
The purpose of show_data() is to visualize data, more or less like show_entry() allow to visualize the code. The support is not complete but at least the basic types are handled. Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> --- linearize.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ linearize.h | 1 + 2 files changed, 87 insertions(+)