From patchwork Sun Oct 11 21:59:49 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Josh Triplett <josh@joshtriplett.org>
X-Patchwork-Id: 53034
Received: from vger.kernel.org (vger.kernel.org [209.132.176.167])
	by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n9BMMK3j020081
	for <patchwork-sparse@patchwork.kernel.org>;
	Sun, 11 Oct 2009 22:22:25 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750770AbZJKWUF (ORCPT
	<rfc822;patchwork-sparse@patchwork.kernel.org>);
	Sun, 11 Oct 2009 18:20:05 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750962AbZJKWUE
	(ORCPT <rfc822;linux-sparse-outgoing>);
	Sun, 11 Oct 2009 18:20:04 -0400
Received: from slow3-v.mail.gandi.net ([217.70.178.89]:34620 "EHLO
	slow3-v.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750770AbZJKWUD (ORCPT
	<rfc822;linux-sparse@vger.kernel.org>);
	Sun, 11 Oct 2009 18:20:03 -0400
Received: from relay2-v.mail.gandi.net (relay2-v.mail.gandi.net
	[217.70.178.76])
	by slow3-v.mail.gandi.net (Postfix) with ESMTP id 96142421F8
	for <linux-sparse@vger.kernel.org>;
	Mon, 12 Oct 2009 00:00:44 +0200 (CEST)
Received: from feather (unknown [76.75.8.40])
	by relay2-v.mail.gandi.net (Postfix) with ESMTP id B4D49135D0;
	Sun, 11 Oct 2009 23:59:57 +0200 (CEST)
Date: Sun, 11 Oct 2009 14:59:49 -0700
From: Josh Triplett <josh@joshtriplett.org>
To: linux-sparse@vger.kernel.org
Cc: sparse@chrisli.org
Subject: [PATCH] Rename -Wall to Wsparse-all, so it doesn't get turned on
	unintentionally
Message-ID: <20091011215943.GA2684@feather>
MIME-Version: 1.0
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-sparse-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-sparse.vger.kernel.org>
X-Mailing-List: linux-sparse@vger.kernel.org


diff --git a/cgcc b/cgcc
index 995cc05..ff8c921 100755
--- a/cgcc
+++ b/cgcc
@@ -51,7 +51,7 @@ while (@ARGV) {
 
     my $this_arg = ' ' . &quote_arg ($_);
     $cc .= $this_arg unless &check_only_option ($_);
-    $check .= $this_arg unless &cc_only_option ($_);
+    $check .= $this_arg;
 }
 
 if ($gendeps) {
@@ -94,19 +94,6 @@ sub check_only_option {
 }
 
 # -----------------------------------------------------------------------------
-# Check if an option is for "cc" only.
-
-sub cc_only_option {
-    my ($arg) = @_;
-    # -Wall turns on all Sparse warnings, including experimental and noisy
-    # ones.  Don't include it just because a project wants to pass -Wall to cc.
-    # If you really want cgcc to run sparse with -Wall, use
-    # CHECK="sparse -Wall".
-    return 1 if $arg =~ /^-Wall$/;
-    return 0;
-}
-
-# -----------------------------------------------------------------------------
 # Simple arg-quoting function.  Just adds backslashes when needed.
 
 sub quote_arg {
diff --git a/lib.c b/lib.c
index 622b547..963be08 100644
--- a/lib.c
+++ b/lib.c
@@ -407,7 +407,7 @@ static char **handle_onoff_switch(char *arg, char **next, const struct warning w
 	char *p = arg + 1;
 	unsigned i;
 
-	if (!strcmp(p, "all")) {
+	if (!strcmp(p, "sparse-all")) {
 		for (i = 0; i < n; i++) {
 			if (*warnings[i].flag != WARNING_FORCE_OFF)
 				*warnings[i].flag = WARNING_ON;
diff --git a/sparse.1 b/sparse.1
index d7fe444..abc75a2 100644
--- a/sparse.1
+++ b/sparse.1
@@ -20,6 +20,10 @@ off those warnings, pass the negation of the associated warning option,
 .
 .SH WARNING OPTIONS
 .TP
+.B \-Wsparse\-all
+Turn on all sparse warnings, except for those explicitly disabled via
+\fB\-Wno\-something\fR.
+.TP
 .B \-Waddress\-space
 Warn about code which mixes pointers to different address spaces.