From patchwork Sun Nov 21 20:25:48 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Kaiser X-Patchwork-Id: 346191 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oALKVYhD018725 for ; Sun, 21 Nov 2010 20:31:34 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754883Ab0KUUbc (ORCPT ); Sun, 21 Nov 2010 15:31:32 -0500 Received: from webhosting01.bon.m2soft.com ([195.38.20.32]:57283 "EHLO webhosting01.bon.m2soft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754993Ab0KUUbc (ORCPT ); Sun, 21 Nov 2010 15:31:32 -0500 Received: from absol.kitzblitz ([91.119.0.44]) (authenticated bits=0) by webhosting01.bon.m2soft.com (8.13.8/8.13.8) with ESMTP id oALKSoTS032190; Sun, 21 Nov 2010 21:28:50 +0100 Date: Sun, 21 Nov 2010 21:25:48 +0100 From: Nicolas Kaiser To: Christopher Li Cc: linux-sparse@vger.kernel.org Subject: [PATCH] memops.c: always true expression Message-ID: <20101121212548.6230da08@absol.kitzblitz> Organization: - X-Face: "fF&[w2"Nws:JNH4'g|:gVhgGKLhj|X}}&w&V?]0=, 7n`jy8D6e[Jh=7+ca|4~t5e[ItpL5 N'y~Mvi-vJm`"1T5fi1^b!&EG]6nW~C!FN},=$G?^U2t~n[3;u\"5-|~H{-5]IQ2 X-Mailer: Claws Mail (Linux) Mime-Version: 1.0 Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Sun, 21 Nov 2010 20:31:35 +0000 (UTC) diff --git a/memops.c b/memops.c index 9eafb72..45bd340 100644 --- a/memops.c +++ b/memops.c @@ -69,7 +69,7 @@ static int address_taken(pseudo_t pseudo) struct pseudo_user *pu; FOR_EACH_PTR(pseudo->users, pu) { struct instruction *insn = pu->insn; - if (insn->bb && (insn->opcode != OP_LOAD || insn->opcode != OP_STORE)) + if (insn->bb && (insn->opcode != OP_LOAD && insn->opcode != OP_STORE)) return 1; } END_FOR_EACH_PTR(pu); return 0;