From patchwork Wed Dec 7 15:46:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9464767 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7EC2B6022E for ; Wed, 7 Dec 2016 15:47:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 849CE28358 for ; Wed, 7 Dec 2016 15:47:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 797A128517; Wed, 7 Dec 2016 15:47:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 265AF28358 for ; Wed, 7 Dec 2016 15:47:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932228AbcLGPrL (ORCPT ); Wed, 7 Dec 2016 10:47:11 -0500 Received: from mail-wj0-f195.google.com ([209.85.210.195]:33769 "EHLO mail-wj0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932177AbcLGPrK (ORCPT ); Wed, 7 Dec 2016 10:47:10 -0500 Received: by mail-wj0-f195.google.com with SMTP id kp2so50544974wjc.0 for ; Wed, 07 Dec 2016 07:47:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fXP+BIcD3mXc2ZHvRDWG2surWXK3lOqbcOizZuxKe+E=; b=t156ZGySw+CCcTmr3FIDdlhCIKIZD8KzLFuYPNarUglhCgS/5DK3Hsz3XRhAwP4VQk a35AwTlvWTuOnv46VPuu2M7l/ceV8F81tvvYEQnGURKhHgVBDy08tHQtJ6ItPL5/1OdV on9qT0PIyCnk+ED1hFIfJqcf5r3qjgtqcXGODRChmkEQjrwuLMx/k6XjbKhMfA/m007O YBIb5fm3sqCEXqjaoerrd3uCc5edW2I3AlS8WX1PbIv1orLhsvdJMJOH9uwkIVkVaNHj Gzyex2V3D9wVJDAHxuVrj8dwgrsEGbBc9+T5iZVKm0TaPeew+0vj3hawaHoDTUUq3Ljp yUIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fXP+BIcD3mXc2ZHvRDWG2surWXK3lOqbcOizZuxKe+E=; b=kO8fbgf4QBNl5k/bE14nH/7G6NazNnwKMiulKAXXFhpTHkj7jXIwNjyFKqZMm01O2U 7iS6hrkdK40g1pmDytO8fH4JImPx8f7jRVZ9zYWjODEZr17v2vzqzAyb/x6LIjmIeXaB bOAEMWyY1ca5dWUGN4Ngh34EEC8wCcR/0J//uILaAfSUKjQJW9uHdpElVopeFRyzYVUV koD/hR8+16RcLhWaXqo4sFEeR9zOXE5i+CjGXZmzEyknfqh+9TxjUNa555gCoZuLbBle HjeOAvkYeCrG5438SXNK9SRWCUGmk3fvGaKhYLw+TXBnzFjlmADV67yMA6UcW2zTRhQT BfdQ== X-Gm-Message-State: AKaTC03fK1xDkECd1HnU8E2HMgBrrUGn72MPdjgUdGDVGCOSRSpmXaB6LOGRh7U5IV4/ng== X-Received: by 10.194.188.9 with SMTP id fw9mr59825030wjc.213.1481125628660; Wed, 07 Dec 2016 07:47:08 -0800 (PST) Received: from localhost.localdomain ([2a02:a03f:816:ae00:7dc3:2e5b:38fe:befd]) by smtp.gmail.com with ESMTPSA id b7sm32020014wjm.39.2016.12.07.07.47.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Dec 2016 07:47:08 -0800 (PST) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Christopher Li , Luc Van Oostenryck Subject: [PATCH 5/5] simplify '(x % 1)' into '0' Date: Wed, 7 Dec 2016 16:46:55 +0100 Message-Id: <20161207154655.98109-6-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20161207154655.98109-1-luc.vanoostenryck@gmail.com> References: <20161207154655.98109-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For completeness, add the dual simplification 'x * 1 => x' for modulo: 'x % 1 => 0'. Signed-off-by: Luc Van Oostenryck --- simplify.c | 5 +++++ validation/optim/muldiv-by-one.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/simplify.c b/simplify.c index e3e5ff6e..9a6222c9 100644 --- a/simplify.c +++ b/simplify.c @@ -365,6 +365,11 @@ static int simplify_constant_rightside(struct instruction *insn) case OP_ASR: return simplify_asr(insn, insn->src1, value); + case OP_MODU: case OP_MODS: + if (value == 1) + return replace_with_pseudo(insn, value_pseudo(0)); + return 0; + case OP_DIVU: case OP_DIVS: case OP_MULU: case OP_MULS: return simplify_mul_div(insn, value); diff --git a/validation/optim/muldiv-by-one.c b/validation/optim/muldiv-by-one.c index f6dd7cb2..5d9b458e 100644 --- a/validation/optim/muldiv-by-one.c +++ b/validation/optim/muldiv-by-one.c @@ -5,6 +5,8 @@ si smul1(si a) { return a * 1; } ui umul1(ui a) { return a * 1; } si sdiv1(si a) { return a / 1; } ui udiv1(ui a) { return a / 1; } +si smod1(si a) { return a % 1; } +ui umod1(ui a) { return a % 1; } /* * check-name: muldiv-by-one @@ -13,4 +15,5 @@ ui udiv1(ui a) { return a / 1; } * * check-output-excludes: mul[us]\\. * check-output-excludes: div[us]\\. + * check-output-excludes: mod[us]\\. */