From patchwork Tue Feb 7 20:50:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9561149 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 08AE66047A for ; Tue, 7 Feb 2017 20:53:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F06DA28236 for ; Tue, 7 Feb 2017 20:53:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E48B328443; Tue, 7 Feb 2017 20:53:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9EA3528236 for ; Tue, 7 Feb 2017 20:53:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932101AbdBGUxx (ORCPT ); Tue, 7 Feb 2017 15:53:53 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36641 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754963AbdBGUxS (ORCPT ); Tue, 7 Feb 2017 15:53:18 -0500 Received: by mail-wm0-f65.google.com with SMTP id r18so30609454wmd.3 for ; Tue, 07 Feb 2017 12:52:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Sud2CcmA00fuWaxY4yirsGbjBPAdIx+zThhEOEnCTto=; b=ELCAtNiWSnnAB/G5O+s9i2sAoYV4uCtMPJQxTOl87QCWupToSa6jXNnqNr4odm89YF 6wAaShJ8fSOpSz8AoJm8qYZ2mt7iIFLb9yfTyi2JOiO2/MGmz4KHPqLWch5z9iA7GACa VKUBl02azPqbIDnUixZ2HevhAy/YxiEEQUGjvReatWXBVa7gnI7/Nr39JOkWlAVFyqZ0 TRyRVAo0NHnweEckvE34Hl0oz2XPsOyfRpLHVWDDMpEt5EKfmsQRnTm1d4kEMw6FbPSX I3nJMD+O7wfrMFM8g5udzGN34/HkxurjCSALMMk+YLilRBfXkVa0/sn5VdhURj1KQmWJ Y2sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Sud2CcmA00fuWaxY4yirsGbjBPAdIx+zThhEOEnCTto=; b=dY6vl4H2ectmJFggKDl9k07j4BwKM2xkTCnFEJp7pYMYL5ccXiZj4giKHIImVpCVhG S5Ex/x7Y8FOKY4fLNZl/YVq/595HRUWEBDFDq7AKtttXdI5QlpF9n91ue3s/FinM81fJ L6qa8x1SgVWmNoN8MeeE5GkNhll3NlSKvkxdaho7lKXfnMd7eaiNB2iJPCjt5pjvKWtZ 1D5pgwzAstIDJB+QGpTpvn0FENjEHIHUu/fnkYGndK1TpWfcQWs6fTyDHOOVWUAHHMNT ium6hwr5vA+sDb9+GrA57x+Xhl6Cfe1BctoUb3hQG3QUKERgZvqsw9H/0uqqWnQIamdU jMKQ== X-Gm-Message-State: AMke39mDnI8NTwaGzRRisSjFFmf0isbVbLQaKKS9Bnz3+wUoeYcHmQI+5CMYvJj+bOakHA== X-Received: by 10.28.45.197 with SMTP id t188mr16141563wmt.15.1486500755552; Tue, 07 Feb 2017 12:52:35 -0800 (PST) Received: from localhost.localdomain ([91.179.185.46]) by smtp.gmail.com with ESMTPSA id g5sm9320846wrd.0.2017.02.07.12.52.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Feb 2017 12:52:34 -0800 (PST) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Christopher Li , Rasmus Villemoes , Luc Van Oostenryck Subject: [PATCH v3 2/5] simplify '(x / 1)' to 'x' Date: Tue, 7 Feb 2017 21:50:25 +0100 Message-Id: <20170207205028.35869-3-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170207205028.35869-1-luc.vanoostenryck@gmail.com> References: <20170207205028.35869-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently we simplify multiplication by 1 but nothing for the similar divide by 1. This patch add the missing simplification together with its test cases. Signed-off-by: Luc Van Oostenryck --- simplify.c | 1 + validation/optim/muldiv-by-one.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/simplify.c b/simplify.c index b242b64d6..91021dbb1 100644 --- a/simplify.c +++ b/simplify.c @@ -348,6 +348,7 @@ static int simplify_constant_rightside(struct instruction *insn) case OP_ASR: return simplify_asr(insn, insn->src1, value); + case OP_DIVU: case OP_DIVS: case OP_MULU: case OP_MULS: return simplify_mul_div(insn, value); diff --git a/validation/optim/muldiv-by-one.c b/validation/optim/muldiv-by-one.c index ac8ac95b2..f6dd7cb2c 100644 --- a/validation/optim/muldiv-by-one.c +++ b/validation/optim/muldiv-by-one.c @@ -3,6 +3,8 @@ typedef int si; si smul1(si a) { return a * 1; } ui umul1(ui a) { return a * 1; } +si sdiv1(si a) { return a / 1; } +ui udiv1(ui a) { return a / 1; } /* * check-name: muldiv-by-one @@ -10,4 +12,5 @@ ui umul1(ui a) { return a * 1; } * check-output-ignore * * check-output-excludes: mul[us]\\. + * check-output-excludes: div[us]\\. */