diff mbox

use VOID instead of directly using &void_pseudo

Message ID 20170220104536.12105-1-luc.vanoostenryck@gmail.com (mailing list archive)
State Mainlined, archived
Headers show

Commit Message

Luc Van Oostenryck Feb. 20, 2017, 10:45 a.m. UTC 
---
 linearize.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christopher Li Feb. 27, 2017, 3:40 p.m. UTC | #1 
On Mon, Feb 20, 2017 at 6:45 PM, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
>
> diff --git a/linearize.c b/linearize.c
> index 99203d915..6908e9f57 100644
> --- a/linearize.c
> +++ b/linearize.c
> @@ -1862,7 +1862,7 @@ static pseudo_t linearize_return(struct entrypoint *ep, struct statement *stmt)
>         struct basic_block *active;
>         pseudo_t src = linearize_expression(ep, expr);
>         active = ep->active;
> -       if (active && src != &void_pseudo) {
> +       if (active && src != VOID) {

Looks good.  Can you add S-O-B for this?

Thanks

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Luc Van Oostenryck Feb. 27, 2017, 9:23 p.m. UTC | #2 
On Mon, Feb 27, 2017 at 4:40 PM, Christopher Li <sparse@chrisli.org> wrote:
> On Mon, Feb 20, 2017 at 6:45 PM, Luc Van Oostenryck
> <luc.vanoostenryck@gmail.com> wrote:
>>
>> diff --git a/linearize.c b/linearize.c
>> index 99203d915..6908e9f57 100644
>> --- a/linearize.c
>> +++ b/linearize.c
>> @@ -1862,7 +1862,7 @@ static pseudo_t linearize_return(struct entrypoint *ep, struct statement *stmt)
>>         struct basic_block *active;
>>         pseudo_t src = linearize_expression(ep, expr);
>>         active = ep->active;
>> -       if (active && src != &void_pseudo) {
>> +       if (active && src != VOID) {
>
> Looks good.  Can you add S-O-B for this?
>
> Thanks

Sure.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/linearize.c b/linearize.c
index 99203d915..6908e9f57 100644
--- a/linearize.c
+++ b/linearize.c
@@ -1862,7 +1862,7 @@  static pseudo_t linearize_return(struct entrypoint *ep, struct statement *stmt)
 	struct basic_block *active;
 	pseudo_t src = linearize_expression(ep, expr);
 	active = ep->active;
-	if (active && src != &void_pseudo) {
+	if (active && src != VOID) {
 		struct instruction *phi_node = first_instruction(bb_return->insns);
 		pseudo_t phi;
 		if (!phi_node) {