From patchwork Fri Feb 24 06:54:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9589483 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A8290601AE for ; Fri, 24 Feb 2017 06:56:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 981DE28776 for ; Fri, 24 Feb 2017 06:56:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 89CBC287A1; Fri, 24 Feb 2017 06:56:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 351C428776 for ; Fri, 24 Feb 2017 06:56:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751172AbdBXG4m (ORCPT ); Fri, 24 Feb 2017 01:56:42 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36629 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbdBXG4m (ORCPT ); Fri, 24 Feb 2017 01:56:42 -0500 Received: by mail-wm0-f66.google.com with SMTP id r18so1467103wmd.3 for ; Thu, 23 Feb 2017 22:56:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=5yQWUmvNZrf81IWjLee3brMqbiGP69n7SySf9snmH2g=; b=p2POhtfWI6kl9fzENz3Xy10ziriYLo9xC2WKp6KdM+IvArwqXLL5CbsVdTjaNmBtEX sLjFPeGUqQ2SiM4JCRSo4WOI4TshjcWBQurDL5GCMAQVMsKMiG6Q3UXyMvOEN+TFOfTF h8N3nmzPfhlZvY88J2B06gJKNuctsZDTWuAA5flHoMwy8e0GQMvxLDNdckYcTVcB60uA h92M/n/whC739AYlfp0Cy2D1cEQbDke9axStdG91jup2hQCvNLTvUrQLlu9yLI7pAyEa ih3CZh63HMlNkCiX67j4y1jDzKK7+suQBIwzTJRIErDUeEHIBTTYHJUXfbhCSzDhsOl6 WlKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5yQWUmvNZrf81IWjLee3brMqbiGP69n7SySf9snmH2g=; b=NqfweLz9eyLht1yMRQRYglCoZ0dkn1e7rsswzsb1IGYiX2CXb/mieVqV0uVGb+eiKp g6zm/GH4X/g1NpOwiuUSBwVe08449HK86VCVtHor0RdCex7vLYvkGOk+zFoaQPPubskT iC11FHulbgvGayS5W+yARee1tQPUYFmyC59f8PLj3P0ukqcQAHoc8LDuo6kHNJ5g/KUG /1YmC7jKolE+BUCpzQMB941qr1yDjqJDk8nFeDw1XaamjrwyW7mLp5/gQx6r/zk8hn+f TEbeFl4EpJSgMJAPr8cSvDmiWKO7DceC+IYjOzVk0sb96SJmJ9/a1YUHbW/x8VjNMJAq 8ZIg== X-Gm-Message-State: AMke39k14ofNzLcWlqm53X8smqucg5bo/Sc9JKbRaiFsJiG8647WXkASTh6WzEa5GLoHbA== X-Received: by 10.28.61.136 with SMTP id k130mr1185694wma.128.1487919400280; Thu, 23 Feb 2017 22:56:40 -0800 (PST) Received: from localhost.localdomain ([2a02:a03f:821:b600:ac49:d8cc:cf7:ed9]) by smtp.gmail.com with ESMTPSA id h3sm9092074wrb.31.2017.02.23.22.56.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Feb 2017 22:56:39 -0800 (PST) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Christopher Li , Luc Van Oostenryck Subject: [PATCH] fix usage in simplify_seteq_setne() Date: Fri, 24 Feb 2017 07:54:34 +0100 Message-Id: <20170224065434.46976-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.11.1 Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The usage was removed before the new operands were used which can lead to undefined pseudos. Fix this by moving the call to remove_usage() where it should always have been: after the call to use_pseudo(). Signed-off-by: Luc Van Oostenryck --- simplify.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/simplify.c b/simplify.c index 3bc9985e8..76a599e50 100644 --- a/simplify.c +++ b/simplify.c @@ -432,7 +432,8 @@ static int compare_opcode(int opcode, int inverse) static int simplify_seteq_setne(struct instruction *insn, long long value) { - struct instruction *def = insn->src1->def; + pseudo_t old = insn->src1; + struct instruction *def = old->def; pseudo_t src1, src2; int inverse; int opcode; @@ -456,10 +457,10 @@ static int simplify_seteq_setne(struct instruction *insn, long long value) // and similar for setne/eq ... 0/1 src1 = def->src1; src2 = def->src2; - remove_usage(insn->src1, &insn->src1); insn->opcode = compare_opcode(opcode, inverse); use_pseudo(insn, src1, &insn->src1); use_pseudo(insn, src2, &insn->src2); + remove_usage(old, &insn->src1); return REPEAT_CSE; default: