From patchwork Sat Mar 11 14:16:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9618765 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 34313604A9 for ; Sat, 11 Mar 2017 14:21:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E29C287AD for ; Sat, 11 Mar 2017 14:21:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F26E9287B3; Sat, 11 Mar 2017 14:21:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8613B287AD for ; Sat, 11 Mar 2017 14:21:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932860AbdCKOTf (ORCPT ); Sat, 11 Mar 2017 09:19:35 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35666 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755674AbdCKOTH (ORCPT ); Sat, 11 Mar 2017 09:19:07 -0500 Received: by mail-wm0-f67.google.com with SMTP id z63so3126292wmg.2 for ; Sat, 11 Mar 2017 06:19:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=yIUnnoqJ+koCO2XjLxaYyETCqepR+lwMtPcC1y5ykN8=; b=CMfKbr1YZfjqnQrNK6jic+EvJ5YsXorEAjQ9mXy543Z4InxUVFVnQPx3t9vstaTRGJ aBxXX4e+oGSY0DAxPDwiJuzq8MzTxLeTWu23PeOpbR/VknK5UalqBYtGlar6IvV/qgte iQ7O8UaiA6kiHy2rvZPXdLt23LRWAfcztSkeHw+Cl6+hh8qEbRXC5hwBr/dyL2/94hKb SD5eOECnuNlAi6la+eci49kBO0GiVlu1h3OwqxEDpI8bwLxHnnBXnCJahCatuGLclolz drprO965VzpmBMFQxaVrR0CAZMEG4l0UcYhwmY5JupsN4S0sNBST2v4d0vgyWadiPUyH v+OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yIUnnoqJ+koCO2XjLxaYyETCqepR+lwMtPcC1y5ykN8=; b=mQab+z35DoxiWnNhKYSmMBvzsodjTbefx7mMq4ey6y4/5xGLuhCuGRvqW6wvTEOlBH 9wN+/EfnWUDj0lc/Ng5GIlB5HxhVPDGS0nJIlL20SNxtc8DozwuHHkJ1Nq3QS1KYpuLn zWAqPjHVQhlKtdpKQl7WH0e2/dfkGB2JfWKSX7gJgr+hh9DDhXbQeLNbAcgqp9fabwZB uZwwhS8TRHQXoBIJNnFu2+NccoECJDdj+7IRfyMMDYjD4V78v9cDFu2uJBtfQAtc5KCk 8Jx7MRoN0soOiTBkKOyd9TSuqhTkcd0P88T77BvA/NiLG5lzoLd+yVV6p18DiaR8SiRI wimQ== X-Gm-Message-State: AFeK/H2SdO0tmz5XAJjb3k8tXzwvNdHtEjNZpwcwbgeLhKNtVxWn4FlTPH4JB4ImK37JdQ== X-Received: by 10.28.238.140 with SMTP id j12mr3137599wmi.35.1489241945481; Sat, 11 Mar 2017 06:19:05 -0800 (PST) Received: from localhost.localdomain ([2a02:a03f:8df:aa00:8824:8320:e6e0:1e9b]) by smtp.gmail.com with ESMTPSA id m186sm3786166wmd.21.2017.03.11.06.19.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Mar 2017 06:19:04 -0800 (PST) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Christopher Li , Luc Van Oostenryck Subject: [PATCH] fix cast to pointer to floating-point Date: Sat, 11 Mar 2017 15:16:59 +0100 Message-Id: <20170311141659.36768-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.11.1 Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP By mistake, a cast to floating-pointer pointer was created as OP_FPCAST instead of OP_PTRCAST. Fix this by adding the missing 'else'. Signed-off-by: Luc Van Oostenryck --- linearize.c | 3 +-- validation/fp-vs-ptrcast.c | 13 +++++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) create mode 100644 validation/fp-vs-ptrcast.c diff --git a/linearize.c b/linearize.c index 255231c60..6397f68a7 100644 --- a/linearize.c +++ b/linearize.c @@ -1119,8 +1119,7 @@ static struct instruction *alloc_cast_instruction(struct symbol *src, struct sym base = base->ctype.base_type; if (base != &void_ctype) opcode = OP_PTRCAST; - } - if (base->ctype.base_type == &fp_type) + } else if (base->ctype.base_type == &fp_type) opcode = OP_FPCAST; return alloc_typed_instruction(opcode, ctype); } diff --git a/validation/fp-vs-ptrcast.c b/validation/fp-vs-ptrcast.c new file mode 100644 index 000000000..817aee5c9 --- /dev/null +++ b/validation/fp-vs-ptrcast.c @@ -0,0 +1,13 @@ +float *f01(void* p) +{ + return p; +} + +/* + * check-name: fp-vs-ptrcast + * check-command: test-linearize -Wno-decl $file + * check-output-ignore + * + * check-output-excludes: fpcast + * check-output-contains: ptrcast + */