From patchwork Tue Mar 21 00:15:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9635663 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 95F5660327 for ; Tue, 21 Mar 2017 00:16:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 886CE26E4F for ; Tue, 21 Mar 2017 00:16:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7CEE627B13; Tue, 21 Mar 2017 00:16:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 06CA7275A2 for ; Tue, 21 Mar 2017 00:16:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755877AbdCUAQh (ORCPT ); Mon, 20 Mar 2017 20:16:37 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:34285 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755839AbdCUAQg (ORCPT ); Mon, 20 Mar 2017 20:16:36 -0400 Received: by mail-wr0-f193.google.com with SMTP id u48so20449337wrc.1 for ; Mon, 20 Mar 2017 17:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IcQPXoP5xZOB+leuYK9kB1oMtdbzg9qrLhxQk67MSXw=; b=Kp002RapWhJFbeMljRHrEEI6wNuvHUsozR3F5/L6k+AZQAw1wi9HZhAxQanMfrh7kj ENH3CEoTRTsJRqZdyStNy9p7JYKDJFFrt+T4RJ59z/WVmL+CC3KXOPTZ8wD9tCd0ozJ6 stKcZMhJyn2USqS9lcWMfvc//PyqPKX/Nt8IbsoyhIyHM+1kEWrnq0VbCkN8WxzsfIEY 7by3vf5Y58yy/LJU+ZFOrKNcPLpN/eS83g4X/ULdOp4PFDULvdxGFvEp/Gymxm9yzGmu 3HNUYEcO116eUNJe4PpMNRO8Vg2Yem7GvB54j0KyAPXQveyRuSOLJWyyfvjaT7sJB8uN qGRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IcQPXoP5xZOB+leuYK9kB1oMtdbzg9qrLhxQk67MSXw=; b=V5ZK620oGFAostE+Jwy7OTX88FCiXCStd78pDJJAdRaisQzBg8zEQrkG3xirhXnVvv zVW7RO0TO20O0XOIZLc0BQLVhUL7tB/aalWy73BQs+0TrUPbcrH1pjHvU+ZtNRIgoOb/ PVN5V7zm1PoeEhZMFjPEf5/wUuv/nujm1xziXU/N/1Fb1KSfDfXTfgRQsEL4WEOAeN41 rVrLMXiTfGwJkn6J+Y0DVDqo2zR75BH0HxkKr+1eoKwPqADHsW+CmTHASSMi4hpcjC6/ iIoiZB9uCPvnteiG/6n5eg0ZEvBga4Y81MKu/afSDDpiRvmSpO0Gm7pYINZSjxTxQFxM 5rSg== X-Gm-Message-State: AFeK/H1HI3kpxsUwrTmZW1uIBR+vvyp1N5L4EW4bXipqpCtM+zPDxKhjnMlnjkIZQ/wrNQ== X-Received: by 10.223.160.143 with SMTP id m15mr30977580wrm.116.1490055394373; Mon, 20 Mar 2017 17:16:34 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:8b8:5c00:403a:a805:fd41:37d2]) by smtp.gmail.com with ESMTPSA id t195sm15271172wmt.32.2017.03.20.17.16.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Mar 2017 17:16:33 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Christopher Li , Dibyendu Majumdar , Jeff Garzik , Pekka Enberg , Luc Van Oostenryck Subject: [PATCH v4 14/63] llvm: remove unneeded 'generation' Date: Tue, 21 Mar 2017 01:15:18 +0100 Message-Id: <20170321001607.75169-15-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170321001607.75169-1-luc.vanoostenryck@gmail.com> References: <20170321001607.75169-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It's not needed here since there is no recursive access to BBs. Signed-off-by: Luc Van Oostenryck --- sparse-llvm.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/sparse-llvm.c b/sparse-llvm.c index 9b702863d..f41fbe6e3 100644 --- a/sparse-llvm.c +++ b/sparse-llvm.c @@ -911,12 +911,10 @@ static void output_insn(struct function *fn, struct instruction *insn) } } -static void output_bb(struct function *fn, struct basic_block *bb, unsigned long generation) +static void output_bb(struct function *fn, struct basic_block *bb) { struct instruction *insn; - bb->generation = generation; - FOR_EACH_PTR(bb->insns, insn) { if (!insn->bb) continue; @@ -930,7 +928,6 @@ static void output_bb(struct function *fn, struct basic_block *bb, unsigned long static void output_fn(LLVMModuleRef module, struct entrypoint *ep) { - unsigned long generation = ++bb_generation; struct symbol *sym = ep->name; struct symbol *base_type = sym->ctype.base_type; struct symbol *ret_type = sym->ctype.base_type->ctype.base_type; @@ -964,9 +961,6 @@ static void output_fn(LLVMModuleRef module, struct entrypoint *ep) static int nr_bb; FOR_EACH_PTR(ep->bbs, bb) { - if (bb->generation == generation) - continue; - LLVMBasicBlockRef bbr; char bbname[32]; struct instruction *insn; @@ -997,12 +991,9 @@ static void output_fn(LLVMModuleRef module, struct entrypoint *ep) END_FOR_EACH_PTR(bb); FOR_EACH_PTR(ep->bbs, bb) { - if (bb->generation == generation) - continue; - LLVMPositionBuilderAtEnd(function.builder, bb->priv); - output_bb(&function, bb, generation); + output_bb(&function, bb); } END_FOR_EACH_PTR(bb); }