From patchwork Mon Mar 27 17:33:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9647243 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 927A7601D7 for ; Mon, 27 Mar 2017 17:38:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 841A128414 for ; Mon, 27 Mar 2017 17:38:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 73F5328409; Mon, 27 Mar 2017 17:38:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 16E3328417 for ; Mon, 27 Mar 2017 17:38:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751353AbdC0Rhc (ORCPT ); Mon, 27 Mar 2017 13:37:32 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34608 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbdC0RhM (ORCPT ); Mon, 27 Mar 2017 13:37:12 -0400 Received: by mail-wr0-f195.google.com with SMTP id w43so12462499wrb.1 for ; Mon, 27 Mar 2017 10:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=O8593d+HF2QIQj0ZN239MLPn+y0r0yLaNSsMMeZ2ZCE=; b=syoAzS85R0hEmjmVDmOY1xWJOdgwqpEBJRpmCnaGIg3340Vm4Qoz/GcGvDt07ROuxg /2V4h9QebNHEUIuli+93dPbWDXoA6mEhUXFQFf1OM3j5uiFRTAImz/BemxybbplDYeqB 8qebtg0OsVgrRRDdqortklIitjjeUhOwoNCSvdWZG0F6lktY+dBgrwEOjB7zGtGpiP8I Nj//8GVOhlhHkwvl31+A4ymHp94P5LMJTJ/su3tgt4mQ5hjFXs32pDuqxXBztXiwXesh BTzbHSl3dxkvJjtoQdzxDwSFvpMC/fELHg2kwONm11SEbWJC0GNYDPFR6GZ3a+IcJnxy fsKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=O8593d+HF2QIQj0ZN239MLPn+y0r0yLaNSsMMeZ2ZCE=; b=lGcHvKMxe0umlWYYifIqV+fzE9SA7Z0g4/pwFZpRezOhSmNwZRVgo6nh9uORNYc2FG QiqWtHcNhRXCR0wmWqncBbOTznRU5QT9K2XeYWTQsZPf135orTcX94WvXJJ2y7INxSjD bay9ObydQvA+Zzh2TMF3R0EMZ5BfMtkVMFmveHGpEx6cyyGoQiSz5owVtr7fNOzjbh9D E8nkmntwJWBHu9z+Pe0UCBRGbsRVYl0dpUEv3FpkaPEMgs+RP5XDwGKjGAQ4/UJ0jc7Y 8g8wiPiHWlad5zymmYY84e/Q49I5KO7dmlH9Gr0VlPZsViIx8gG3dtqVHp2OjRXvxyqw 2Xmw== X-Gm-Message-State: AFeK/H3Tofacllbn2iPa/D0oIju71YK0+2n37Vr5JAL66R6QggB8xD6tPAOtH+JkjoF6yQ== X-Received: by 10.28.7.13 with SMTP id 13mr10855967wmh.16.1490636178958; Mon, 27 Mar 2017 10:36:18 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:802:b00:496:ae63:aebb:a034]) by smtp.gmail.com with ESMTPSA id e72sm304116wma.5.2017.03.27.10.36.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Mar 2017 10:36:18 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Christopher Li , Luc Van Oostenryck Subject: [PATCH v6 06/15] add is_signed_type() Date: Mon, 27 Mar 2017 19:33:56 +0200 Message-Id: <20170327173405.11405-7-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170327173405.11405-1-luc.vanoostenryck@gmail.com> References: <20170327173405.11405-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Luc Van Oostenryck --- compile-i386.c | 14 ++------------ show-parse.c | 11 +---------- symbol.h | 9 +++++++++ 3 files changed, 12 insertions(+), 22 deletions(-) diff --git a/compile-i386.c b/compile-i386.c index 44b72ec39..a7db0843d 100644 --- a/compile-i386.c +++ b/compile-i386.c @@ -192,7 +192,6 @@ static const char *current_section; static void emit_comment(const char * fmt, ...) FORMAT_ATTR(1); static void emit_move(struct storage *src, struct storage *dest, struct symbol *ctype, const char *comment); -static int type_is_signed(struct symbol *sym); static struct storage *x86_address_gen(struct expression *expr); static struct storage *x86_symbol_expr(struct symbol *sym); static void x86_symbol(struct symbol *sym); @@ -1165,7 +1164,7 @@ static void emit_move(struct storage *src, struct storage *dest, if (ctype) { bits = ctype->bit_size; - is_signed = type_is_signed(ctype); + is_signed = is_signed_type(ctype); } else { bits = 32; is_signed = 0; @@ -1357,7 +1356,7 @@ static struct storage *emit_binop(struct expression *expr) if ((expr->op == '/') || (expr->op == '%')) return emit_divide(expr, left, right); - is_signed = type_is_signed(expr->ctype); + is_signed = is_signed_type(expr->ctype); switch (expr->op) { case '+': @@ -2266,15 +2265,6 @@ static void x86_symbol_init(struct symbol *sym) priv->addr = new; } -static int type_is_signed(struct symbol *sym) -{ - if (sym->type == SYM_NODE) - sym = sym->ctype.base_type; - if (sym->type == SYM_PTR) - return 0; - return !(sym->ctype.modifiers & MOD_UNSIGNED); -} - static struct storage *x86_label_expr(struct expression *expr) { struct storage *new = stack_alloc(4); diff --git a/show-parse.c b/show-parse.c index d365d737f..b6ab7b3db 100644 --- a/show-parse.c +++ b/show-parse.c @@ -949,15 +949,6 @@ static int show_symbol_init(struct symbol *sym) return 0; } -static int type_is_signed(struct symbol *sym) -{ - if (sym->type == SYM_NODE) - sym = sym->ctype.base_type; - if (sym->type == SYM_PTR) - return 0; - return !(sym->ctype.modifiers & MOD_UNSIGNED); -} - static int show_cast_expr(struct expression *expr) { struct symbol *old_type, *new_type; @@ -973,7 +964,7 @@ static int show_cast_expr(struct expression *expr) if (oldbits >= newbits) return op; new = new_pseudo(); - is_signed = type_is_signed(old_type); + is_signed = is_signed_type(old_type); if (is_signed) { printf("\tsext%d.%d\tv%d,v%d\n", oldbits, newbits, new, op); } else { diff --git a/symbol.h b/symbol.h index 36f8345b5..0621d36d7 100644 --- a/symbol.h +++ b/symbol.h @@ -335,6 +335,15 @@ static inline int is_enum_type(const struct symbol *type) return (type->type == SYM_ENUM); } +static inline int is_signed_type(struct symbol *sym) +{ + if (sym->type == SYM_NODE) + sym = sym->ctype.base_type; + if (sym->type == SYM_PTR) + return 0; + return !(sym->ctype.modifiers & MOD_UNSIGNED); +} + static inline int is_type_type(struct symbol *type) { return (type->ctype.modifiers & MOD_TYPE) != 0;