From patchwork Thu Apr 6 23:00:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9668537 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6F56A602B8 for ; Thu, 6 Apr 2017 23:00:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 73E8E26E1A for ; Thu, 6 Apr 2017 23:00:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 68D78285DD; Thu, 6 Apr 2017 23:00:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 239F726E1A for ; Thu, 6 Apr 2017 23:00:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753102AbdDFXAl (ORCPT ); Thu, 6 Apr 2017 19:00:41 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33085 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753077AbdDFXAj (ORCPT ); Thu, 6 Apr 2017 19:00:39 -0400 Received: by mail-wr0-f194.google.com with SMTP id g19so15333602wrb.0 for ; Thu, 06 Apr 2017 16:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dPb73PHg8ivtaxSxbFmfYPu4jIuLHExZPeesC8ggjvw=; b=CgIFgf2wbgK4gHDWktcEVhUWuRgKanrYp2SBR4uBjgXij1Rqry6wo/3w1yDdsA4HOQ qlyKh1zUgzhY/zUlH94qKikGQT5GcSOEE1V8yo/SGriz511CJ5vlz2SeSe7NQ+hsURWY JELAj2H5g70/6iIff6HP5vuydxGXf/sg+rPEGDQcNv/h7xKnf9qSUzcU6acDEKjEe0Ee LDjRsmguinLS8ANJtW69g3kIGHj+V9kbHMqWak6zdLbQGQ9XRCW6Uj0qN/+AmM5aQM/i /Sjs+LS/EaBxYHGavJpRNKIfrAfuWh/OGrzh3Lb8ecPqbG+prZ6DiG1GmEwu/Gbk1oSz zHCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dPb73PHg8ivtaxSxbFmfYPu4jIuLHExZPeesC8ggjvw=; b=CQif0N6XOIyiYVH6OI9F91RME+tjcblLTLhxt1JT/c8uTykSzqYxWAF19/c8jvS199 3dp9JdHhP3GyzFW96XD3MPIErXzG258sMZ1CtoR99U4fvrvHdK991SjclLtu90E3a+5L qs3YrT1arizNA7OFx6gEUG9wfbnfPYXJhnt764rtCbExKC25IwbxHi4Dsng9EsSEcOIS 2zUnGGzkvm5k4DuMPRhnHjvnAx3bg39gDV7JBGO+EvfieNP4C16/Fmhe2OIGmve+XfGl /yuHjCnGowZuXJ2Bd6CxWjZTdgHrGN9nkkvkfIYWUjw2FzomltrhsoDfGERv0cKYasKQ e+BQ== X-Gm-Message-State: AN3rC/5rNodJO7AuJm+AUsiogFm2yMsX0qmhUS2zJFMe5nAZurloq7i0fC1Wy92KncJxsQ== X-Received: by 10.223.168.18 with SMTP id l18mr407201wrc.46.1491519638401; Thu, 06 Apr 2017 16:00:38 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:88d:1900:b468:4a21:54b4:3699]) by smtp.gmail.com with ESMTPSA id i7sm4019595wmg.30.2017.04.06.16.00.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Apr 2017 16:00:37 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Linus Torvalds , Christopher Li , Luc Van Oostenryck Subject: [PATCH 3/4] add test case for linearize_initializer() of bitfields Date: Fri, 7 Apr 2017 01:00:28 +0200 Message-Id: <20170406230029.11384-4-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170406230029.11384-1-luc.vanoostenryck@gmail.com> References: <20170406230029.11384-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In linearize_initializer(), 'ad->bit_size' & 'ad->bit_offset' were never set, making the correct initialization impossible (a bit_size of zero being especially bad, resulting in a mask of -1 instead of 0). This is now fixed since 'bit_size' & 'bit_offset' are taken directly from 'result_type'. Signed-off-by: Luc Van Oostenryck --- validation/linear/bitfield-init-mask.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 validation/linear/bitfield-init-mask.c diff --git a/validation/linear/bitfield-init-mask.c b/validation/linear/bitfield-init-mask.c new file mode 100644 index 000000000..94afa400c --- /dev/null +++ b/validation/linear/bitfield-init-mask.c @@ -0,0 +1,27 @@ +struct bfu { + unsigned int a:11; + unsigned int f:9; + unsigned int z:3; +}; + +struct bfu bfu_init_00_11(int a) +{ + struct bfu bfu = { .a = a, }; + return bfu; +} + +struct bfu bfu_init_20_23(int a) +{ + struct bfu bfu = { .z = a, }; + return bfu; +} + +/* + * check-name: bitfield initializer mask + * check-command: test-linearize -fdump-linearize=only -Wno-decl $file + * check-output-ignore + * + * check-output-contains: and\\..*fffff800\$ + * check-output-contains: shl\\..* \\$20 + * check-output-contains: and\\..*ff8fffff\$ + */