From patchwork Wed Apr 12 19:33:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9678275 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A637D60384 for ; Wed, 12 Apr 2017 19:33:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 960682861B for ; Wed, 12 Apr 2017 19:33:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8B38728644; Wed, 12 Apr 2017 19:33:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 347B428641 for ; Wed, 12 Apr 2017 19:33:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755109AbdDLTd4 (ORCPT ); Wed, 12 Apr 2017 15:33:56 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36058 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755081AbdDLTdz (ORCPT ); Wed, 12 Apr 2017 15:33:55 -0400 Received: by mail-wm0-f67.google.com with SMTP id q125so8531379wmd.3 for ; Wed, 12 Apr 2017 12:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=h1i/u0P+XYi3ldpmuAR/d6l+wMj394cOkxZxrL+4ApU=; b=C8S4K9SpeREO/fTBkdliLzQzWq560p99YT0/7bqobajKjF9I+3lS0Hjh3he487ymfS 7tE3glzjAgIgbXhMT8tTFOllKEUxbnUZrGudf2y+o7Qwv6RH5UiHd+hPsFQnpldeENeF X+oA9GZIiQWqc3b73nwC15JbCvF9IwWS6Wf8FkB7frtoqVtDdvttOFxhp+k3tJdhIzsg yzoYDQ7WfD+8aH6JgCgrSRej3blEsnH1jEDHJMHAPerC6ZSP5E5GWzkzBwmt7ROCNPBg ReoYB70VRmLGghq/K3wFlAN2hm2TQlPh4+dg3e8At3bB5TUiQt63+Uo8kPwL4F8ceZm0 PpJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=h1i/u0P+XYi3ldpmuAR/d6l+wMj394cOkxZxrL+4ApU=; b=VnwuMRmL3EYa3b3VsFAh0c81UV+GuvzeVC6No8sN+E14N/Revwt6Cx3JlAPy6xgnpd RQp67tohebxbQ1OgD1GSmGfymuGT7nKBDcWyc38oCF81xO4R/9W3jhivrOaH59kWDECd H1kWJOH6Qh0n73XgY81LNpggwPLgAWLbl8AWTKt5uALMeLWD5X58qj2m+BE8Xp6LoNRT wyt4hAU8F6Nu6QTFbhrwjH/xDUnh0mC9VRZfoDQxo63HVBXnIWKlD+9bMniX4/1aZvry cPzS4omTGFgBHgxhWeM8ybjf//TLYJoyGgcjBvhC+6broUA30O/jskDTcyeE4LQue6He FCkw== X-Gm-Message-State: AN3rC/5RHHC+lr3yZqY7o4e2/HAZo9EHGCTIAa01+QLWaGyzyUUn7ATB ea5VLEjKwfvMVcfXHv0= X-Received: by 10.28.144.200 with SMTP id s191mr21088491wmd.27.1492025633873; Wed, 12 Apr 2017 12:33:53 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:8b2:dc00:6c54:829e:388a:2472]) by smtp.gmail.com with ESMTPSA id h20sm7733401wmd.29.2017.04.12.12.33.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Apr 2017 12:33:53 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Christopher Li , Luc Van Oostenryck Subject: [PATCH 2/6] simplify intermediate casts in boolean expressions Date: Wed, 12 Apr 2017 21:33:40 +0200 Message-Id: <20170412193344.95935-3-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170412193344.95935-1-luc.vanoostenryck@gmail.com> References: <20170412193344.95935-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For example: int ibior(bool a) { return a || a; } before simplification gives: setne.1 %r40 <- %arg1 setne.1 %r42 <- %arg2 or.1 %r43 <- %r40, %r42 cast.32 %r44 <- (1) %r43 ret.32 %r44 after simplification of the 'or', it used to give: setne.1 %r40 <- %arg1, $0 cast.32 %r44 <- (1) %r40 ret.32 %r44 and now give: setne.32 %r44 <- %arg1, $0 ret.32 %r44 Signed-off-by: Luc Van Oostenryck --- simplify.c | 17 +++++++++++++++++ validation/optim/bool-simplify.c | 6 ++---- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/simplify.c b/simplify.c index b46acd9c2..09d7ae056 100644 --- a/simplify.c +++ b/simplify.c @@ -982,6 +982,23 @@ static int simplify_cast(struct instruction *insn) goto simplify; } + if (insn->opcode == OP_CAST) { + struct instruction *def = src->def; + if (!def) + return 0; + switch (def->opcode) { + case OP_BINCMP ... OP_BINCMP_END: + insn->opcode = def->opcode; + use_pseudo(insn, def->src1, &insn->src1); + use_pseudo(insn, def->src2, &insn->src2); + remove_usage(src, &insn->src); + return REPEAT_CSE; + + default: + break; + } + } + return 0; simplify: diff --git a/validation/optim/bool-simplify.c b/validation/optim/bool-simplify.c index 05be11497..2014d344c 100644 --- a/validation/optim/bool-simplify.c +++ b/validation/optim/bool-simplify.c @@ -32,16 +32,14 @@ and_0: and_1: .L2: - setne.1 %r8 <- %arg1, $0 - cast.32 %r11 <- (1) %r8 + setne.32 %r11 <- %arg1, $0 ret.32 %r11 or_0: .L4: - setne.1 %r14 <- %arg1, $0 - cast.32 %r17 <- (1) %r14 + setne.32 %r17 <- %arg1, $0 ret.32 %r17