diff mbox

[6/6] testsuite: avoid fork+execing basename

Message ID 20170528192906.1023-7-luc.vanoostenryck@gmail.com (mailing list archive)
State Mainlined, archived
Headers show

Commit Message

Luc Van Oostenryck May 28, 2017, 7:29 p.m. UTC 
Some testcase (the ones related to sparse-llvm) are disabled if
the needed support is not present. This is done by checking
the name of the command used by the testcase.

The previous possible presence of './' before the command meant
that the command was checked via the 'basename' command, which
need to ne fork+execed.
Since the './' have now been stripped from all command names
this is no more needed.

Change this by comparing directly the command name.

This speedup the testsuite by another 6%.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 validation/test-suite | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff mbox

Patch

diff --git a/validation/test-suite b/validation/test-suite
index da9d88159..3056fce90 100755
--- a/validation/test-suite
+++ b/validation/test-suite
@@ -189,11 +189,10 @@  do_test()
 	if [ "$check_command" = "" ]; then
 		check_command="$defaut_command"
 	fi
-	cmd=`eval echo $default_path/$check_command`
 
 	# check for disabled commands
-	set -- $cmd
-	base_cmd=`basename $1`
+	set -- $check_command
+	base_cmd=$1
 	for i in $disabled_cmds; do
 		if [ "$i" = "$base_cmd" ] ; then
 			disabled_tests=$(($disabled_tests + 1))
@@ -202,6 +201,8 @@  do_test()
 		fi
 	done
 
+	cmd=`eval echo $default_path/$check_command`
+
 	echo "     TEST    $test_name ($file)"
 
 	verbose "Using command       : $cmd"