From patchwork Wed May 31 03:22:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9755727 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3437B602CA for ; Wed, 31 May 2017 03:22:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 27555205F8 for ; Wed, 31 May 2017 03:22:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1C3EA28474; Wed, 31 May 2017 03:22:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 06B1D205F8 for ; Wed, 31 May 2017 03:22:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751118AbdEaDWY (ORCPT ); Tue, 30 May 2017 23:22:24 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34731 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088AbdEaDWW (ORCPT ); Tue, 30 May 2017 23:22:22 -0400 Received: by mail-wm0-f67.google.com with SMTP id d127so1025819wmf.1 for ; Tue, 30 May 2017 20:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BeO3hUtT2CJSV5si6TT9u4I/ofuwgHdsnlt8wdb2xtM=; b=kfmxhnvLeDrTI6ZUmK+C+MYf5DAOA7vnmpCmPlhRu8XgjK2m7zQ/3TPCy88r/+pcZ3 FqFgkSVoRHHNa43syVhfXjJLYCNuR62bUERN8643TqNANv+xnljAQJEQazmTkwwUPb0E XVvrQEJ4RSRe5jYgYcTmU9zrlkMoWPMHlmANTw7/67OwH80acMupsXnwTZS3Sdfh2hUY 8ku+F5dVYFb74ylgvzpg5V6Dom0GsmLsxn4ZGJzmTCe36xWSqvBfj4RncGHK7GV1mT7f iLYpT8gE0cUzTrwDJztWgn0aiZjccep43myHqqnzsfjc7DOcc8H3NBvS5C370waShpVR GGKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BeO3hUtT2CJSV5si6TT9u4I/ofuwgHdsnlt8wdb2xtM=; b=r8TCSZsu6ttq1KU8rR32gPYdQ3L6w/nroy9TAana9ON+YoS+TjeIbMyz2lPyjN7s6Q aerEYnUD5gAJSJKb4XY6D3XvJV4FgRlMQS0opWHtP/YnnEZLp9aJIc6D/X56iuDuFS1z 5U6SK2iD87EsBWuQsa/wOnbtQ6ShWtMSwVFixaI0DuiL4YRRNl/7BawMaDnB4obt3P8r Wm+fcusxAJTTHSmUx4VpY8NegI1nL4MWrfok0LdP3UE4soJclDjGpOAHtZheqqAzQEGi dkFSLNbbovu09YF32NT5enqEd6ySFQfXUNvYDpl8C2G+gdT89sy859hMUgR/1rXrPTRz Q+gg== X-Gm-Message-State: AODbwcAzJR2vr57j3bgovZF+t24bWQ6n81L2o3ZqkM2u2jUuL+jdg0DW qgv/OMBH/OKQTPNQE1E= X-Received: by 10.28.130.213 with SMTP id e204mr3492117wmd.33.1496200941300; Tue, 30 May 2017 20:22:21 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:89c:5400:25d0:8511:1e85:9d96]) by smtp.gmail.com with ESMTPSA id y3sm31676991wmh.21.2017.05.30.20.22.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 May 2017 20:22:20 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Luc Van Oostenryck Subject: [PATCH 6/9] div0: use -Wdiv-by-zero Date: Wed, 31 May 2017 05:22:04 +0200 Message-Id: <20170531032207.95830-7-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170531032207.95830-1-luc.vanoostenryck@gmail.com> References: <20170531032207.95830-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Luc Van Oostenryck --- expand.c | 4 ++-- linearize.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/expand.c b/expand.c index 0b528ea5a..8fd258e25 100644 --- a/expand.c +++ b/expand.c @@ -278,7 +278,7 @@ static int simplify_int_binop(struct expression *expr, struct symbol *ctype) expr->taint = left->taint | right->taint; return 1; Div: - if (!conservative) + if (!conservative && Wdiv_by_zero) warning(expr->pos, "division by zero"); return 0; Overflow: @@ -363,7 +363,7 @@ static int simplify_float_binop(struct expression *expr) expr->fvalue = res; return 1; Div: - if (!conservative) + if (!conservative && Wdiv_by_zero) warning(expr->pos, "division by zero"); return 0; } diff --git a/linearize.c b/linearize.c index 7760ea996..604a67b82 100644 --- a/linearize.c +++ b/linearize.c @@ -967,7 +967,7 @@ static void warn_undef_insn(struct instruction *insn, int warn) case OP_MODU: case OP_MODS: if (is_pseudo_value(insn->src2, 0)) { - if (warn) + if (warn && Wdiv_by_zero) warning(insn->pos, "division by zero"); } break;