From patchwork Sat Jun 3 08:01:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9764051 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F24F3602B6 for ; Sat, 3 Jun 2017 08:01:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E44BC28236 for ; Sat, 3 Jun 2017 08:01:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D92E5285C7; Sat, 3 Jun 2017 08:01:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 85C0128236 for ; Sat, 3 Jun 2017 08:01:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751150AbdFCIBs (ORCPT ); Sat, 3 Jun 2017 04:01:48 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34799 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149AbdFCIBr (ORCPT ); Sat, 3 Jun 2017 04:01:47 -0400 Received: by mail-wm0-f68.google.com with SMTP id d127so22056512wmf.1 for ; Sat, 03 Jun 2017 01:01:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Yl4qt+3lm84XjdN/yx76J70Zn2FZvGOZTTmBcY3vtDY=; b=QahJxdrTdJ8MTbXlWglys0NGyi81BFSMjEMbh17NA21afXzUz6SXKRZ/O9gdrsIUIG yKJVVgRfkxcCfuPRfs+gawdeEiB4s7L0BNzXs80QYVt+dxKs+KlvVR6wTnkp+YoEIEkd lxLzruiDsT6gh4z6PQ8erlOhXoJcnhpVaFUAkuy6zvx2RKavwOw5aS7w94OLBjzy2XxE ciQjtb4Co5GEv9+YLvHZEeD27EraDnNgSFv5mfo8xrIT9Tb5x0+sPBbDWVeCZMzviCVf iAIy/sNtGeEtgjWcBpkeFZTsJ3coJKIaFb16olvMR3KmXyQfYuisX/ugkSwjCudqKeP3 Pb0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Yl4qt+3lm84XjdN/yx76J70Zn2FZvGOZTTmBcY3vtDY=; b=Y8UK0/BI8d8ylT89AhDEdZYJfjaE4L99Kl8Xvu2mFg6w3JZM2mHuL8LKGR2oNhkv8Z WFDJ4RXTYhSmDpd4QMxCeFfWu3+9GNcMniUJR8VKLj/2mkz24ihOnALUAQPNG3m3r42J HLM4Sle7xiD1mgayn/AEExU8bX3Vqjj1+xaRslKQyTlOLR+j6U4rOXCu9CZJ62Xd4/dV 1QqhdheX5klUh4/nSAAbxmPJLFUnLQFavKSohWmdymiU+k+LWrL3pIf0GCSQ/kY0Cxm0 fPu9cG4JCIlmaug+xzKEEYbmk4tSd21aBMQS6IsfnY/kO7umgeaMJ9UQNU9Xas0qqTFx bwzQ== X-Gm-Message-State: AODbwcC9ATYak5mPUiyUtINhS+JfRHCJVDBhKN3dgvkhSXYXEfXhWaz5 Wm1+24aiTBUWWIJwCUQ= X-Received: by 10.80.164.175 with SMTP id w44mr8803601edb.19.1496476905880; Sat, 03 Jun 2017 01:01:45 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:89c:5400:65b4:e9ec:d7a6:723a]) by smtp.gmail.com with ESMTPSA id j7sm1065641edh.36.2017.06.03.01.01.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Jun 2017 01:01:45 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Chris Li , Luc Van Oostenryck Subject: [PATCH v2 4/8] div0: also check for compound assignments Date: Sat, 3 Jun 2017 10:01:31 +0200 Message-Id: <20170603080135.46477-5-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170603080135.46477-1-luc.vanoostenryck@gmail.com> References: <20170603080135.46477-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP --- expand.c | 12 ++++++++++++ validation/div-by-zero.c | 6 ++++++ 2 files changed, 18 insertions(+) diff --git a/expand.c b/expand.c index 0b528ea5a..5bbab17a9 100644 --- a/expand.c +++ b/expand.c @@ -559,6 +559,18 @@ static int expand_assignment(struct expression *expr) { expand_expression(expr->left); expand_expression(expr->right); + if (!conservative) { + switch (expr->op) { + case SPECIAL_DIV_ASSIGN: + case SPECIAL_MOD_ASSIGN: + if (expr->right->type != EXPR_VALUE) + break; + if (expr->right->value) + break; + warning(expr->pos, "division by zero"); + break; + } + } return SIDE_EFFECTS; } diff --git a/validation/div-by-zero.c b/validation/div-by-zero.c index 500ceb8eb..bd8d0dfdf 100644 --- a/validation/div-by-zero.c +++ b/validation/div-by-zero.c @@ -59,8 +59,14 @@ div-by-zero.c:17:30: warning: division by zero div-by-zero.c:18:30: warning: division by zero div-by-zero.c:19:30: warning: division by zero div-by-zero.c:21:42: warning: division by zero +div-by-zero.c:22:30: warning: division by zero div-by-zero.c:25:42: warning: division by zero +div-by-zero.c:26:30: warning: division by zero +div-by-zero.c:29:42: warning: division by zero +div-by-zero.c:30:42: warning: division by zero div-by-zero.c:35:37: warning: division by zero div-by-zero.c:36:37: warning: division by zero +div-by-zero.c:37:37: warning: division by zero +div-by-zero.c:38:37: warning: division by zero * check-error-end */