From patchwork Mon Jul 31 20:36:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9873113 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 12CE56038F for ; Mon, 31 Jul 2017 20:36:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 020EF27F3E for ; Mon, 31 Jul 2017 20:36:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EB2B5285DB; Mon, 31 Jul 2017 20:36:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A51DB285E2 for ; Mon, 31 Jul 2017 20:36:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751157AbdGaUgj (ORCPT ); Mon, 31 Jul 2017 16:36:39 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:38564 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751126AbdGaUgi (ORCPT ); Mon, 31 Jul 2017 16:36:38 -0400 Received: by mail-wr0-f194.google.com with SMTP id g32so15233090wrd.5 for ; Mon, 31 Jul 2017 13:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oinx/QhwZDYu0BL5rEoLtdvPb41JnZlj/bXDqTnw8EM=; b=jDlVMdNAbp7G/YFFOvxOUzYlOO+neOQATTtUtaIQ1wKtNxsig7YnoTIbv4HHSCXDnF DjOYtAkzk4z0kCFRGLRyH1y/NtB7jQ+WwUjAHscMbqAq/XZQOStMNxmuC+iI3/u4EXb4 rMyHsezjW2IH+jde89WsJWsFjOyAiArpFmAdjzjx0FtlJxtjIUVi9Zakkifomp3n6xRi hW4+lBFmPPLyxuIelmETsg45RfGn+bCKGP4sZ4mb3a8S7jCFP25c4mL7KMbd87eteP6V O7UcLHaYyYU+AWRAh9J0dZ1YvcFiRqORKNkE1nz96+FLhpjPMeqCfVmWxUX4/45nNsJL fkGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oinx/QhwZDYu0BL5rEoLtdvPb41JnZlj/bXDqTnw8EM=; b=gcEusdHS7YMG5d3mG2x5ERB2A6oXs1f1NZHdnWEh2o8PumrxEP9FX9k2jHffIXr66H RotiOY0wTozs1SX8woFHFM01U+XYrfVX9ap8OS55e+irb3cxKLdIDDcUQUlGLNjmZmq3 rJg/jWJm6DWKTIHtVDLX43kdB+R4ek10qQRpw3dnxHv84+ekPPv0qpwx+UMo5N2djBx9 VrZXy9qAJUwWR6+bh+91jX7zEzBYCHUkN+eXAyIRp2a4Vu0rJIGfint0OS9DXlB0URhq w5sTForAErZ7pfyNqX5UBdb8PQ9y7OaaT8XcKcD7OAwAU4LK9dxeNrqr/0MWmKg8+4t+ wKFA== X-Gm-Message-State: AIVw110WuGxLNxb+fNgVBwdfFEwHo7kQpqDo8UdlWWg0wBA3OC6EtLkv utdj8/Vj91fNRQ== X-Received: by 10.223.171.79 with SMTP id r15mr12842079wrc.57.1501533397492; Mon, 31 Jul 2017 13:36:37 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40c4:ab00:f976:d678:e4f6:5c60]) by smtp.gmail.com with ESMTPSA id n7sm47682350wrb.37.2017.07.31.13.36.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Jul 2017 13:36:36 -0700 (PDT) From: Luc Van Oostenryck To: Christopher Li Cc: linux-sparse@vger.kernel.org, Michael Stefaniuc , Luc Van Oostenryck Subject: [PATCH v3 4/7] fix crash when ep->active is NULL Date: Mon, 31 Jul 2017 22:36:21 +0200 Message-Id: <20170731203624.58971-5-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170731203624.58971-1-luc.vanoostenryck@gmail.com> References: <20170731203624.58971-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Luc Van Oostenryck --- linearize.c | 9 +++++++-- validation/crash-ep-active.c | 12 ++++++++++++ 2 files changed, 19 insertions(+), 2 deletions(-) create mode 100644 validation/crash-ep-active.c diff --git a/linearize.c b/linearize.c index a36720779..12209492b 100644 --- a/linearize.c +++ b/linearize.c @@ -820,10 +820,15 @@ static pseudo_t argument_pseudo(struct entrypoint *ep, int nr) pseudo_t alloc_phi(struct basic_block *source, pseudo_t pseudo, int size) { - struct instruction *insn = alloc_instruction(OP_PHISOURCE, size); - pseudo_t phi = __alloc_pseudo(0); + struct instruction *insn; + pseudo_t phi; static int nr = 0; + if (!source) + return VOID; + + insn = alloc_instruction(OP_PHISOURCE, size); + phi = __alloc_pseudo(0); phi->type = PSEUDO_PHI; phi->nr = ++nr; phi->def = insn; diff --git a/validation/crash-ep-active.c b/validation/crash-ep-active.c new file mode 100644 index 000000000..6945f320b --- /dev/null +++ b/validation/crash-ep-active.c @@ -0,0 +1,12 @@ +int a(int b) +{ + return 0( && b; +} + +/* + * check-name: crash ep->active + * check-command: test-linearize $file + * + * check-error-ignore + * check-output-ignore + */