From patchwork Mon Aug 7 19:12:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9886055 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 18C7F603F9 for ; Mon, 7 Aug 2017 19:12:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 08E8A2860A for ; Mon, 7 Aug 2017 19:12:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F1F67286B6; Mon, 7 Aug 2017 19:12:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A15AC286C3 for ; Mon, 7 Aug 2017 19:12:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751927AbdHGTMW (ORCPT ); Mon, 7 Aug 2017 15:12:22 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:37353 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940AbdHGTMU (ORCPT ); Mon, 7 Aug 2017 15:12:20 -0400 Received: by mail-wm0-f67.google.com with SMTP id t138so2044144wmt.4 for ; Mon, 07 Aug 2017 12:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8nCewqNt6LVBtHX0RWv2ERP0zZtNEMwsXaGHncIoPAo=; b=j5VLUdkKcpfvF5fIibQbZ0KXiFJ+kmqmIg/KJCg85mWCAb6n/wgEH04VRMubSoqJOy S6+2oxWLkU60MGByfwbydeA2hKo3NZiWLQi1CWu/6i49KBSNTPw8ECAEEQaCQ/NBIJMf dI7NBjOv9A1wRt8MukRbFQFMT+BJVJOlk67Gpve9mVuILPPg54wyCuQx8QhHzAhMO967 u4TURl2CgTOlP+FTN80tkPi8WW9udKs9XnUbN3G92x24V9Az72a/xCgtOe6tshSBhW1g 137N9qvewQ3AuPeI5w77qmY+8nmDMNO3fIMDm0xVycnCcW+uDidMWZ/bPXBQHtFgQO+6 GfTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8nCewqNt6LVBtHX0RWv2ERP0zZtNEMwsXaGHncIoPAo=; b=DC3KzoD43iWCCTEzvpxt4FJnIREymdHMIE7afy1pSPN2x5RreiNPk68XPpWP4HaHFk 7nzp3z98TzfV7oYXhatsA/pcuOKdb30s4DfhOUopTiN9nyWy1l49BHAgzRaCV0ziAyFJ D9m25goBfOTAIrUFNCKMEReEkXC6Z8RrCGG5CzK1fzfxU6t5bayttaCrwpR0NbBuvxIi 3WObeou9WZZoAsCBQ77FgcjB1NWKxcenWzoVDx3WRVB0vY4k1y5BEDH8eHrizbh1yziE ra2vG5krQMVWCeyIWG+/EIYb22R5a9eR8xFyvX2/j9ZAlnOQPTv3f67boC3L7nX30PaV pdIQ== X-Gm-Message-State: AHYfb5iJwv+OnRn+ksiJZYv61RANWxnZX7ce4629LeCnbFhmDyiR4CSo EO1fYMGghpkF9w== X-Received: by 10.80.217.4 with SMTP id t4mr1804018edj.225.1502133138898; Mon, 07 Aug 2017 12:12:18 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:4076:600:29ff:6bdc:a0fa:4163]) by smtp.gmail.com with ESMTPSA id g52sm7742064edg.34.2017.08.07.12.12.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Aug 2017 12:12:18 -0700 (PDT) From: Luc Van Oostenryck To: Dibyendu Majumdar Cc: linux-sparse@vger.kernel.org, Luc Van Oostenryck Subject: [PATCH v2 8/8] fix: cast of OP_AND only valid if it's an OP_CAST Date: Mon, 7 Aug 2017 21:12:05 +0200 Message-Id: <20170807191205.86590-9-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170807191205.86590-1-luc.vanoostenryck@gmail.com> References: <20170807191205.86590-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A cast of an OP_AND can be simplified away if the mask already 'cover' the value. However this cannot be done if the cast is in fact a sign-extension. Fix this by adding the appropriate check of OP_CAST vs. OP_SCAST Fixes: caeaf72d34d1e91aaea7340241232d1d877907b7 Signed-off-by: Luc Van Oostenryck --- simplify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simplify.c b/simplify.c index cdc244c17..4da8edfde 100644 --- a/simplify.c +++ b/simplify.c @@ -1044,7 +1044,7 @@ static int simplify_cast(struct instruction *insn) } /* A cast of a "and" might be a no-op.. */ - if (def_opcode(src) == OP_AND) { + if (insn->opcode == OP_CAST && def_opcode(src) == OP_AND) { struct instruction *def = src->def; if (def->size >= size) { pseudo_t val = def->src2;