From patchwork Wed Aug 9 19:38:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9891737 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7B52A603F2 for ; Wed, 9 Aug 2017 19:39:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6D76F2832D for ; Wed, 9 Aug 2017 19:39:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 62A0628500; Wed, 9 Aug 2017 19:39:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 036BD283AD for ; Wed, 9 Aug 2017 19:39:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932AbdHITjJ (ORCPT ); Wed, 9 Aug 2017 15:39:09 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:38250 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884AbdHITjJ (ORCPT ); Wed, 9 Aug 2017 15:39:09 -0400 Received: by mail-wm0-f65.google.com with SMTP id y206so598669wmd.5 for ; Wed, 09 Aug 2017 12:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=A42s2v78ODv4PMCb9iTD3bT6PMthY4Xnvd1WLh5hZNE=; b=VqtA5ibN0dbR6M3ZgmOab1/mWJDY2spd2OyO3C1nTf960yy/ob2cA6MrN37tpMoyrK jyHN/k3A7GPt4HDbliKHDdElQCsAIbOp1VtlqlrM2BXqsB1JUMl9G3dfCu7aPCRp9yNB UWT/5lG8nWLo2XcbhBXxZGdhikwD2PlrbN531nPK/B9ki7aeyGvRkGJncR3Mxh6NZGhX eh4KUa8+vzXMoC4P2pt6UBST+uFagVyRgx3pNQhtfbsMOnlRdIutgcIctGnDgLh4BBJm QWSrwnpjS8jeeNjeFgJ2EzDPs6tvD/CvQZ3NF4+nJLtzRmU+J3bv557qJUZphyF5QOWm 0QFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=A42s2v78ODv4PMCb9iTD3bT6PMthY4Xnvd1WLh5hZNE=; b=G+d/B6CY4Czjlo0Y+u735lHyuVlIcFyboZWBt35ksRw3ue4NJjxdY3h8enDA8PCxPm f7ldHCEFAEuXNGOcxPnk95RaM3FJ/5BWc9LlONFaJ1j6dyEGp05bfT5iwD43iwHeavw6 IG06sqTMx2qE7pVVbJxjgEX3G0pP5GyvECia1ipPhioYTLnQsLr5+/Eibaoo3XD9nAiz ElvpJ7/RGhoplWGM9DgHAbc0xPv2552yLD4l/mSpTa6yYzt5q+UXdrg2MLDcy1fRbNPL KEmjl3gV8iU5BkXvq7kc0OKH9WKkz5KQmDC/IQt38wQZQyo2z7XUhDPyMiI8UfhPY7ar X+JA== X-Gm-Message-State: AHYfb5gvhf+MbazH9zD/a+49SQXEP8IM6DPKcuN4JxiOdnNMM6SkOq7N hkDbg4l4gfAsaxzXEc8= X-Received: by 10.80.221.2 with SMTP id t2mr9496569edk.134.1502307547926; Wed, 09 Aug 2017 12:39:07 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:4076:600:a54f:2a42:70ce:5bd2]) by smtp.gmail.com with ESMTPSA id t36sm2984437edb.38.2017.08.09.12.39.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Aug 2017 12:39:07 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Christopher Li , Luc Van Oostenryck Subject: [PATCH v4 9/9] fix: cast of OP_AND only valid if it's an OP_CAST Date: Wed, 9 Aug 2017 21:38:06 +0200 Message-Id: <20170809193806.30975-10-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.14.0 In-Reply-To: <20170809193806.30975-1-luc.vanoostenryck@gmail.com> References: <20170809193806.30975-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A cast of an OP_AND can be simplified away if the mask already 'cover' the value. However this cannot be done if the cast is in fact a sign-extension. Fix this by adding the appropriate check of OP_CAST vs. OP_SCAST Fixes: caeaf72d34d1e91aaea7340241232d1d877907b7 Signed-off-by: Luc Van Oostenryck --- simplify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simplify.c b/simplify.c index 370d4cb81..dc4fd457b 100644 --- a/simplify.c +++ b/simplify.c @@ -1036,7 +1036,7 @@ static int simplify_cast(struct instruction *insn) } /* A cast of a "and" might be a no-op.. */ - if (def_opcode(src) == OP_AND) { + if (insn->opcode == OP_CAST && def_opcode(src) == OP_AND) { struct instruction *def = src->def; if (def->size >= size) { pseudo_t val = def->src2;