From patchwork Mon Aug 14 19:41:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9899979 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 916DF602CA for ; Mon, 14 Aug 2017 19:42:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8518127853 for ; Mon, 14 Aug 2017 19:42:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 796012846D; Mon, 14 Aug 2017 19:42:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 248C527853 for ; Mon, 14 Aug 2017 19:42:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751047AbdHNTmD (ORCPT ); Mon, 14 Aug 2017 15:42:03 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:37847 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbdHNTmD (ORCPT ); Mon, 14 Aug 2017 15:42:03 -0400 Received: by mail-wm0-f65.google.com with SMTP id t138so15521728wmt.4 for ; Mon, 14 Aug 2017 12:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=In9qEzvJ6ug/UYAN7dd5hh86ieLiorTDG7p1+wyBjoc=; b=q82jEZ9mhqjn6fUPmmqJF+8D4FiMpb6LPvhq05q9G66BZGyEF7CwV6xHHGGDSfyacn 5mnn4fQnl+rpwHC9+CrJhRhoKhrNRFzsnOlpY4R9bFIjsAEp8A1MsqUZRSSei6mYzwxq 1dLLOdi1G6ATm7Ht0tssbImCZ5uvt7qeLxO4g4q00mu/u3n1SGcVmllqSlwfYYI9iRVN pnGm2snMdPgZDXBfC2Uu9pEy7r+UxAPXNDtIUQcV7UKlXGtgiVhx30Z58Qz3QLIctY6s FAo1PkcGJuA6Vp3OtuhabZxbmo5oOlfOTL2jcb2UxtoNqkyB2/5eWsXrbwgCeOeFCV97 NF4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=In9qEzvJ6ug/UYAN7dd5hh86ieLiorTDG7p1+wyBjoc=; b=WA8zUovjehEqkzMqNUWmHgdjxLXck4BRSMqPIe4rOnY80XrUy+NUdqd0QHff3GgFpx iWXPoL2f9MNn/rcmhKJ6jwY2dmzKF1y9pERbI2sO9IGDlNgZsdsJRqIAq1HoLUKh37Zc ZCIyyoMqe2Y+lt2eMNHZ2oSqfdgKgZfFxunAz48pwOBUnSj4e5jKgIIJCswZrz5zEjOM CIqmKmA968BfLjaXalyOfynUpBr+GJVlC4OD6GcmDPuESiiOOeyxkquMMRTmJjEb/BEi kbVxiRpCw8RtMAHecf74NqbIfciO9KstPHADJYFx23vuwGRXqxR3RIhZjnvJZ0jJrNuv Skzg== X-Gm-Message-State: AHYfb5jabavhSAHNamjekLV42t/ckim/YfWcqrksZo8REpNpX+xFTHyY rwZfgfkoiauItIr/DHU= X-Received: by 10.80.224.200 with SMTP id j8mr25335940edl.230.1502739721997; Mon, 14 Aug 2017 12:42:01 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:4076:600:b867:f5d9:f1d5:3f94]) by smtp.gmail.com with ESMTPSA id o30sm4708128edi.90.2017.08.14.12.42.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Aug 2017 12:42:01 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Dibyendu Majumdar , Luc Van Oostenryck Subject: [PATCH 1/2] llvm: warn instead of assert on global inits Date: Mon, 14 Aug 2017 21:41:50 +0200 Message-Id: <20170814194152.36289-2-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.14.0 In-Reply-To: <20170814194152.36289-1-luc.vanoostenryck@gmail.com> References: <20170814194152.36289-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently, sparse-llvm can't emit the needed code for all initializers and when it's the case it stop abruptly with an assert(0). This is kinda useless. Somehow fix this by issuing a warning instead and try to continue gracefully. Signed-off-by: Luc Van Oostenryck --- sparse-llvm.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sparse-llvm.c b/sparse-llvm.c index 3a68d09d9..9a32efe36 100644 --- a/sparse-llvm.c +++ b/sparse-llvm.c @@ -1212,7 +1212,9 @@ static LLVMValueRef output_data(LLVMModuleRef module, struct symbol *sym) break; } default: - assert(0); + warning(initializer->pos, "can't initialize type: %s", show_typename(sym)); + initial_value = NULL; + break; } } else { LLVMTypeRef type = symbol_type(sym); @@ -1220,6 +1222,9 @@ static LLVMValueRef output_data(LLVMModuleRef module, struct symbol *sym) initial_value = LLVMConstNull(type); } + if (!initial_value) + return NULL; + name = sym->ident ? show_ident(sym->ident) : "" ; data = LLVMAddGlobal(module, LLVMTypeOf(initial_value), name);