| Message ID | 20170816153455.97693-16-luc.vanoostenryck@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Wed, Aug 16, 2017 at 11:34 AM, Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote: > Add an helper to remove the usage of a pseudo, like kill_use() > do but unlike kill_use(), without trying to kill (recursively!) > the defining instruction if the usage drop to zero. > > > +/* > + * Like kill_use() but do not recursively kill instructions > + * that become without users. > + */ > +void remove_use(pseudo_t *usep) remove_use() vs remove_usage() in the above code look a bit too close to tell apart. This two have total different behavior not reflecting in the name. I was confused there for a second. That is before I notice the subtle different between remove_use() vs remove_usage() Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/flow.h b/flow.h index b592ad4d3..3133245e5 100644 --- a/flow.h +++ b/flow.h @@ -24,6 +24,7 @@ extern int simplify_instruction(struct instruction *); extern void kill_bb(struct basic_block *); extern void kill_use(pseudo_t *); +extern void remove_use(pseudo_t *); extern void kill_unreachable_bbs(struct entrypoint *ep); extern void kill_insn(struct instruction *, int force); diff --git a/simplify.c b/simplify.c index 2bc86f53e..d007bee02 100644 --- a/simplify.c +++ b/simplify.c @@ -202,6 +202,19 @@ void kill_use(pseudo_t *usep) } } +/* + * Like kill_use() but do not recursively kill instructions + * that become without users. + */ +void remove_use(pseudo_t *usep) +{ + pseudo_t p = *usep; + *usep = VOID; + if (has_use_list(p)) { + delete_pseudo_user_list_entry(&p->users, usep, 1); + } +} + static void kill_use_list(struct pseudo_list *list) { pseudo_t p;
Add an helper to remove the usage of a pseudo, like kill_use() do but unlike kill_use(), without trying to kill (recursively!) the defining instruction if the usage drop to zero. It will be used during SSA construction, when it is not yet safe to kill instructions. If the usage drop to zero, nothing special is done, the instruaction becomes dead and will be eliminated later. Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> --- flow.h | 1 + simplify.c | 13 +++++++++++++ 2 files changed, 14 insertions(+)