From patchwork Wed Aug 16 15:34:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9903973 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1711760231 for ; Wed, 16 Aug 2017 15:35:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0921A22B27 for ; Wed, 16 Aug 2017 15:35:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F2650286AC; Wed, 16 Aug 2017 15:35:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE79922B27 for ; Wed, 16 Aug 2017 15:35:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751678AbdHPPfU (ORCPT ); Wed, 16 Aug 2017 11:35:20 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:33923 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbdHPPfT (ORCPT ); Wed, 16 Aug 2017 11:35:19 -0400 Received: by mail-wr0-f195.google.com with SMTP id x43so3696812wrb.1 for ; Wed, 16 Aug 2017 08:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=URlmXwLbK0t0NyiRr0ri2lq5qVF3MXPPQUNaIyOdQmI=; b=gUnk7705OmfsJXsgbpFXvh4aNsc8F9dzDM8xhRSlB/iyixIZ8h99qflxtNK/7ciKjY 2bvKsnBP4KN2tegUkvCe2MIom6m7CT/JHa4AVmbiGigX5oIiuXVFTc7Y5bXjDshLnJsY VfublBoM5LjkHR+iyzn+kfTjPzLsAsUoLv6gF4R6hzW3NP+L0ffxehbCa5IeZ4OJ1Yae e3QeWJ7v4Y9HKv9ai1OhEt2mLj1Ov9NINW/Ea5yXi8Sh/xq6EuuogbEPukQAm2/l10ZS +3glPwjksn0TSzxIIHqRVsLiHQo/66cnPGR+r4pVPethmz7U+5G7d9iXor7BFkt3DA8H m/hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=URlmXwLbK0t0NyiRr0ri2lq5qVF3MXPPQUNaIyOdQmI=; b=UbtpvGJ23nX/jap5cxfqwjAahNdtvPNqOEW8u8Axba4C3ZXSmpwL4d3dVbnmcSGofe LtIzbhjZskRK27VcJgY5p9vdEkNNGBn4GxQzC75BjuFNa4zQPUQggUtM8rJxJnvviWzx L/Ee71T+BOQGhBM47hPwKdq8gdJwIp1K0HxMewL5112n90iN96GVhA3mgM427xGeKkna 31DnMdDBLWY4RVd6Qbw42ARiwOKZQSafVwCESluan6jPdlZKtPdJnPAN+w759Z2nsMyd Nk+nKSmXOBGNxzCnXVteBl794eG63HLSykCD7g0U+z7KtLvNclmpuBbOEHi1HJCThmTT je1A== X-Gm-Message-State: AHYfb5iZy5P6LAq+vizxpV3cOf1ekJF0DL4aBRyjoI6gXb3v6J74rDou ph8wxf53WmPi4r0WJf4= X-Received: by 10.80.208.217 with SMTP id g25mr2293079edf.229.1502897718685; Wed, 16 Aug 2017 08:35:18 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:4076:600:895a:bb88:13f:9772]) by smtp.gmail.com with ESMTPSA id y19sm690635edi.6.2017.08.16.08.35.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Aug 2017 08:35:18 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Linus Torvalds , Christopher Li , Luc Van Oostenryck Subject: [PATCH 07/29] ret-void: return nothing only for void functions Date: Wed, 16 Aug 2017 17:34:33 +0200 Message-Id: <20170816153455.97693-8-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.14.0 In-Reply-To: <20170816153455.97693-1-luc.vanoostenryck@gmail.com> References: <20170816153455.97693-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Only void functions should return nothing. Others functions should return something and if not we want to be able to emit a diagnostic. Fix this by testing the return type instead of the size of the return type. Signed-off-by: Luc Van Oostenryck --- linearize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linearize.c b/linearize.c index 298991dcd..69e4f3e8f 100644 --- a/linearize.c +++ b/linearize.c @@ -2218,7 +2218,7 @@ static struct entrypoint *linearize_fn(struct symbol *sym, struct symbol *base_t struct symbol *ret_type = base_type->ctype.base_type; struct instruction *insn = alloc_typed_instruction(OP_RET, ret_type); - if (type_size(ret_type) > 0) + if (!is_void_type(ret_type)) use_pseudo(insn, result, &insn->src); add_one_insn(ep, insn); }