From patchwork Thu Aug 17 04:05:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9904927 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D9A1B60244 for ; Thu, 17 Aug 2017 04:06:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CCF7A28414 for ; Thu, 17 Aug 2017 04:06:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C1D0528946; Thu, 17 Aug 2017 04:06:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6B48928414 for ; Thu, 17 Aug 2017 04:06:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750755AbdHQEGC (ORCPT ); Thu, 17 Aug 2017 00:06:02 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:38436 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbdHQEGB (ORCPT ); Thu, 17 Aug 2017 00:06:01 -0400 Received: by mail-wr0-f194.google.com with SMTP id 49so33699wrw.5 for ; Wed, 16 Aug 2017 21:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sTbFDvcdTjK//AryBppWtxivgWK72OPLgq9O3EF2pW4=; b=T4VdAfFa7pNaTh1XThJuj5rwQ1euWgFr8EF3ymSavMT/L58Iqnal22XW/c8mp/RI2G 1BHukwc6J+8fmAdz74bjzVNbKhSG1pe8AGGKSTvnc5Le+oWr+yyk4T6DC9qUqX8HThzb PGKYoQ7LCUu/Ubo9gtdkJ62HdbU744+nsiAMmF2XHECERr8MKCCkjv99AYNF1d5Z5qZD vnO56Vj5oPnFLaWMlZd2e8v2KqXmtCnpKHqseGBE0JbYTc8/5snqgVpVZYWvRcYv2Rer 669kirLA3Y8esn/B2YUMDJsc7EdKsN2MHGnfLc3eNWzyO29eWYCe07nmUZoQTm+dWj9C 3nfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sTbFDvcdTjK//AryBppWtxivgWK72OPLgq9O3EF2pW4=; b=RZOgBo9VBB+Z4sWLw+8koHMp3dmRe9Dhy6KqI8QQuG9nEV6sj3ZKOTB9yxkF7Rz9dE DV07oBH2oo/CQKw8XHSDB29gP8ZsxT0OnCfxCEACckj5VlvNNRQnkkwlyuMoOHpRXv1N Wp+N9Ip4U6iWQJoJy8PF5C/f7zR9x4ggi/pyzf1wbb3YUwJT31xnjp7K/WeDHw195dCn 5tzKf3Sa9n/Fr+2RB0Io+tRPhS07SyHcU3jtV4xDZ4o6H9XtrWvXP6B6B0PX+6ZbrQ+L g9Th7aB2MIvwI/MPhC26S/NWrGqKb5hyO/NIGSt+jXxp3N+UsDPXzC/ahW1r3jCFZ05o nInQ== X-Gm-Message-State: AHYfb5iiOxHn1BLM4L/mtM7Hy0OuKsLQVp53a9PvIGGLMyJwrRD1tlHm 31EhRFUUEyh16+AuUUs= X-Received: by 10.80.216.141 with SMTP id p13mr584988edj.10.1502942760052; Wed, 16 Aug 2017 21:06:00 -0700 (PDT) Received: from localhost.localdomain (1.84-65-87.adsl-dyn.isp.belgacom.be. [87.65.84.1]) by smtp.gmail.com with ESMTPSA id e12sm1378134edj.72.2017.08.16.21.05.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Aug 2017 21:05:59 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Linus Torvalds , Christopher Li , Dibyendu Majumdar , Luc Van Oostenryck Subject: [RFC PATCH 10/14] cast: temporary simplify handling cast to/from void* Date: Thu, 17 Aug 2017 06:05:25 +0200 Message-Id: <20170817040529.7289-11-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.14.0 In-Reply-To: <20170817040529.7289-1-luc.vanoostenryck@gmail.com> References: <20170817040529.7289-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently pointer cast from/to void are treated as casts to/from integer. The rationale being that a void pointer can't anyway be dereferenced. Allow to contnue to do by using a new 'machine type' for void pointer which then allow to select the right type of cast: OP_PTRCAST or OP_[S]CAST. Signed-off-by: Luc Van Oostenryck --- linearize.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/linearize.c b/linearize.c index 8be26db58..01e6abde8 100644 --- a/linearize.c +++ b/linearize.c @@ -1121,6 +1121,7 @@ enum mtype { MTYPE_UINT, MTYPE_SINT, MTYPE_PTR, + MTYPE_VPTR, // TODO: must be removed ? MTYPE_FLOAT, MTYPE_BAD, }; @@ -1135,8 +1136,7 @@ retry: switch (s->type) { goto retry; case SYM_PTR: if (s->ctype.base_type == &void_ctype) - // handle void pointer like an uint - goto case_int; + return MTYPE_VPTR; return MTYPE_PTR; case SYM_BITFIELD: case SYM_RESTRICT: @@ -1180,14 +1180,25 @@ static int get_cast_opcode(struct symbol *dst, struct symbol *src) switch (stype) { case MTYPE_UINT: case MTYPE_SINT: - if (is_ptr_type(src)) // must be a void pointer - return OP_PTRCAST;// FIXME: to be removed? return OP_UTPTR; case MTYPE_PTR: + case MTYPE_VPTR: return OP_PTRCAST; default: return OP_BADOP; } + case MTYPE_VPTR: + switch (stype) { + case MTYPE_PTR: + case MTYPE_VPTR: + case MTYPE_UINT: + return OP_CAST; + case MTYPE_SINT: + return OP_SCAST; + default: + return OP_BADOP; + break; + } case MTYPE_UINT: case MTYPE_SINT: switch (stype) {