From patchwork Thu Aug 17 04:05:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9904917 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8321960244 for ; Thu, 17 Aug 2017 04:05:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75C6028414 for ; Thu, 17 Aug 2017 04:05:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6ABE928946; Thu, 17 Aug 2017 04:05:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 14E3328414 for ; Thu, 17 Aug 2017 04:05:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750741AbdHQEFu (ORCPT ); Thu, 17 Aug 2017 00:05:50 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:34588 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755AbdHQEFu (ORCPT ); Thu, 17 Aug 2017 00:05:50 -0400 Received: by mail-wr0-f193.google.com with SMTP id x43so6181332wrb.1 for ; Wed, 16 Aug 2017 21:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SPsdLBnQvOQxE9lB0kVP2ygX7dNzZORWO91v0bS075I=; b=IlFxbq+EC2VsOcyTtjYIxviAqs+fetInAUOylvayqM+6b0yX3Qs//ShuhpOyKzq5k7 SgEJ7iOZOgUBTdvtGvL4Dw/WtTwygrY9XIUpqXy5oKtXAoNhVBeS9Qezyj2CNqo1aBNv VHxbhkfjiMjzsuzNQoMlyyUqZXMMpVRLRZreCyeY4iTyG7mHXhAv0svp16EWQuLyXe4Z ogHn23KTbapSBYP4VjZpRZlF9wkFTf3ya2iNEkCacJd3b0LKoYp+L7hChJ7oZA4WDtTl rSHsafHNhVU8IOclHbnMeJBsXKn2njPgXkD7E9WDdIYVc6OXq3HORS3IUR4dNkvCd9Z8 9lIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SPsdLBnQvOQxE9lB0kVP2ygX7dNzZORWO91v0bS075I=; b=t0tkLn+GDtgcQ+5Ta9HcPER6AV7s9Lxg0q/cEQ0XNPvXJQxAcn8tPOjWYiEpbg2pdy NJCKcQmZI+B3iXyLahn1yrKk94yZtOSubFYEfemC+RRGpJEvuD74BQ4qyAbTxM4CjsfF 1qoe8HmnUT3y0CuYjmVFWtV/anXAG0mpu6N0xIW2Vk7BYwYbiPbTiW5lFjmmnNbWKjOz H1pA1LiiX+VXlr0vfTLLQ/TEEPUFd3p+2WxQCLc3ukciwPbmv9uey85FHuw29mFf/xcD iYnCFRIMOkpaBKjDmgn39v6FXF0/J8JrJqSfkdwtovtQ9V+ySe5nAJd20Z30u5iKCRV2 Xutw== X-Gm-Message-State: AHYfb5jVKyy/SBeyjR7Oe1b3qbulQIWOYXbeWmz8pR3+84MJDkAIM43Q CUfK9i5gHjQhaUvcr50= X-Received: by 10.80.162.69 with SMTP id 63mr555353edl.244.1502942748980; Wed, 16 Aug 2017 21:05:48 -0700 (PDT) Received: from localhost.localdomain (1.84-65-87.adsl-dyn.isp.belgacom.be. [87.65.84.1]) by smtp.gmail.com with ESMTPSA id e12sm1378134edj.72.2017.08.16.21.05.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Aug 2017 21:05:48 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Linus Torvalds , Christopher Li , Dibyendu Majumdar , Luc Van Oostenryck Subject: [RFC PATCH 05/14] cast: handle NO-OP casts Date: Thu, 17 Aug 2017 06:05:20 +0200 Message-Id: <20170817040529.7289-6-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.14.0 In-Reply-To: <20170817040529.7289-1-luc.vanoostenryck@gmail.com> References: <20170817040529.7289-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some casts, the ones which deosn't chnage the size or the resulting 'machine type', are no-op. Directly simplify away such casts. Signed-off-by: Luc Van Oostenryck --- linearize.c | 8 ++++++++ validation/cast-kinds.c | 15 +++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/linearize.c b/linearize.c index 7f8dbc64a..3f8d955c5 100644 --- a/linearize.c +++ b/linearize.c @@ -1161,6 +1161,8 @@ static int get_cast_opcode(struct symbol *dst, struct symbol *src) case MTYPE_FLOAT: switch (stype) { case MTYPE_FLOAT: + if (dst->bit_size == src->bit_size) + return OP_NOP; return OP_FCVTF; case MTYPE_UINT: return OP_UCVTF; @@ -1198,6 +1200,12 @@ static pseudo_t cast_pseudo(struct entrypoint *ep, pseudo_t src, struct symbol * if (from->bit_size < 0 || to->bit_size < 0) return VOID; opcode = get_cast_opcode(to, from); + switch (opcode) { + case OP_NOP: + return src; + default: + break; + } insn = alloc_typed_instruction(opcode, to); result = alloc_pseudo(insn); insn->target = result; diff --git a/validation/cast-kinds.c b/validation/cast-kinds.c index 34bf685d2..0312bc92b 100644 --- a/validation/cast-kinds.c +++ b/validation/cast-kinds.c @@ -50,6 +50,9 @@ static double long_2_double(long a) { return (double)a; } static double ulong_2_double(ulong a) { return (double)a; } static double float_2_double(float a) { return (double)a; } +static float float_2_float(float a) { return a; } +static double double_2_double(double a) { return a; } + /* * check-name: cast-kinds * check-command: test-linearize -m64 $file @@ -383,5 +386,17 @@ float_2_double: ret.64 %r143 +float_2_float: +.L96: + + ret.32 %arg1 + + +double_2_double: +.L98: + + ret.64 %arg1 + + * check-output-end */