From patchwork Thu Aug 17 22:35:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9907227 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 852E96038C for ; Thu, 17 Aug 2017 22:36:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 77B9C28B49 for ; Thu, 17 Aug 2017 22:36:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A99428BFA; Thu, 17 Aug 2017 22:36:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E614F28B49 for ; Thu, 17 Aug 2017 22:36:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753402AbdHQWgM (ORCPT ); Thu, 17 Aug 2017 18:36:12 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:33198 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753324AbdHQWgM (ORCPT ); Thu, 17 Aug 2017 18:36:12 -0400 Received: by mail-wr0-f195.google.com with SMTP id n88so10664371wrb.0 for ; Thu, 17 Aug 2017 15:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6sa7UKx05gf1cih7Blq0O8alXlyDOtVjCz2Xbw9Q/Ys=; b=vLBGds5/TwyZsx+nFBPbaxd3twuSMaa1ETXaD/p9b4HARqrBt9LsV6zLEfbphfY4LJ MIxGkOB9D8N5IBlrlgAXrE883/njZV2BuFq12LCYH4WPW60BhMpjoqBYMJNKLa2RM0LK Mw8ntoKA/K/iHJLcY3vhaV1ZInlsjDVNCG3qRR30U6sGOwVKPnlew5Kuy7AfeRRT7pOo W6yKgZALxSJVergUrlQiVWc1Cy9UDpfJDJr2LIGuomCkGKwJBaxVwM30CFoKw0bJYIth 8sV3z8FVs/lpGMksC08FbRRgS2/SKr3kA60vvACXV7XneYleFXpKK6MayzTwBov1jftd ejpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6sa7UKx05gf1cih7Blq0O8alXlyDOtVjCz2Xbw9Q/Ys=; b=b+i9lNjkfSn32ZN4V4lmZeQ9GtcvDyZ+MNXChB6Ov+3ZAqSrglUxhzOWPwp8U1dOeH utjSx4yOwQ8mN+RZ9X6+6kGj5mZxF9zb1/V9usr81yPAmj8pgerMsond/uaRb7dTIFea PcRsg5DUF2BRmg4aNgz5evDO05o5zJowrlRadPJthQg1NinOtygsZvoFNHkzv5Zk+fwj rz3cMMjcgEplmVwEvaLMNVf3Ipk6WmtKxps+tJY8g5uYn31YyKGYvn5myrzN9xfNCR3m 5nk4XKMdOoczlfHODIYmfQP8G33kSC7jTSq/kXQD+Aad4NsLbBfrS+u6usXhF+yy/f8w MsRg== X-Gm-Message-State: AHYfb5gT8WQpyOhf3vruBmJDQP7FkmdZIB2lJVJLcVd4q6PuX1ee91GR JreV63NyVkSiMlapr+0= X-Received: by 10.80.140.65 with SMTP id p59mr2988951edp.0.1503009370718; Thu, 17 Aug 2017 15:36:10 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:4076:600:bd00:c690:eda9:7a94]) by smtp.gmail.com with ESMTPSA id g54sm2882230eda.19.2017.08.17.15.36.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Aug 2017 15:36:10 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Christopher Li , Dibyendu Majumdar , Luc Van Oostenryck Subject: [RFC PATCH 2/4] fold is_simple_var() into simple_access() Date: Fri, 18 Aug 2017 00:35:56 +0200 Message-Id: <20170817223558.21258-3-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.14.0 In-Reply-To: <20170817223558.21258-1-luc.vanoostenryck@gmail.com> References: <20170817223558.21258-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP --- linearize.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/linearize.c b/linearize.c index 9a7a71d3a..63c896fc7 100644 --- a/linearize.c +++ b/linearize.c @@ -978,16 +978,7 @@ static inline int is_simple_type(struct symbol *type) return 0; } -static inline int is_simple_var(struct symbol *var) -{ - if (!is_simple_type(var)) - return 0; #define MOD_NONREG (MOD_STATIC|MOD_NONLOCAL|MOD_ADDRESSABLE|MOD_VOLATILE) - if (var->ctype.modifiers & MOD_NONREG) - return 0; - return 1; -} - static inline struct symbol *simple_access(struct access_data *ad) { pseudo_t addr = ad->address; @@ -996,7 +987,9 @@ static inline struct symbol *simple_access(struct access_data *ad) if (addr->type != PSEUDO_SYM) return NULL; sym = addr->sym; - if (!is_simple_var(sym)) + if (sym->ctype.modifiers & MOD_NONREG) + return NULL; + if (!is_simple_type(sym)) return NULL; return sym; }